Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 31 Aug 2023 17:47:49 +0100
From:   Giovanni Cabiddu <giovanni.cabiddu@intel.com>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
CC:     Jinjie Ruan <ruanjinjie@huawei.com>, <qat-linux@intel.com>,
        <linux-crypto@vger.kernel.org>, <damian.muszynski@intel.com>,
        <shashank.gupta@intel.com>, <tom.zanussi@linux.intel.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        "David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH -next] crypto: qat - Use list_for_each_entry() helper
Message-ID: <ZPDENa0eem5zVNHH@gcabiddu-mobl1.ger.corp.intel.com>
References: <20230830075451.293379-1-ruanjinjie@huawei.com>
 <ZPCY1EEFz0opLpvo@smile.fi.intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <ZPCY1EEFz0opLpvo@smile.fi.intel.com>
Organization: Intel Research and Development Ireland Ltd - Co. Reg. #308263 -
 Collinstown Industrial Park, Leixlip, County Kildare - Ireland
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?RbMb/r/zZM4jsdMtwMs6k4wp9uhVpfrzKc32rqEV7cFO0O2MY/kPOTvZ5fGy?=
 =?us-ascii?Q?KRbsZS/QY9B9UedlJfE25PU2t0Fr6juRbgho0ZQi22qDP85DqmZdf5D/lwno?=
 =?us-ascii?Q?0YeEpRPdZihTybAIKDgckc2USudf1TT4/Uq8ck3/KFAGTwSSPl8EV0oaJeGa?=
 =?us-ascii?Q?JWzLI0KRMeiHFVYUBk1VF5Whct2v76IR5Lgy0fAdpHjyQTyqZbsIMb0DDiQW?=
 =?us-ascii?Q?9CF69A4rt0K6qs8wo4ZUuNcBfTW2lAK/vXn1PssSNEQxwXeq9Qu6Yj5cqcAA?=
 =?us-ascii?Q?Ev2zS/ABs/X1yOz3+9C6gd4zYEzv7qYRxC3VMIjxG98PC8T4ifVRmOpfgkld?=
 =?us-ascii?Q?cERdATLRBzhUOv3bZ9WlYmkC+p2Zh6EZIoWpEtdKYwlbp5/7JapOq4I3/74E?=
 =?us-ascii?Q?erKArUta5D7YQkVU3xjmPYUFldfOq26crnmZSquagnO4/vLTY3CIp5oD/2Zk?=
 =?us-ascii?Q?P9kUsSHK8jNIgUxCuVVPpMCLSlxJelrrDPctcC0sZLsGSonitsDvEd7IjUS0?=
 =?us-ascii?Q?+Rl6ZNl522CB4cWI2JpOBVhCRRNK0EaW2evSI0PDjSm7LFGlO2vw0sr617Gb?=
 =?us-ascii?Q?Bb/4nd+swkS/pu5z5p61All4Pg/dtayYtJRXL7mTlK993boIu6zDK/Wga8DH?=
 =?us-ascii?Q?s2p+VwQMYFFh6XXsKQLRW4aLGR1Dk5RmFI+7dkimF1KpF/ZO9WUvZuQQWtaW?=
 =?us-ascii?Q?RJQ/DcYkAXf+sfWV75ApHVqwHqlcBZVzw7a6h5VjFHVR++iiU/j4/FG53ktS?=
 =?us-ascii?Q?tr3kbF9hR+fXwGg8Rx2rB+LPHBRZHPemqfuf/T81y8d7RjeEfMfEhEmMNvL9?=
 =?us-ascii?Q?6swDh556bDBFnop/ZvQ1nreLZdcWvlt480eqTXTpsVAwtkt8alnuNkHg+cGR?=
 =?us-ascii?Q?fwIP9a9y2i9Q46hrDgJNNH1zc7yTx3wZfVdGyiEFxIt42ifF1Ulkac+DVx6Y?=
 =?us-ascii?Q?yXRstfC2EH+TbqSfq23eddnZ28kBt/JJdaplu3r5pRJUvcV3ka3aJK0N7rDP?=
 =?us-ascii?Q?G/90J3Cw9u9quWNfuEj1D8UHLG1eggNpPYS0/lcc5fZi8W2rMc5VHjIEFibi?=
 =?us-ascii?Q?QQ2HWjzt0r81HISh3Cnc2Rgzu09OZbobsa5dNSd3nunv9a0DJFnu7JBbPD6g?=
 =?us-ascii?Q?LYfQf3D+kinu/Ci4b5xYS6pe6IM7GagmBbir+qHtelYNdB/6UgZJOTrIT6ZY?=
 =?us-ascii?Q?nQaOtnzu2SgHL7BRRmiwiwNmXvqFV+QxIaHFbIPCF8Deg+9hMxYYMix+npu3?=
 =?us-ascii?Q?vwsYc3NPMgCtemgtGl1XOIUPOtNl+wa8cyAE8XLweu4x2Zewl6yXXlwvhkrD?=
 =?us-ascii?Q?FzJ50lDZ+ECFC6NAAFSyQH0Joja7MD7c+BI4+reSbkN5Te9Uq5Gre1i1xnom?=
 =?us-ascii?Q?wOsZHZLp0r+c7MyVZVVQc6R/R9BaUAbhdaoo/kJuCVMtzHDOWHB3yWYcR75B?=
 =?us-ascii?Q?zj+7qoyj04HNMlWgejE38vDbUmtYlmdTXNd30tcL3siqbz5dO8rTn21wP3yV?=
 =?us-ascii?Q?+3SfXOuYBE9UX8ce8zAQN+W5mHKh13jBK0SRb49MuCzl7E5MEZCIVJbRG/Oi?=
 =?us-ascii?Q?DjtaaWNsUsyMHddThsvp4qyT5dVLKXe+bMYezx5fgQj4ul5+Ja320cOQhAWt?=
 =?us-ascii?Q?bg=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: b46ee266-e87d-43b2-d2e6-08dbaa42068b
X-MS-Exchange-CrossTenant-AuthSource: CY5PR11MB6366.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Aug 2023 16:47:56.0652
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: aBkpV2WfJLtEBkqZkaDyOsIA7l77OHbACZfxob9/Tx8PYIgoXUeN13yDGMKf/XuqmU1FrV2lsK83s8rk63fW1TmtnPHATPB1qqkldZGlBGA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6237
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,
        RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

On Thu, Aug 31, 2023 at 04:42:44PM +0300, Andy Shevchenko wrote:
> On Wed, Aug 30, 2023 at 03:54:51PM +0800, Jinjie Ruan wrote:
> > Convert list_for_each() to list_for_each_entry() so that the list_itr
> > list_head pointer and list_entry() call are no longer needed, which
> > can reduce a few lines of code. No functional changed.
> 
> Seems correct to me, assumed that this has been tested,
Seems correct also to me. I also tried it and it works.

Acked-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>

Regards,

-- 
Giovanni