Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f06917ed-a0ba-30f1-4b65-57fe96bbf741@huawei.com>
Date:   Wed, 6 Sep 2023 15:49:30 +0800
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3] crypto: Fix hungtask for PADATA_RESET
Content-Language: en-US
To:     Steffen Klassert <steffen.klassert@secunet.com>,
        Herbert Xu <herbert@gondor.apana.org.au>
CC:     Daniel Jordan <daniel.m.jordan@oracle.com>,
        "David S . Miller" <davem@davemloft.net>,
        Guo Zihua <guozihua@huawei.com>, <linux-crypto@vger.kernel.org>
References: <20230904133341.2528440-1-lujialin4@huawei.com>
 <ZPb4ovJ+eatyPk1E@gauss3.secunet.de>
From:   Lu Jialin <lujialin4@huawei.com>
In-Reply-To: <ZPb4ovJ+eatyPk1E@gauss3.secunet.de>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Steffen,

padata_do_parallel is only called by pcrypt_aead_encrypt/decrypt, 
therefore, changing in padata_do_parallel and changing in 
pcrypt_aead_encrypt/decrypt have the same effect. Both should be ok.

Thanks.

Herbert, the two ways look both right. What is your suggestion?

On 2023/9/5 17:45, Steffen Klassert wrote:
> On Mon, Sep 04, 2023 at 01:33:41PM +0000, Lu Jialin wrote:
>> ---
>>   crypto/pcrypt.c | 4 ++++
>>   kernel/padata.c | 2 +-
>>   2 files changed, 5 insertions(+), 1 deletion(-)
>>
>> diff --git a/crypto/pcrypt.c b/crypto/pcrypt.c
>> index 8c1d0ca41213..d0d954fe9d54 100644
>> --- a/crypto/pcrypt.c
>> +++ b/crypto/pcrypt.c
>> @@ -117,6 +117,8 @@ static int pcrypt_aead_encrypt(struct aead_request *req)
>>   	err = padata_do_parallel(ictx->psenc, padata, &ctx->cb_cpu);
>>   	if (!err)
>>   		return -EINPROGRESS;
>> +	if (err == -EBUSY)
>> +		return -EAGAIN;
>>   
>>   	return err;
>>   }
>> @@ -164,6 +166,8 @@ static int pcrypt_aead_decrypt(struct aead_request *req)
>>   	err = padata_do_parallel(ictx->psdec, padata, &ctx->cb_cpu);
>>   	if (!err)
>>   		return -EINPROGRESS;
>> +	if (err == -EBUSY)
>> +		return -EAGAIN;
>>   
>>   	return err;
>>   }
>> diff --git a/kernel/padata.c b/kernel/padata.c
>> index 222d60195de6..81c8183f3176 100644
>> --- a/kernel/padata.c
>> +++ b/kernel/padata.c
>> @@ -202,7 +202,7 @@ int padata_do_parallel(struct padata_shell *ps,
>>   		*cb_cpu = cpu;
>>   	}
>>   
>> -	err =  -EBUSY;
>> +	err = -EBUSY;
> Why not just returning -EAGAIN here directly?
>
>