Received: by 2002:a05:7412:31a9:b0:e2:908c:2ebd with SMTP id et41csp2530686rdb; Tue, 12 Sep 2023 05:05:39 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFfiwr5BJx7OkZtXRsQpNsluaWw4M+omTdMwPHyRr2KmssrQDoiIZ2HMDMXTYt97uOcpfJ4 X-Received: by 2002:a17:90b:4a08:b0:273:ffc0:7a80 with SMTP id kk8-20020a17090b4a0800b00273ffc07a80mr5708470pjb.46.1694520339455; Tue, 12 Sep 2023 05:05:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694520339; cv=none; d=google.com; s=arc-20160816; b=W5toJxlXwEWuR+m/CcVe4vy14GPuIkaLGBfQ84yVTa25qHZ59loiLifAyAlg+TPgXj RXMCZtvi2gGHHqGTBeWdVtK19zogXRb57HlStBQco701tB8wre68uOLdhWeVcVwJkou1 uvZEnjPX+8mXPMtu/sygnBQRcDHH+KT3FWwEkrBj+SmTauA1FS6MPY8DaaNFjuzhYwpz Zmg4/8QlmMxvQsm64/TTLSPqkwITEI+wxg8lJXcJMizXGA+0ykL3Q4D4+Q8cuJSU1g5j glbK2opM/9329AuKjdLzKPehgdC+Gsj/UUNw/nun2vLDYsYfLZgvSji5hTyX0/uLaRGk 58Kg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=W6ZFSny7x5hTX7VHE3RAqqRXrh5zcFFP1oA9ZYe1TR0=; fh=yVLZgbntxjy7+yHs1zVoQ0oyJY2MapU3iVj0EL3tL6A=; b=zpzkNwLAovLIX5N0+pNE5Fh+9Vq3ZFbPWjK+ouiBAHtXn1H7pjtmbtVt2PgHMKw48M iSOsBGjGSN2LNKW4u6XDxZaRyX0ZcHBsW+w21ETKEcLkSAo2aldKhvyxbHASd9X4Uj6d C40Tpa7zPgR0KPAxm+FlD5qb98QTMgf3l/Jr8/ibuuTHfuw4VRhax8TuL5Qn8gtfK9C+ 8WklbZTLmH1iVmZFyJpqI//DTGSkrxK2WVSQtVux16Yi0cN5Jbw0et1o32obQ5fveId8 Di0D/dD9jzGT3Xgoka4pPKUlelP8gEYzXh59DCQEX1sMj83EXvs2eYhgsshXD+liaFF3 FYxw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@foss.st.com header.s=selector1 header.b=O6sEC3DW; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=foss.st.com Return-Path: Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id p3-20020a17090a2d8300b0026d4adee541si9777577pjd.150.2023.09.12.05.05.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Sep 2023 05:05:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=pass header.i=@foss.st.com header.s=selector1 header.b=O6sEC3DW; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=foss.st.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id C2F7A8171682; Tue, 12 Sep 2023 00:39:42 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231666AbjILHjk (ORCPT + 99 others); Tue, 12 Sep 2023 03:39:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41468 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229675AbjILHjj (ORCPT ); Tue, 12 Sep 2023 03:39:39 -0400 Received: from mx07-00178001.pphosted.com (mx07-00178001.pphosted.com [185.132.182.106]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EB2F2E7C; Tue, 12 Sep 2023 00:39:35 -0700 (PDT) Received: from pps.filterd (m0369458.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.17.1.22/8.17.1.22) with ESMTP id 38C3N8bC006265; Tue, 12 Sep 2023 09:39:15 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h= message-id:date:mime-version:subject:to:cc:references:from :in-reply-to:content-type:content-transfer-encoding; s= selector1; bh=W6ZFSny7x5hTX7VHE3RAqqRXrh5zcFFP1oA9ZYe1TR0=; b=O6 sEC3DWDxvkpK0fP1ZfbdNaRLyz8DljJOJRxQLP6ZnPjlk1F3sauZHJU4q5Nau8Oh pyPoKMerndpDvj4If+UI6pm5XzLqujorcuntOJvNCgQ7TgWxDFa4rmfDrBRNhvgY DHc1ad/Wgev9ePRbu/lF/7CNHM0pXZreVgsft2F8eicATDeTNEfuuu1bjWdxDvuo MhYyoNLjI0gDrO/5M0d0a2aKg4NPuePM0TjSKkMnUsl5AZSJF5AsOXwtYBTca5Ak 8CcDovAp5Dok02K27+Cg3Qak3+5NlHjZ0eACKoX9h0v52B6PpIc0bcn57Cdsr7Vh sb637vw6RgiuHv0MT3xw== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 3t2g1hryc7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 12 Sep 2023 09:39:15 +0200 (MEST) Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 6D0C0100058; Tue, 12 Sep 2023 09:39:14 +0200 (CEST) Received: from Webmail-eu.st.com (shfdag1node1.st.com [10.75.129.69]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 548FF21ED3A; Tue, 12 Sep 2023 09:39:14 +0200 (CEST) Received: from [10.201.20.32] (10.201.20.32) by SHFDAG1NODE1.st.com (10.75.129.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 12 Sep 2023 09:39:13 +0200 Message-ID: <3c138ce6-7766-87a7-1447-22f597863ab3@foss.st.com> Date: Tue, 12 Sep 2023 09:39:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: [PATCH 07/10] dt-bindings: rng: add st,rng-lock-conf Content-Language: en-US To: Rob Herring CC: Olivia Mackall , Herbert Xu , Krzysztof Kozlowski , Maxime Coquelin , Alexandre Torgue , Lionel Debieve , , , , , References: <20230908165120.730867-1-gatien.chevallier@foss.st.com> <20230908165120.730867-8-gatien.chevallier@foss.st.com> <20230911150958.GA1255978-robh@kernel.org> From: Gatien CHEVALLIER In-Reply-To: <20230911150958.GA1255978-robh@kernel.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.201.20.32] X-ClientProxiedBy: SHFCAS1NODE1.st.com (10.75.129.72) To SHFDAG1NODE1.st.com (10.75.129.69) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.957,Hydra:6.0.601,FMLib:17.11.176.26 definitions=2023-09-12_04,2023-09-05_01,2023-05-22_02 Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Tue, 12 Sep 2023 00:39:42 -0700 (PDT) X-Spam-Status: No, score=-2.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Hello Rob, On 9/11/23 17:09, Rob Herring wrote: > On Fri, Sep 08, 2023 at 06:51:17PM +0200, Gatien Chevallier wrote: >> If st,rng-lock-conf is set, the RNG configuration in RNG_CR, RNG_HTCR >> and RNG_NSCR will be locked. It is supported starting from the RNG >> version present in the STM32MP13 > > This should be squashed into the prior binding patch. > Ok, I will squash both for V3. >> >> Signed-off-by: Gatien Chevallier >> --- >> .../devicetree/bindings/rng/st,stm32-rng.yaml | 14 ++++++++++++++ >> 1 file changed, 14 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/rng/st,stm32-rng.yaml b/Documentation/devicetree/bindings/rng/st,stm32-rng.yaml >> index 59abdc85a9fb..0055f14a8e3f 100644 >> --- a/Documentation/devicetree/bindings/rng/st,stm32-rng.yaml >> +++ b/Documentation/devicetree/bindings/rng/st,stm32-rng.yaml >> @@ -37,6 +37,20 @@ required: >> - reg >> - clocks >> >> +allOf: >> + - if: >> + properties: >> + compatible: >> + contains: >> + enum: >> + - st,stm32mp13-rng >> + then: >> + properties: >> + st,rng-lock-conf: >> + type: boolean >> + description: If set, the RNG configuration in RNG_CR, RNG_HTCR and >> + RNG_NSCR will be locked. > > Define the property at the top-level and then restrict its presence in > a if/then schema. > Ok, will change in V3. Thanks for your input >> + >> additionalProperties: false > > Did you test this property is allowed? No, because additionalProperties > won't work with properties defined in if/then schemas. > >> >> examples: >> -- >> 2.25.1 >> Best regards, Gatien