Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Date:   Thu, 14 Sep 2023 11:24:05 +0100
From:   Giovanni Cabiddu <giovanni.cabiddu@intel.com>
To:     Justin Stitt <justinstitt@google.com>
CC:     Herbert Xu <herbert@gondor.apana.org.au>,
        "David S. Miller" <davem@davemloft.net>, <qat-linux@intel.com>,
        <linux-crypto@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-hardening@vger.kernel.org>
Subject: Re: [PATCH] crypto: qat - refactor deprecated strncpy
Message-ID: <ZQLfRbnGHXts515P@gcabiddu-mobl1.ger.corp.intel.com>
References: <20230913-strncpy-drivers-crypto-intel-qat-qat_common-qat_uclo-c-v1-1-88a6c07fc924@google.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230913-strncpy-drivers-crypto-intel-qat-qat_common-qat_uclo-c-v1-1-88a6c07fc924@google.com>
Organization: Intel Research and Development Ireland Ltd - Co. Reg. #308263 -
 Collinstown Industrial Park, Leixlip, County Kildare - Ireland
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?lptgnVtQcj+HDdF3fr5yXWf9cd0o7KqmREUzddCYlNu2/j/respImJiRThD/?=
 =?us-ascii?Q?WMqJdn5hfCw5T6/jsOCllJ2zcDOau40GNcDtdSCBOGuReG3KApjcFiY+BTN3?=
 =?us-ascii?Q?1xCyuBpgbhAn3AopHI21dfH9rMubC/wFOSHZuVPnICVpwpneRn3MPwPgT5Yd?=
 =?us-ascii?Q?K0oKKZoqO7Tu6oYT6biBej16oUUxmVsjzJ/iNtKT/JVF8VIiHNEZc5IzvD6b?=
 =?us-ascii?Q?zo50P70HGKFNlCuIrXumeCyzCPkho2UAsicaX4j8ne85NlE8E8vfOa8j8OYg?=
 =?us-ascii?Q?A49Y+RhXvmwuDfv6ofAuoH0ED679dwHkMb1roGdnSxHxoQSr+nDp2dMk0rFl?=
 =?us-ascii?Q?peDRQFDzWS7+ZdvVVBU/A5GSGE9PrmHctK8FwjoDOeBGjVb4tK5YycWAoglw?=
 =?us-ascii?Q?AeEs2Z18NeTMZUSi9oZM9FMi65p3RFyoO4+9H+ywWxPxgeMbLFXeSsvT/ka/?=
 =?us-ascii?Q?6dknaSR+XKN/VYs/hku8b+VsTJxo8BCuGziYfIxgwlfIuEbviz2HB0TXbhc2?=
 =?us-ascii?Q?f3Z0AtpQ+0Wdb5jpHg/gTqABUhD6sb4aOPBFboIjaNClx3SaH0l+azvqf1tH?=
 =?us-ascii?Q?nnceVWRnPTxbOHep3WLYhyIepzUnJrkVrX7sVQcSgvpNyW3NPY1qqYOSKPdT?=
 =?us-ascii?Q?J+4EfYywLMvTVN2679/aEeuMUqiuTmLBHqk/TRVQn7JVB8GNA3OVvKjPjOBC?=
 =?us-ascii?Q?QNUEtGcHjSu/BaFSTbOivyPnCyHyjuRKBi+49zXHgkaWEggAc21zmYCq5aUJ?=
 =?us-ascii?Q?eJlhF+VaVhy9/npDojit5W7V6Mi1TEFY/370uvaRdHizCwF1fYz4xCOLl/PR?=
 =?us-ascii?Q?mR4wBk4tfUcmix+ts25f6qG4YsCln6WgVDvPQIllZdISRvsIGgw/1cdp0wNK?=
 =?us-ascii?Q?PlJPvdld75mzbCiWlyh4BGDx4j2BHELc864M+ZXF33cblp3/FqfyiB0IjYwG?=
 =?us-ascii?Q?M9FU1YnL2tksqPWh/9ACffduguau5QXgDSZpX/D1tR8yhlAoRVgaWEsEfRxH?=
 =?us-ascii?Q?TrXInDOa4pel7rp5U3xJF3L9KSZiw8TVzSvWZwYo5//inhN9JZj8FJYFl/2t?=
 =?us-ascii?Q?Bke+RTqRPz0ysdzfq+NrWWRo1lUmjO4F1eUEpunozjZmnLCHpgXI4KS2Qim2?=
 =?us-ascii?Q?wSDmL1gjELGUXuJowkchW18Ha1Rtwfo8nEjfWHRCoGRh/VdhrrjlKj9Hgg1C?=
 =?us-ascii?Q?YXqBneLmWZJ9XH6W5Q0CHpJgUmey8b8YYDuCyuuioYRTwSNcWPs9gHzqa34t?=
 =?us-ascii?Q?McvdadP9+SbCN2g3rRJxvujygiriGTY96sQxaPIRiAAJswh7n+QDEQgWSApN?=
 =?us-ascii?Q?38HdBH/FKRFxc6AaGV80Fb401eFEb0KgE0lM6NICxJj//6WSgaB4zeGqwcfD?=
 =?us-ascii?Q?sNdKxyvNx2xZYdAAcgvkrv0jFgyMk+QmkaBYrY+OMWTYP+NnrnlEQ+YMLwcR?=
 =?us-ascii?Q?ylrTik4srfYHdUPcXgpLxx2A03dx2MpzVMZ1j2NP9f18jqIaHWte+w6D9JTO?=
 =?us-ascii?Q?LIOI2cA8yYJ3pB1XmJeGtZWSMs4MV0z6YJOPH3+kuvAvppeVKf4/b5IiJYJp?=
 =?us-ascii?Q?Bq4qIl4yn2IoILJ2mar4vRwS6hmInGpQcpb5+LWckw08f0e2UZFzvCH3e07R?=
 =?us-ascii?Q?zQ=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 813a5538-5d51-456c-8afd-08dbb50cbd7d
X-MS-Exchange-CrossTenant-AuthSource: CY5PR11MB6366.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Sep 2023 10:24:12.7889
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: cLC2km9DulB68olUcbygrkFYiFBFPOe7Nytezxtvk3gH2odfZsgh8WoX+efgx4MWxrDtnX8z8zeMMeaElSNGQHM0srU7M1DrvWNOaKzqJig=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB6903
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Thu, 14 Sep 2023 03:24:20 -0700 (PDT)
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email

On Wed, Sep 13, 2023 at 12:51:05AM +0000, Justin Stitt wrote:
> `strncpy` is deprecated for use on NUL-terminated destination strings [1].
> 
> We should prefer more robust and less ambiguous string interfaces.
> 
> `buf` is expected to be NUL-terminated for its eventual use in
> `kstrtoul()` and NUL-padding is not required.
> 
> Due to the above, a suitable replacement is `strscpy` [2] due to the
> fact that it guarantees NUL-termination on the destination buffer.
> 
> Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings [1]
> Link: https://manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.html [2]
> Link: https://github.com/KSPP/linux/issues/90
> Cc: linux-hardening@vger.kernel.org
> Signed-off-by: Justin Stitt <justinstitt@google.com>
Acked-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>

> ---
> Note: build-tested only.
Reviewed and tested on dh895xcc, the only device impacted by this
change. All good.

Thanks,

-- 
Giovanni