Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
Subject: RE: [PATCH 0/3] crypto: jitter - Offer compile-time options
Thread-Topic: [PATCH 0/3] crypto: jitter - Offer compile-time options
From:   "Ospan, Abylay" <aospan@amazon.com>
To:     =?iso-8859-1?Q?Stephan_M=FCller?= <smueller@chronox.de>,
        "herbert@gondor.apana.org.au" <herbert@gondor.apana.org.au>
CC:     "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>
Thread-Index: AQHZ7IHXOjhrYWJJlUG53kdcMUz5/7Arpuvg
Date:   Mon, 25 Sep 2023 15:11:11 +0000
Message-ID: <79fe855f99e44c97b6ac3348faac05d3@amazon.com>
References: <2700818.mvXUDI8C0e@positron.chronox.de>
In-Reply-To: <2700818.mvXUDI8C0e@positron.chronox.de>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Precedence: bulk

Hi Stephan,

We ran tests with your patches on our bare metal platform (AMD Epyc CPU) an=
d saw an improvement in boot time entropy after analyzing the collected jit=
ter deltas.
Patches looks good to me.
Thanks for your work!

Acked-by: Abylay Ospan <aospan@amazon.com>

-----Original Message-----
From: Stephan M=FCller <smueller@chronox.de>=20
Sent: Thursday, September 21, 2023 7:48 AM
To: herbert@gondor.apana.org.au
Cc: linux-crypto@vger.kernel.org; Ospan, Abylay <aospan@amazon.com>
Subject: [EXTERNAL] [PATCH 0/3] crypto: jitter - Offer compile-time options

CAUTION: This email originated from outside of the organization. Do not cli=
ck links or open attachments unless you can confirm the sender and know the=
 content is safe.


Hi,

the following patchset offers a set of compile-time options to accommodate =
different hardware with different entropy rates implied in their timers. Th=
is allows configuring the Jitter RNG in systems which exhibits insufficient=
 entropy with the default parameters. The default parameters defined by the=
 patches, however, are identical to the existing code and thus do not alter=
 the Jitter RNG behavior.

The first patch sets the state by allowing the configuration of different o=
versampling rates. The second patch allows the configuration of different m=
emory sizes and the third allows the configuration of differnet oversamplin=
g rates.

The update of the power up test with the first patch also addresses reports=
 that the Jitter RNG did not initialize due to it detected insufficient ent=
ropy.

Stephan Mueller (3):
  crypto: jitter - add RCT/APT support for different OSRs
  crypto: jitter - Allow configuration of memory size
  crypto: jitter - Allow configuration of oversampling rate

 crypto/Kconfig               |  60 +++++++++
 crypto/jitterentropy-kcapi.c |  17 ++-
 crypto/jitterentropy.c       | 249 ++++++++++++++++++-----------------
 crypto/jitterentropy.h       |   5 +-
 4 files changed, 207 insertions(+), 124 deletions(-)

--
2.42.0