Received: by 2002:a05:7412:2a8c:b0:e2:908c:2ebd with SMTP id u12csp2601635rdh; Wed, 27 Sep 2023 07:26:12 -0700 (PDT) X-Google-Smtp-Source: AGHT+IETtgLwyWElwWb4Bm4fpd0CykU8ko8mUJAf9FqggdDlqlqD3Z4qdKlQtcOVgmu+bGN4OXdz X-Received: by 2002:a25:da95:0:b0:d15:7402:f7cd with SMTP id n143-20020a25da95000000b00d157402f7cdmr2180567ybf.27.1695824772074; Wed, 27 Sep 2023 07:26:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695824772; cv=none; d=google.com; s=arc-20160816; b=eifZhr6w5cH4CNHF3EBfdCUWPmjXt2tF5S13Otgs9Mwh45eHvykZyWcUT2Q9IAXUaS F9wjZ4Fx75hPpGFbePStzCxFt9AzckRoiT31xp1zbJ35tuOMAzPTZEj4Gxw50A1p5hww NIFgm0U9ehh5Thvz9WG6nm225CQFSMJsURPRm7o3Dw9YFaZy3GgG1co/eQ+yboGy++Gl 7SKrXamHPFlHnOUGiuO75jKfuoejbeQKMiCsl9PHkC6QWBvsxSP5OjR3firljoLwvFwq sauFbn7OSKDrEXr2jvexW/WbQVUhf1ttQBbyHCp8FFAwm9iEb3P6ZaF5jeUJosmuaElJ MWDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date:dkim-signature; bh=GsIAyhpIf4NBRlkmaRy0sPks/FrsbwmkORMLxbn84u0=; fh=pI7nuAAknlogSOx3Vq/cg+NGI82U53Hw4zh0m9VMxiw=; b=HaMhdvk9fdEs+Jt9SF80UoSMvGqF/pnqwSXZJB5XyppC79qJ4nTXx1ZQgdRwfeSKaP N6V48L7wAvRbxHpakuNEvdomM9CVKSvewJFB/ujPXQZWeMW0/NUOXfneJRsMYgqZNLth B7yVgklKm6fzFpnC4GeUsXLnsOTDbwIM9ib9dQ2baDTICoH1YkTYxxBb1GlGHZDHxI7B 7WOpU85sWdAic3UtHLqrIbxClr4YWqMJ6nSdaC8aj4e8eChMfP+vHUmSpZLM85vdClqO cR3l0jogHiYBCIKad5BNrCf0gCYvGUz5q1O/GEHjXGzBWXv+2Fer1O17WlrdhrQYg/zi UEBw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=bvuKdv4J; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id r20-20020a6560d4000000b00573fef8a892si14685080pgv.484.2023.09.27.07.26.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Sep 2023 07:26:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=bvuKdv4J; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=NONE dis=NONE) header.from=ibm.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 04B9980A5FBC; Wed, 27 Sep 2023 06:26:11 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231825AbjI0N0J (ORCPT + 99 others); Wed, 27 Sep 2023 09:26:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54652 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231916AbjI0N0I (ORCPT ); Wed, 27 Sep 2023 09:26:08 -0400 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 48080139; Wed, 27 Sep 2023 06:26:07 -0700 (PDT) Received: from pps.filterd (m0353724.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 38RDH2Yu022849; Wed, 27 Sep 2023 13:25:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : in-reply-to : references : mime-version : content-type : content-transfer-encoding; s=pp1; bh=GsIAyhpIf4NBRlkmaRy0sPks/FrsbwmkORMLxbn84u0=; b=bvuKdv4JklxGKBk8YHkjwkerHUGgfvpcDmMTNXlh1xC+ZEW89+XWV/AskEjpRUnbB4Dy P/SoaIdd2EMcZ82g8QgmDaS0IUDnkuO9z6drfsRo768ViTxN9cEdGnJujLmo+ao2dkUl X1gD3LIwfdcj4pDj7T1VRc+4/UiJfGkTuLkDqqR3ThM586hv0Ej65IV7chSDfE6acsPE 5uzDopAYgc8lRqic6X8eOZMm5j/2BYw8q6VE3e7uk9W47hILDneYNlahpj4wIB6TGR8v jMUj4GNzJLcv9DQdY1yoX5n1CNfMuhqh5JWriNrMQK2rxdM+J+CNRMP+hwwpWwqAaYv7 Bg== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3tcmvdgqtt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 27 Sep 2023 13:25:39 +0000 Received: from m0353724.ppops.net (m0353724.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 38RDI1EC026637; Wed, 27 Sep 2023 13:25:39 GMT Received: from ppma12.dal12v.mail.ibm.com (dc.9e.1632.ip4.static.sl-reverse.com [50.22.158.220]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3tcmvdgqsr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 27 Sep 2023 13:25:39 +0000 Received: from pps.filterd (ppma12.dal12v.mail.ibm.com [127.0.0.1]) by ppma12.dal12v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 38RCeBKd008456; Wed, 27 Sep 2023 13:25:36 GMT Received: from smtprelay01.fra02v.mail.ibm.com ([9.218.2.227]) by ppma12.dal12v.mail.ibm.com (PPS) with ESMTPS id 3taabsv4q1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 27 Sep 2023 13:25:36 +0000 Received: from smtpav01.fra02v.mail.ibm.com (smtpav01.fra02v.mail.ibm.com [10.20.54.100]) by smtprelay01.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 38RDPYAG17433166 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 27 Sep 2023 13:25:34 GMT Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0508B2004B; Wed, 27 Sep 2023 13:25:34 +0000 (GMT) Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D11A820040; Wed, 27 Sep 2023 13:25:33 +0000 (GMT) Received: from li-ce58cfcc-320b-11b2-a85c-85e19b5285e0 (unknown [9.152.224.212]) by smtpav01.fra02v.mail.ibm.com (Postfix) with ESMTP; Wed, 27 Sep 2023 13:25:33 +0000 (GMT) Date: Wed, 27 Sep 2023 15:25:31 +0200 From: Halil Pasic To: "Gonglei (Arei)" Cc: "Michael S. Tsirkin" , Herbert Xu , "linux-crypto@vger.kernel.org" , Marc Hartmayer , Jason Wang , "virtualization@lists.linux-foundation.org" , "linux-kernel@vger.kernel.org" , "pizhenwei@bytedance.com" , Cornelia Huck , Halil Pasic Subject: Re: [PATCH] crypto: virtio-crypto: call finalize with bh disabled Message-ID: <20230927152531.061600f0.pasic@linux.ibm.com> In-Reply-To: <9564c220c8344939880bb805c5b3cac9@huawei.com> References: <1914739e2de14ed396e5674aa2d4766c@huawei.com> <20230926184158.4ca2c0c3.pasic@linux.ibm.com> <20230926130521-mutt-send-email-mst@kernel.org> <9564c220c8344939880bb805c5b3cac9@huawei.com> Organization: IBM X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: wmazh0HwbLN5HnkRF-bBsPH94u5eoxv7 X-Proofpoint-GUID: oZUuEdATvYo_-Yz_WpSoKhEgtnWF29Cp X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-09-27_07,2023-09-27_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 clxscore=1015 lowpriorityscore=0 malwarescore=0 suspectscore=0 bulkscore=0 mlxlogscore=732 spamscore=0 adultscore=0 impostorscore=0 mlxscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2309180000 definitions=main-2309270110 X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 27 Sep 2023 06:26:12 -0700 (PDT) On Wed, 27 Sep 2023 09:24:09 +0000 "Gonglei (Arei)" wrote: > > On a related note, config change callback is also handled incorrectly in this > > driver, it takes a mutex from interrupt context. > > Good catch. Will fix it. Thanks Gonglei! Sorry I first misunderstood this as a problem within the virtio-ccw driver, but it is actually about virtio-crypto. Thanks for fixing this! Regards, Halil