Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Date:   Fri, 29 Sep 2023 18:38:05 +0100
From:   Giovanni Cabiddu <giovanni.cabiddu@intel.com>
To:     Kees Cook <keescook@chromium.org>
CC:     Herbert Xu <herbert@gondor.apana.org.au>,
        "David S. Miller" <davem@davemloft.net>,
        Nathan Chancellor <nathan@kernel.org>,
        "Nick Desaulniers" <ndesaulniers@google.com>,
        Tom Rix <trix@redhat.com>,
        "Adam Guerin" <adam.guerin@intel.com>,
        Lucas Segarra Fernandez <lucas.segarra.fernandez@intel.com>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        <qat-linux@intel.com>, <linux-crypto@vger.kernel.org>,
        <llvm@lists.linux.dev>, <linux-kernel@vger.kernel.org>,
        <linux-hardening@vger.kernel.org>
Subject: Re: [PATCH] crypto: qat: Annotate struct adf_fw_counters with
 __counted_by
Message-ID: <ZRcLfYW0prCLXlJ4@gcabiddu-mobl1.ger.corp.intel.com>
References: <20230922175432.work.709-kees@kernel.org>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230922175432.work.709-kees@kernel.org>
Organization: Intel Research and Development Ireland Ltd - Co. Reg. #308263 -
 Collinstown Industrial Park, Leixlip, County Kildare - Ireland
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?tEjEKMN3fQSuH04PGRxEjTdnC2liT109wPAnqqxJXKYRKJf3IDl2br6kBgIW?=
 =?us-ascii?Q?RxUNIvDGorA89ibzHDusutby65Dc4oWlBEHS02cosz2vHJBnCelawOXBprLD?=
 =?us-ascii?Q?HKUKANa3AbrgqpLdhpX73IXeZiJRW5HteLPZM58z65x+8QjsurnwzBoMbxrt?=
 =?us-ascii?Q?+eR1JDjur6Ou101twpHd6AR0Ve0/r5cNdr2UMrOhzEsgFNqEgC5wYis2bXz7?=
 =?us-ascii?Q?l+GRnww2IW9g5lxdLNSILcLSoZUJoHxuAbwLp0BPQjul6Dsvu11f1MPjER9Q?=
 =?us-ascii?Q?vOHjfaAjSuGFQ1YLJsBvoVo47lcT7pFlemo50IjkVE3diU/ghXBMxDH7BRL/?=
 =?us-ascii?Q?nLSOw/zelP3jV6fMkS0AQl1qPHNfkrRwq4qJuH+EfW8Hxnad25+Z75jpxxLq?=
 =?us-ascii?Q?ike5eIwpRA1x6j8WzVRFS6fWsbEowk/EGIugajyAKLwCtnDu+YdOiAUTIGij?=
 =?us-ascii?Q?8GF08aZ7SmpcXF2b34kSEnzrcfo4rMyXLvUBWXcwzYnlKYNV9xdveu4ITptS?=
 =?us-ascii?Q?8Fr17r6Vo5AvrgNXEOFPNsLamaiBBuUXfL2JohrNt4nK6QNI6PaFemBbpXo8?=
 =?us-ascii?Q?Al8H1d27DZ7/sQ4Zn2BLKn1xTu3tb5i4pg+PsKaHot2UU7Q7WAvz5g1eAn4M?=
 =?us-ascii?Q?kMxGPQ9ihK8M6T2q6mBRmLG8INgd0XVOcy+rfAA3wU7lZwlcgHNMrR4jCtFS?=
 =?us-ascii?Q?5/doPevLbvqzPgVkQUzI1Fn6TC4nlI355/T4d+xRPeA3oiv9cOHKLfQbUwAL?=
 =?us-ascii?Q?KYrXTj9m/T5WAUtTnEOvN1iLJFq6VmFeZDU/4uYVhpXf6Mo07tK/hBs40g70?=
 =?us-ascii?Q?71AJ/51vag+9D8QG+jEmqu6pyB1wSDkxfS6pi2wYtvro+y3CNeh6JkjluoDT?=
 =?us-ascii?Q?MBKnwHUmzHR9/hPDWJXpEUPRfoKB8LK3E/uAxwQO4ZXjuKkUoJ+p/pMDI2Ge?=
 =?us-ascii?Q?Tqfw+eqe0HN607aFyUmAJkmE0mKWUcy/z5ihsczHtdKlEV9YZoSnI1+9lkrn?=
 =?us-ascii?Q?SohsgDHZcQ6rG9R3vh2ww2wf855uIb6V4I2JwujGNfsOSB47MUkAkZ99HguS?=
 =?us-ascii?Q?lquyXztDWwyti+1pwv+udQT8XA2wV8x5doipVdzmH131VucYXp3TAIEctZhP?=
 =?us-ascii?Q?psgKDdM2TUTHmueW2Fy6u7Q9/k9IX859B5sC4GqxFKThRxTE9R39AhxQrGDn?=
 =?us-ascii?Q?899m8YWTMQc3qjAW9lYvP+M/WZB2vx3VacAxYvk++LNc0dcLmJdYdJqtFZMX?=
 =?us-ascii?Q?vrHO4dGIZEidh3GPCMQwOwvM3M8OU2lmyO/N/N9w+1J/bnJ1qg8648cV/ICl?=
 =?us-ascii?Q?eZfGJdW6qQwyYiAHbaHo8dvVwisLxodyhtKsZyNDC5RZT6LviyRosNgCApQg?=
 =?us-ascii?Q?5z0vBG9q//etOKslJFrTv8PGMvkSBwrW0y2IA+vjqRn/ABpUJ6EO2O9vgCUW?=
 =?us-ascii?Q?fqn3QTeShftV5J3CmyaDhz+9jBQHP4iIXC4CL9Z2k880FHFpiKSYc4Y6PTU/?=
 =?us-ascii?Q?8s8hBjdCOtBFBl86FYQjQpnIDa6S4VlT0zZoIFVn1oWIqfi2Rm93zQgPG2hs?=
 =?us-ascii?Q?P3sVSo9ps7sLDxaA6mmA1DcFvp8u1WjS/kyI64n79xqsZtCQQqrmxdzbpfcm?=
 =?us-ascii?Q?OA=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: aa665a1c-4a0e-43fd-a841-08dbc112da17
X-MS-Exchange-CrossTenant-AuthSource: CY5PR11MB6366.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2023 17:38:11.7931
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: us9aKAuBbJRzXZdJJoaF1ufap40MZx8LU1HpkvKyyyzOKn6e+2MnU/pRRojsnkxilxJgLEAWuQCpt8lk/n9hhy7L/eXqkZ2ACZCmPampQwk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7824
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Fri, 29 Sep 2023 12:00:17 -0700 (PDT)

On Fri, Sep 22, 2023 at 10:54:33AM -0700, Kees Cook wrote:
> Prepare for the coming implementation by GCC and Clang of the __counted_by
> attribute. Flexible array members annotated with __counted_by can have
> their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS
> (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
> functions).
> 
> As found with Coccinelle[1], add __counted_by for struct adf_fw_counters.
> 
> [1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci
> 
> Cc: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Nathan Chancellor <nathan@kernel.org>
> Cc: Nick Desaulniers <ndesaulniers@google.com>
> Cc: Tom Rix <trix@redhat.com>
> Cc: Adam Guerin <adam.guerin@intel.com>
> Cc: Lucas Segarra Fernandez <lucas.segarra.fernandez@intel.com>
> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Cc: qat-linux@intel.com
> Cc: linux-crypto@vger.kernel.org
> Cc: llvm@lists.linux.dev
> Signed-off-by: Kees Cook <keescook@chromium.org>
Acked-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>