Received: by 2002:a05:7412:3784:b0:e2:908c:2ebd with SMTP id jk4csp704255rdb; Sun, 1 Oct 2023 01:34:29 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEEF4E13e3b7wif2H4pscvWrHFUNZLEvlAQjMcXDw3+9n8ERgjE1LOyVx0ZEs9+FKWv4x+8 X-Received: by 2002:a05:6870:648e:b0:1dd:443c:57a8 with SMTP id cz14-20020a056870648e00b001dd443c57a8mr11357922oab.26.1696149268793; Sun, 01 Oct 2023 01:34:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696149268; cv=none; d=google.com; s=arc-20160816; b=dxJ866+k5ma7J/7Ut2eN+mVt4BwGvOjt7MxsJBc38GjH2UU0mIZeefPac6VSpDwrlG BBH99TIEch3YLulhtcS5UoMcZrbIPRtwNVcVXDKZuAsq9VZ0r27/D/9MYvV2xeuo/B2R UB+KfYWDTcRehIUEngMNQy1X48Gl80+fkn5RJectuI4Q9VuvXNUk4Ph3qIcCzpKj+rUB snU5YZ0RklC/smnKlLic+kQE/M4A1yiHb0UltdV8+ZBKH9NsQJyCvyqQefW5m/eIQFmS VphMZguy3q/iTa9jhh40NIyfjhIJX0h2O+KQUj5jE/zJ4Hdu8U3FQLjU8ib1lEKSch5V bqhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=/N1+lk7xsOdsbSgYUhtqnRySO9e+rOU/X7QnTeJjs74=; fh=qkn3q9i0RoUUu62t+IQVaPGXHg6RyhRlrhrxiajbc2k=; b=uKgLVoVbXb3SfCRy5aTh3UKvTY0KxgeoxXUJYWzuGabLbSg7b24nWW9rIOuAsXTaQH pai9W1yimVTvPBkoI6jkoCL6p/TGSMR4hzaLG4WOI+kGJH39efrdSOh9DwNSjehxCTI5 WypmFgMtSX16CRTrk2GlGhS0VKtU05cxngsF/cdx7PECsWiCo86yc0CaPcN0psy48w4N nqWh7akNAgpizLYk4vSUoLkfHrUEaNBDmMM5sV3RMHDovVYWUgPBNKADhZ1qTouxX8tx kNdUx8i5EmHVFajXdFa3jmVCOFMrH1QFQJPKraPlz0LnVN9BfsU0KKkfcHUSOEoXjxMV +cWg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from howler.vger.email (howler.vger.email. [2620:137:e000::3:4]) by mx.google.com with ESMTPS id c128-20020a633586000000b00578f7063adasi13431654pga.33.2023.10.01.01.34.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 01 Oct 2023 01:34:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id B1CF78245A56; Sun, 1 Oct 2023 01:34:27 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234617AbjJAIeV (ORCPT + 99 others); Sun, 1 Oct 2023 04:34:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40960 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234625AbjJAIeT (ORCPT ); Sun, 1 Oct 2023 04:34:19 -0400 Received: from abb.hmeau.com (abb.hmeau.com [144.6.53.87]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BC5D9DF; Sun, 1 Oct 2023 01:34:16 -0700 (PDT) Received: from loth.rohan.me.apana.org.au ([192.168.167.2]) by formenos.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1qmrtz-002PX9-Nh; Sun, 01 Oct 2023 16:34:12 +0800 Received: by loth.rohan.me.apana.org.au (sSMTP sendmail emulation); Sun, 01 Oct 2023 16:34:15 +0800 Date: Sun, 1 Oct 2023 16:34:15 +0800 From: Herbert Xu To: Gaurav Jain Cc: Horia Geanta , Pankaj Gupta , Varun Sethi , Meenakshi Aggarwal , "David S . Miller" , Aisheng Dong , Silvano Di Ninno , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-imx@nxp.com Subject: Re: [PATCH] crypto: caam/jr - fix Chacha20 + Poly1305 self test failure Message-ID: References: <20230921124237.2364827-1-gaurav.jain@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230921124237.2364827-1-gaurav.jain@nxp.com> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Sun, 01 Oct 2023 01:34:27 -0700 (PDT) On Thu, Sep 21, 2023 at 06:12:37PM +0530, Gaurav Jain wrote: > key buffer is not copied in chachapoly_setkey function, > results in wrong output for encryption/decryption operation. > > fix this by memcpy the key in caam_ctx key arrary > > Fixes: d6bbd4eea243 ("crypto: caam/jr - add support for Chacha20 + Poly1305") > Signed-off-by: Gaurav Jain > --- > drivers/crypto/caam/caamalg.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt