Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Date:   Mon, 2 Oct 2023 12:13:46 +0200
From:   Lucas Segarra <lucas.segarra.fernandez@intel.com>
To:     Herbert Xu <herbert@gondor.apana.org.au>
CC:     <linux-crypto@vger.kernel.org>, <qat-linux@intel.com>,
        <giovanni.cabiddu@intel.com>
Subject: Re: [PATCH v5 2/2] crypto: qat - add pm_status debugfs file
Message-ID: <ZRqX2iKbGC8Jqkp3@lucas-Virtual-Machine>
References: <20230922101541.19408-1-lucas.segarra.fernandez@intel.com>
 <20230922101541.19408-3-lucas.segarra.fernandez@intel.com>
 <ZRkrasH0zjj2m+GQ@gondor.apana.org.au>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <ZRkrasH0zjj2m+GQ@gondor.apana.org.au>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?sDVZdX9kpum2GPRgXj+E4WkZzwF8vzjTE/J2a7Uf0c4UXLZtUtExx4yqeKbo?=
 =?us-ascii?Q?hzJNR87BM2itg+jZlAfnLXdWyEbd3U0nQIXZmLOFhTretUpuTkZF/Kd5jJu8?=
 =?us-ascii?Q?xUejURKogY+meXjHMifyzeVCZURG+HDFhEWHXsZ8ENaquyIs1n9qVF8KD1qw?=
 =?us-ascii?Q?iOpej7XhwG9Ey8suuOTw4TEkR+n0q984klEGiQJ9unrnxjbTuSXzGYyIkPgY?=
 =?us-ascii?Q?FJQkfpPayHaTwOYI3JbpaSwLZkq5p8OVDahEvEu98FwKsd5uyp6RZ7VcwLJu?=
 =?us-ascii?Q?gzbsU1fXK+5qkPnsxNg/hVjC+Y82WAucPxMZWsEC0wrCIzO62kpPuvbrkAbL?=
 =?us-ascii?Q?CPZhIEHz4yDZwxB06Oq/VeYm/SjTYXHyAGByeVz3o0B5OnARFxNKrEI0ihxy?=
 =?us-ascii?Q?iKs079kaMg826+co3Q9MVUa+fM977wOfT5vGulNSXhLkRA+eQ2J0KF3DLqdI?=
 =?us-ascii?Q?L+TqkD9aiNhA++fXItf/+/kBbGp7UevtFsd7gpq6+w48Tjqah+J3otH9B9wn?=
 =?us-ascii?Q?hcfR9Cfi/NQuMzR9yo6CY/GJzuk18ejDMJf8nMFEz52XL8rFwOZMIsBf+prA?=
 =?us-ascii?Q?o7b6/SP8J73b0exqF55rbUahoOdfTVBQDkMLT7BXGEB3/ZF22RDBFr5lv3jd?=
 =?us-ascii?Q?tr5VYhQo4FNhuniUJ8jOZFbV0WbGfS5YdzEhZc6Q1wl3gjX+ZdE618yvdfbM?=
 =?us-ascii?Q?KPOOUcMc6vb6S8gNXabuOM6VnXZHU/dImeKy5P4AaX2Wuoe4A1fyAug0dD3c?=
 =?us-ascii?Q?+p7GdaSH9zSYG0edggXzMquAs6T7pILkMysL/Q2lYDlsgRjBTLQZBH1F2PPO?=
 =?us-ascii?Q?S1s3tz5nDE3Hr4PsSg/jRyU/I9Vpr6j/ST5knMKIOCMSxlP0ZfziqRP2ejFw?=
 =?us-ascii?Q?FlhLVTt8VuSRvRac5Mg6wKxbOR4U4NEb7Zo7q9wbpR7frrWx0UTYGv/smUxe?=
 =?us-ascii?Q?2wgTQPzVszWOUfOZEz3IxkkD09ssZH3IDDgqsXknqwH9YuEu1bpaaS6rYc+5?=
 =?us-ascii?Q?t7lKgjCM3AqGMXdmzSLbKMf9XsQcG/HI87e8Exi6UlqGgDniKxWerpyM9b+U?=
 =?us-ascii?Q?83SY2xFpahlJmUM0CqatyPebcBSrBVN38GP4Rfr1pPx/cN8lGg2F/AYe67Dl?=
 =?us-ascii?Q?my/4KnnxOcM8FULzUgMhZ6I7jiNzlu/Ri4Uc8BCZuznrijwFsOO3095yCIWI?=
 =?us-ascii?Q?XMwnDUEaVuCL6Tx59UXwuGKlDoKfbWvKEjc1JkY4xZUhujHI8oSopUsw1TW0?=
 =?us-ascii?Q?2ReSj8tdw0TogDlLYjwAR7Y1bJpMmclb5II9u/GyC+6TMNaYAvSJfIBELjj1?=
 =?us-ascii?Q?WGtyy0G32qCYWdEaKXf8Kbqo1tCyXgXc3xZbwgB1+6kLSajpuvgO+VPFPE7r?=
 =?us-ascii?Q?sUiXUPzvau/IqKDpX+lHEE11csdKk+27iM1fnd+gYyH4CChCNgYFT33XkQy5?=
 =?us-ascii?Q?vl06g4cD0fDABnSl4VTahH6ImLfkNr0MFVwPj+b5lyTE0PwZK3yxU3mnrvH7?=
 =?us-ascii?Q?UoiMJ+3+pHYae/P8536KSYlyM0Ck1bimbkFiJJPI2iw+Pt/yjhvCZnS496Tn?=
 =?us-ascii?Q?gcUqakKzusRFToR9Te73v4KGhn+FW0g/4jcsuFae0TCsDPflY+ON8ExesgeO?=
 =?us-ascii?Q?A6vliYf5p7P4s8q0+vRfl/4=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 20829742-d0f1-4e66-1bfa-08dbc3304bfd
X-MS-Exchange-CrossTenant-AuthSource: MW5PR11MB5812.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Oct 2023 10:14:00.4852
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0/VllAK2RDdRln25Q1Sm72AqjhfdkZOBsw2c/LPNt9zPjTPgsUTwc+76rn0Zmj3PTt6h+uZIk/n66FcYXIW3TXCoHnHgOrwNPmFFFmhX9cBFcfXUEZG1kpCiM0/ZWl5D
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB6736
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Mon, 02 Oct 2023 03:14:37 -0700 (PDT)

On Sun, Oct 01, 2023 at 04:18:50PM +0800, Herbert Xu wrote:
> On Fri, Sep 22, 2023 at 12:15:27PM +0200, Lucas Segarra Fernandez wrote:
> >
> > diff --git a/drivers/crypto/intel/qat/qat_common/adf_gen4_pm_debugfs.c b/drivers/crypto/intel/qat/qat_common/adf_gen4_pm_debugfs.c
> > new file mode 100644
> > index 000000000000..55db62a46497
> > --- /dev/null
> > +++ b/drivers/crypto/intel/qat/qat_common/adf_gen4_pm_debugfs.c
> > @@ -0,0 +1,255 @@
> > +// SPDX-License-Identifier: GPL-2.0-only
> > +/* Copyright(c) 2023 Intel Corporation */
> > +#include <linux/bits.h>
> > +#include <linux/dma-mapping.h>
> > +#include <linux/slab.h>
> > +#include <linux/stddef.h>
> > +#include <linux/string_helpers.h>
> > +#include <linux/stringify.h>
> > +#include <linux/types.h>
> 
> The kernel.h comment applies to this patch too.
> 
> Thanks,

Will be resubmitted including kernel.h in this file.

For the last 2 submitted versions of this patchset we've tried to apply the Rule
of Thumb mentioned in [1], understood as: Include kernel.h in every .C file that
includes __3 or more__ headers directly included by kernel.h, otherwise include
the directly used headers.

It seems this understanding is not correct. Could you help to understand which
is the Good Practice in this regard?
Should kernel.h be included in __every__ new C file a patch adds?

Thank you!

[1] https://lore.kernel.org/lkml/ZPAPSOnSTMgYrlV%2F@gondor.apana.org.au/