Received: by 2002:a05:7412:3784:b0:e2:908c:2ebd with SMTP id jk4csp1715260rdb; Mon, 2 Oct 2023 20:44:16 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHfzhJSSKEfZDLHGufUME/PkshYXJfxUyt8CQ1E5rk3DmX0v/fzDPj2Q6u4GOcSmf9nj33F X-Received: by 2002:a17:90b:1e0b:b0:267:faba:705 with SMTP id pg11-20020a17090b1e0b00b00267faba0705mr10492200pjb.10.1696304655803; Mon, 02 Oct 2023 20:44:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696304655; cv=none; d=google.com; s=arc-20160816; b=N/23WOaGYE/NMP3E+00UPd5P2VIEnBE6Hn9Oqvni6W1OZawS6wCPJZp4nDHkOgsPyd DYLOPUWnQbS14hvh9mTd0O/LjZXXtUrhDD5ewWTZgOFR4wgJF1A7QMlWApRnovaM6UQ0 kTfpVUh4J861CSBs9lbcLnfj5NZwvo2SeapBD96g6UvfftcayFM34dX5q3FVAe94F21u QlHQyqARopHo23faVbKYLwz2g3fmLZgZa6EvBuZTnrpJb+XVCk1+aG3ng5tExZ5o1dl8 zm8/Cbb4OfCgT2ukZMoO4i1h7r0vGijKobCkrq63CH0No4PzaE+NtWXS9JfC92GlcdvC OeWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=R1ya6/IrLG8EVXJxK6tPsuTaq1sKxuy0s3XD1ALS6jU=; fh=l82EBe4859Giv8r8zr9oFIexxRwnYkkBFWiaDDuu954=; b=CDMT3Mb/M9oozDtfhlccuG7fCqCqaYM2biyZrVBgbZSg4v2QEKMbCb186ryLiKWbzy 7ukiGVJMwIIQue2PKoLZ5Rv93GZCRib28VlyQBWuKI3yqupskrpi2wJDqsgHk8ug11Cs 5h5RUZ5iE6s5zGZhVdzfBcPLDFyB0StOzMDFT/Y2QGHoZ0sa1bwBWYJ0vaPHhYzT0qwS lWWMPMx4CosKHxHPaX0C2F0Vx4a4Gt9p7tQxPiHQF56v5YYB3MapQ8txSzpUByAiIaMc IGDlid1465ChvjXgaIk9G4ME/yP8AM+frD3UgzvTueAf785JPp7Rv85JXGHsaCONsmQX TogA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from pete.vger.email (pete.vger.email. [2620:137:e000::3:6]) by mx.google.com with ESMTPS id np13-20020a17090b4c4d00b0026b4d5844ccsi531917pjb.27.2023.10.02.20.44.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Oct 2023 20:44:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id EBD4A801BCB3; Mon, 2 Oct 2023 20:44:12 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229738AbjJCDoD (ORCPT + 99 others); Mon, 2 Oct 2023 23:44:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46764 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229437AbjJCDoC (ORCPT ); Mon, 2 Oct 2023 23:44:02 -0400 Received: from abb.hmeau.com (abb.hmeau.com [144.6.53.87]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 88431B7 for ; Mon, 2 Oct 2023 20:43:59 -0700 (PDT) Received: from loth.rohan.me.apana.org.au ([192.168.167.2]) by formenos.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1qnWKA-002wPe-MW; Tue, 03 Oct 2023 11:43:55 +0800 Received: by loth.rohan.me.apana.org.au (sSMTP sendmail emulation); Tue, 03 Oct 2023 11:43:58 +0800 From: Herbert Xu To: Linux Crypto Mailing List Cc: Shinichiro Kawasaki , Herbert Xu Subject: [PATCH 0/16] crypto: Only use common fields on skcipher spawn algs Date: Tue, 3 Oct 2023 11:43:17 +0800 Message-Id: <20231003034333.1441826-1-herbert@gondor.apana.org.au> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Mon, 02 Oct 2023 20:44:13 -0700 (PDT) The lskcipher conversion broke essiv. The superficial reason is that it was missed during the lskcipher addition as it does something similar to cryptd by being capable of both creating skciphers as well as aead algorithms. However, this also revealed that users of skcipher spawns were dereferencing fields that may be specific to skcipher_alg. This is invalid as the underlying algorithm may be an lskcipher_alg. Only fields in skcipher_alg_common may be used. This series adds the necessary helper for this and converts all users of skcipher spawns to use the new helper. The first patch is a left-over from the previous series and simply converts arc4 to an lskcipher. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt