Received: by 2002:a05:7412:3784:b0:e2:908c:2ebd with SMTP id jk4csp1760517rdb; Mon, 2 Oct 2023 23:08:21 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFIls6S1GAQMtrrDtrWMdm4Np1cy0yjHVgs2/3ORB/lSJCNVsM5N/zB9WqmjT/BLo8XtgHW X-Received: by 2002:a05:6808:1302:b0:3af:8ed3:d7a3 with SMTP id y2-20020a056808130200b003af8ed3d7a3mr6094631oiv.54.1696313301614; Mon, 02 Oct 2023 23:08:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696313301; cv=none; d=google.com; s=arc-20160816; b=HwdMHuq0EnVxckWRlI5F/PqEoOoZyexM2VhmtfSwXtt8mP0T6RnNHXgAPaIRXQ503L xyfPQ7XjxOghOXPPATvB20SK18gLJ+70BM1N/Fsw9qG17IiBME2O8iU+IwyT65/bRj49 MYydJVfTIiZ0TN5gwGSQD0nfSJ1fAyliYUssj6cniA0Cw0MvuNJHkXGNvfZK6hGnn/Qw wh0w451HsZJCJyqZhS7rzXiptoppTUTus5B6t48qagzzV4nc1kPrSBfd+nfA2ASDH4u5 1jChf0Oqx1lK8exHuTpuEMx6xs91esAaB9ZpKToP8k+vbPszOJtOvLdeXkl9JBkxiEF4 4/uw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:dkim-signature; bh=8nHXIz83JEIbMHbNl4Btub6SQ0/ni/ZIwsC2FHxJX6Q=; fh=FbKw/R/WV/+ZCfFdcOBvP0rKJRpc3ljppTO4koUVcIU=; b=Pq2hBNlJnJdl1ZVybAC/7PMrC8vrpVs6cH/y7mGFCX+YrbsOY//qi3L5GYskygRVAx IBvWUqfQWGVyIjNY2x9uqZk0MFSgTQdInmUD2wkZYrfYsfIHFQxuSKAEaxMIVOiZSfDO A8fMneG/oiNZUA+yR2VW/8PGXiabaDlOkrMpcfj8lozm0deKa/wW3wFjxuYiJof/cBc/ seqntGipOA8NtmFLmGvdV+TIYeRWw/tHdpJ31EfCGx8ENnjuCTkh+Bsit5HqZudig71J IGv76IOSaGgtlNYAOK95hS1NPnznBN2Cb3vwUjggKp2quZCmur3Xu/15zUiCiH0Dir3x ckRQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=KPmkj9WC; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from howler.vger.email (howler.vger.email. [2620:137:e000::3:4]) by mx.google.com with ESMTPS id ch20-20020a17090af41400b00276f10d241fsi9178005pjb.37.2023.10.02.23.08.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Oct 2023 23:08:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=KPmkj9WC; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 71E6982265EB; Mon, 2 Oct 2023 23:08:20 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230213AbjJCGIK (ORCPT + 99 others); Tue, 3 Oct 2023 02:08:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36632 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229547AbjJCGIK (ORCPT ); Tue, 3 Oct 2023 02:08:10 -0400 Received: from lelv0142.ext.ti.com (lelv0142.ext.ti.com [198.47.23.249]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 520ABB7; Mon, 2 Oct 2023 23:08:07 -0700 (PDT) Received: from lelv0265.itg.ti.com ([10.180.67.224]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id 39367fQY111012; Tue, 3 Oct 2023 01:07:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1696313261; bh=8nHXIz83JEIbMHbNl4Btub6SQ0/ni/ZIwsC2FHxJX6Q=; h=From:To:CC:Subject:In-Reply-To:References:Date; b=KPmkj9WCNcya62CDRzjUVxY4xqNJavEtHWYOmAYryzGsYCRtBEcaIsgec20Th59y8 29iId9xbdoEKqS7a0WxpijUilcfV/NLexAYsizKm+gzspJjKwqcyI66sRpWY9W5W9Z QnQtI30rjGiL6z+9O/FAkIJt1Y/Iy+4cr/WlynKI= Received: from DFLE111.ent.ti.com (dfle111.ent.ti.com [10.64.6.32]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 39367fmU010004 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 3 Oct 2023 01:07:41 -0500 Received: from DFLE100.ent.ti.com (10.64.6.21) by DFLE111.ent.ti.com (10.64.6.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Tue, 3 Oct 2023 01:07:41 -0500 Received: from fllv0040.itg.ti.com (10.64.41.20) by DFLE100.ent.ti.com (10.64.6.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Tue, 3 Oct 2023 01:07:41 -0500 Received: from localhost (ileaxei01-snat.itg.ti.com [10.180.69.5]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 39367epB042204; Tue, 3 Oct 2023 01:07:41 -0500 From: Kamlesh Gurudasani To: Eric Biggers CC: Herbert Xu , "David S. Miller" , Rob Herring , "Krzysztof Kozlowski" , Conor Dooley , Nishanth Menon , Vignesh Raghavendra , Tero Kristo , Catalin Marinas , Will Deacon , Maxime Coquelin , Alexandre Torgue , , , , , Subject: Re: [EXTERNAL] Re: [EXTERNAL] Re: [PATCH v2 0/6] Add support for Texas Instruments MCRC64 engine In-Reply-To: <87a5thgwt6.fsf@kamlesh.i-did-not-set--mail-host-address--so-tickle-me> References: <20230719-mcrc-upstream-v2-0-4152b987e4c2@ti.com> <20230812030116.GF971@sol.localdomain> <87h6owen39.fsf@kamlesh.i-did-not-set--mail-host-address--so-tickle-me> <20230822051710.GC1661@sol.localdomain> <87zg28d9z4.fsf@kamlesh.i-did-not-set--mail-host-address--so-tickle-me> <87a5thgwt6.fsf@kamlesh.i-did-not-set--mail-host-address--so-tickle-me> Date: Tue, 3 Oct 2023 11:37:40 +0530 Message-ID: <87wmw4fdcj.fsf@kamlesh.i-did-not-set--mail-host-address--so-tickle-me> MIME-Version: 1.0 Content-Type: text/plain X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Mon, 02 Oct 2023 23:08:20 -0700 (PDT) Kamlesh Gurudasani writes: >> >> Here, if we consider similar numbers for crc64 PMULL implementation as >> crc32 (case 2) , we save good number of cpu cycles using mcrc64 >> in case of files bigger than 5-10mb as most of the time is being spent in HW offload. >> >> Regards, >> Kamlesh > > Hi Eric, > > Please let me know if above numbers make sense to you and I should send > next revision. Hi Eric, I understand that there is no in-kernel user for crc64-iso3309 and this is new algorithm that we are trying to add in linux kernel. As per your suggestion we did the calculations and it turns out to be we are saving good number of cpu cycles with HW offload. Also, there are some automotive customers who have a safety requirement to offload any parameters that are in Linux to ensure FFI. Let me know if you are willing to accept this driver, so that I can put efforts to send next revision. Regards, Kamlesh