Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
From:   Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>
To:     Herbert Xu <herbert@gondor.apana.org.au>
CC:     Linux Crypto Mailing List <linux-crypto@vger.kernel.org>
Subject: Re: [PATCH 0/16] crypto: Only use common fields on skcipher spawn
 algs
Thread-Topic: [PATCH 0/16] crypto: Only use common fields on skcipher spawn
 algs
Thread-Index: AQHZ9avixrtf2pVW+0uG+quSLWPQT7A38TUA
Date:   Tue, 3 Oct 2023 11:39:55 +0000
Message-ID: <kjccevu7lyl6xwkz4lbgmzc72fxzbv5fpv74746hlncgptma5b@qkm3nxrx3wfb>
References: <20231003034333.1441826-1-herbert@gondor.apana.org.au>
In-Reply-To: <20231003034333.1441826-1-herbert@gondor.apana.org.au>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?S9ER+MHvwLTfDEn51pn/JGWiyM37IdHNRtUgKhOeS93YDvAJ1DetSfwYEu+9?=
 =?us-ascii?Q?AnOpRu18jtEwxVMHYTGMpA5H8wz50Co3BA4ny8EhFLbCSk/FH6OLqyaZUPw8?=
 =?us-ascii?Q?xmBhoMXWypqyJSDqZqC5A91gwQuHXDbq1V/G+NaeJvJgTs6Qy3Sz00u4InKP?=
 =?us-ascii?Q?p5TlLIC550A/0UyE6LEKUcpqMLCPRkH+f3tNFENcKmKK4IuJFOooTqcmRj8F?=
 =?us-ascii?Q?IwtuYuFTSwLvQUnKnVzArgnzYQ+Fa18GJUkb4HDE3x5fSN35NTy8n5+8vh7t?=
 =?us-ascii?Q?hb7ZfeyrGy60oak/SauUE6tHd1m0ap8YpElaotEcm2okf5dFvv4g7GhKO28k?=
 =?us-ascii?Q?htNY2Sb5BugbPQIGLOrTCxjj9Y0eN60JO3J0PdQ88b6u8xgb34lkgM9EdOTZ?=
 =?us-ascii?Q?YMAPv8urjBdKer50R0f5CfygCatb9Q00fJ95KBmeaCT80kylZh0O0qmRfWZH?=
 =?us-ascii?Q?laUWyb1wttv07ojOHHw6Zu4gaOFLI6Qh71JmAK6YSXl+m1j09xSu5ulRt035?=
 =?us-ascii?Q?szZwEFIYlHS0r60AQi73+UsedtPhitLRkCcv0v5gLbkOL+i61lCW2vtq1++z?=
 =?us-ascii?Q?wjYZl4dsmeXmsDIcSAhzRmnIxjum+tA8vZwTf+yiSoPzkV9g6qtY1JFT9+uQ?=
 =?us-ascii?Q?Ha5FsyUVtByXZotwb2OpCuLYPmW2tTHenDvNQ7xT1VXrI7TTKATqtFBrmWsk?=
 =?us-ascii?Q?KyLtFeXTUQNCMuswrPU/QZDjOySS0j5dg+77G4xoRuYiaUrTmaA1VpRnDiIh?=
 =?us-ascii?Q?0JwlwpJe+08ztt7vMzIf4ZQj6zLfisZ4bWw3PEXcMFaJyIdV05EiI+zW5jzq?=
 =?us-ascii?Q?xnTcoec3IqlGEgfWoLeznTUMAYQG70cqTkJewJoF4ls8UV/ISMklUnL0TAcf?=
 =?us-ascii?Q?IaPnQi0utqMWDIYhZB5PNvkoj5apwAVg8Gg4iaG6SRJTAwdOYSsZLTDGXDuv?=
 =?us-ascii?Q?bKbaNQdx7E5Cqv+2G4yFeg6DbTv21vy+2qYFcBIQgrFb/x8Pxh3nZmA0DGh4?=
 =?us-ascii?Q?ebgLaKkwEvfXWTeYM9LVz+e7rf4IlL9nGhpdoCRbUMQcMhWNlQJzz0K+rPmd?=
 =?us-ascii?Q?iEQClGGc+irdJGcMcPQ53v0AqZlff0Xh06zqZkbIrSHRs4RELkfwZpVU5cx+?=
 =?us-ascii?Q?aVQns4zDC9fnyRHyBQnzeCnM2QhHShN+w58/YHzjxpxc793w2JVm2d/5IMbG?=
 =?us-ascii?Q?n/OYgu+xwDTYBKIFi1kUSWo4NBHKGj/P1j22Qw4XCSsPcoOLdDImVxlJjq3m?=
 =?us-ascii?Q?YvZTzMAbYm3kNoJeZ2+TZ5Z0kA/5Ce5V8WJTURfwa6o5Eo8udbq9/osZfYRN?=
 =?us-ascii?Q?5IZUMFs3kZzt99YXL8M/hoTlw/FXp59wOaAEaFqCSqB2djdUtF5wHe2y9IIp?=
 =?us-ascii?Q?l32IXehzW8DKU7JNpBVF/zvHIzQjTBOLW9IozEo01RHMz1x5kOlSYdLX3WCO?=
 =?us-ascii?Q?auAI6Ypqad1E/YAKQ4nXHzU+7QA9HOuDDWhzO2rw9TSdrmV4YrSoyVCS91b9?=
 =?us-ascii?Q?QdLH1AiB+ZJB+081omcJm4DclAUZtDVgbJSBTzMypLbHAAtjST0UMuNn1wrE?=
 =?us-ascii?Q?0XUn9cShevWiEWROr/LYQLPPUHNVwJJ47zo+j6koLHhCqu+qw/UoihgFWhtp?=
 =?us-ascii?Q?2UO8RiEg1X5tSSCLV0NE5PE=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <C4448852A10B774885BB106B3E34DFF1@namprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: eKLUIodZT1hAvQfgvSz+pj/dooiDqoTC1wY8beujKWbydtDIMBBU2hczZcZ0QfZDtV8KwmHGWwvoudOL3oQ3hJnF83P948mIvacvQePC/yBwfoBs3B794o4b38jg0c9P403NAiwNisHc4BMD3g41h9mo4s1BVd8n3Uoxya2EWTmSu90r/lnaOWNeVNKSj981lPgibDb9Wwl06uQEjbYXXOe2F4EAidP4N5g7lY2eiButRsc/EasW7txJY/3vNjggzz+9VXkBOAiFzeV2ueT2NvzHchcV6juPpSE0TUxKoQdKC+hiNx5DSvRBHBrVdlzFwRHofInb6CneArDrDTzG1NXtJnzkXIijkkzb3Mm9uv7A2r2jFBbNu+y99qYViPKYkb0u1Kv92EUIklbzy7BZN/oTOGqKPA//xezP8eJeCYxoQMVUD0RyUpjqk1ZZSpIYVOzU5dliTKcjyg16ok/Z3ydRpyg6B1EVIw1q+iJqX0rrY6Rxteeur1MmpY8ueb1JCWeixZbZV92SDWPEnLiaMEexlfPL6DbLz1xlIpfeGUz6rG0n9nZ4nPv78PDf3P+L2MbPdBQpVpoQJLA7iFJliNzc9kRDa1sgipd9icIY1U2VEjUK8WRoMSUdIeYI1HtTJ5A0i3YYYkseATWk53Wt4S8SGyGRAvM9BSpZT5T3wdDbro1HYpRICdQN9e6rI6rCGQvZv8f0JLE8PbCZ8OGB0rFZwqXrFCeq1eSrpoVEVNIrwibzyfpQrCiLWOORkeQjAnv7RPhyaCkqrzMXzHXlf9QobFYvrU9gOEqFImVEokZ0NJ384tk5SWd/FLneBiZHD3LGetQl+npwxdopD5hF8w==
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM8PR04MB8037.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7d5e0cef-bc96-4490-1453-08dbc40576fb
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Oct 2023 11:39:55.2977
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: amfk3btB9PNLs8bu5VwlZBTuhNHYHsdefgKEv/EdjZd0y+hAmZl+qrbF8Ncw1/FRuwe2nq3C1WitzbdJvNJn5HbkmWI85j3v1Rs9EX2yWQ0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR04MB8127
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,
	SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Tue, 03 Oct 2023 04:40:04 -0700 (PDT)

On Oct 03, 2023 / 11:43, Herbert Xu wrote:
> The lskcipher conversion broke essiv.  The superficial reason is
> that it was missed during the lskcipher addition as it does something
> similar to cryptd by being capable of both creating skciphers as well
> as aead algorithms.
>=20
> However, this also revealed that users of skcipher spawns were
> dereferencing fields that may be specific to skcipher_alg.  This
> is invalid as the underlying algorithm may be an lskcipher_alg.
> Only fields in skcipher_alg_common may be used.
>=20
> This series adds the necessary helper for this and converts all
> users of skcipher spawns to use the new helper.

Thanks Herbert. I applied this series on top of the kernel next-20230929 an=
d
confirmed the failure I reported [1] goes away. Also I ran my test sets on =
some
dm-crypt devices and saw no regression. Looks good from testing point of vi=
ew.

[1] https://lore.kernel.org/dm-devel/4u6ffcrzr5xg6tzoczkfnuqy7v2e3w6243oxds=
u3g4uughh6go@6owks5linnxi/=