Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
Date:   Wed, 4 Oct 2023 12:03:33 +0200
From:   Lucas Segarra <lucas.segarra.fernandez@intel.com>
To:     Herbert Xu <herbert@gondor.apana.org.au>
CC:     <linux-crypto@vger.kernel.org>, <qat-linux@intel.com>,
        <giovanni.cabiddu@intel.com>
Subject: Re: [PATCH v5 2/2] crypto: qat - add pm_status debugfs file
Message-ID: <ZR04dWCgPU6dnzpW@lucas-Virtual-Machine>
References: <20230922101541.19408-1-lucas.segarra.fernandez@intel.com>
 <20230922101541.19408-3-lucas.segarra.fernandez@intel.com>
 <ZRkrasH0zjj2m+GQ@gondor.apana.org.au>
 <1488c761ef924df48ff89825ea8571e5@DM4PR11MB8129.namprd11.prod.outlook.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <1488c761ef924df48ff89825ea8571e5@DM4PR11MB8129.namprd11.prod.outlook.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?zZRJwnpkB6FQNaAqCL+lvXucylK+2/0JTTv8yi5Tyb7Jb2Z5m4xXmi9V9SIr?=
 =?us-ascii?Q?tImbhL1IquEyGhTFQhMiagu+pDt0joOmCO9H/qn/bd7SjUf/Ji3a8l7/Q5Xj?=
 =?us-ascii?Q?iTMuemY9cGolfS0kvrFdSQaK2rohUCTFdBIUq3G9FOaHJmjrAPohPFKZ8a8s?=
 =?us-ascii?Q?//trF1PTyKvzOdFbMsDPOS/HEtVZ0l+xdZ2T7sH4Wgyo/a8Ms6P9QDSkU4jV?=
 =?us-ascii?Q?7V6NKrTN2BStc9F4ItYd4bsa0UlKi3DCeyoHS6FgfHDboehv+6sP+c2JUuBO?=
 =?us-ascii?Q?btyFkHttWaTKfjKBNDgHL7pURu1LAxK635HUFBCP+5GCUiMAJYPWc9IaQzXY?=
 =?us-ascii?Q?4Fvoi7spsKCosdhbo/PrCQEQV+ScGlN77pXezeg3yaRIvyT/DkUItQ+lDHH9?=
 =?us-ascii?Q?3grJwECXTugqcndCNDyzX4n9iSUTRsijQWA26djmIOs5UuvkptX6WsvnouTO?=
 =?us-ascii?Q?kz3M6n5LqDZRTFbRd7mjdScq0IxL1Zw09r817wJol0J7loQPvmyp6KagllP7?=
 =?us-ascii?Q?YKYdSH84wlaiDGerJshsztiOd2u1MDn5KJW8QP57xaVab2rcboiSMHzMWFoC?=
 =?us-ascii?Q?GD2PnCh2vh247meVuurd1SNDlc5DtdOyxHZi9zT55939hzhH4UwybrtYghih?=
 =?us-ascii?Q?60DbHcTQqawkq+R/rfy2w7mQdkKP/G76dAKjmZLgL7b/sNUCgDtN96xeu0vo?=
 =?us-ascii?Q?fAu2Q1vEv2QPA51ZsQhUvBIbLGK1DF6iK58Gw8yWxvVrJX412bPV6tXHvyt2?=
 =?us-ascii?Q?gKkHWhl7MQRcd/Xgc75mn0T4u37w4mX5oWzBe/XP3TkBGEl3LoIQWno3vqYm?=
 =?us-ascii?Q?upqn3QuUkQpk7BeR7UwMa94XepXypm5lVCAsEoghtyKghmd4t0k+OjLQUMa3?=
 =?us-ascii?Q?1FVoKiyTAx2Qm29bCeJeQ1Yl6gOCzXRMkfNXMo7F2nObER0JE1qho/zUjMeh?=
 =?us-ascii?Q?fTQQy5FiWDvsFx6nGdAryxiW5/Mo2/qRx2ZnIBmoXFSca2dB+iIzXg2gxd4i?=
 =?us-ascii?Q?g6KjBwbqYgd8xSXMQzpzRMNc1I0tVblSwDJXUDWqbTW1GJeYCuogSlThE/Vk?=
 =?us-ascii?Q?q4C/jzifXu7w0zIBZtUGW9mIZR8LDO1iGK40E8APQINZemjCQ3N+IFPIguSp?=
 =?us-ascii?Q?vSRxiMQRm66C1V4MGSO6DzqjS5KQtERCcMLijpjd7ZNKgXOhRIcj+I7vCMzV?=
 =?us-ascii?Q?uap/f7BKC9KLqGCUSPXJv/Rltjanf7fgIgabb+7bPk7zxyKhaIuaUWuoIdUy?=
 =?us-ascii?Q?RSnl1ed/8g7Nc688HtNu7XuM2knFCfrrnB0VLEmdtypIGhED+BE1hkkgQ8Nh?=
 =?us-ascii?Q?/yYKusaEzAaOaxNFci2sqO5sAJEnmoBnqqudkrp9yh5OOwIBimG9+DQmqeGd?=
 =?us-ascii?Q?sKQf8sH9iHWDf8makl5RK1dMcAgXyUvNyT2o26YB4ypSFm1/rduK5IMC4jvA?=
 =?us-ascii?Q?RbX9PEgxxuxjFHy+qlf2N8b+MuXN8LXbbHDoHJ7fjbzr7sDMGgcJQwdl+DyH?=
 =?us-ascii?Q?oBpIn3MuhM6DCRkiXP93p2Y740//aNzMsmWnoxSUYaE7dFBsdM1PAirknuP2?=
 =?us-ascii?Q?FqJdtlSm6OASTmjZowqaMChNUji8hWPjPUlLBKoQBVS5eb5OPAP4zA66qhng?=
 =?us-ascii?Q?0YZB3fluSJpsmJJRTNuox6c=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 02cb96ef-7a91-4d20-5214-08dbc4c12f32
X-MS-Exchange-CrossTenant-AuthSource: MW5PR11MB5812.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2023 10:03:40.5454
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 78h3mQJwOENYF3gACtp4jt/fn2pmLEPmHzwuUkywk+L+n9pkX5eSOxsm24okaAsykhW7cQPbFzKe2HqHsr8LTpOAZNrIYsuQzCmcUvURiwSQTI2oZpoukLAdM+Oiu8iC
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB8204
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Wed, 04 Oct 2023 03:04:05 -0700 (PDT)

On Mon, Oct 02, 2023 at 12:13:46PM +0200, Segarra Fernandez, Lucas wrote:
> On Sun, Oct 01, 2023 at 04:18:50PM +0800, Herbert Xu wrote:
> > On Fri, Sep 22, 2023 at 12:15:27PM +0200, Lucas Segarra Fernandez wrote:
> > >
> > > diff --git a/drivers/crypto/intel/qat/qat_common/adf_gen4_pm_debugfs.c b/drivers/crypto/intel/qat/qat_common/adf_gen4_pm_debugfs.c
> > > new file mode 100644
> > > index 000000000000..55db62a46497
> > > --- /dev/null
> > > +++ b/drivers/crypto/intel/qat/qat_common/adf_gen4_pm_debugfs.c
> > > @@ -0,0 +1,255 @@
> > > +// SPDX-License-Identifier: GPL-2.0-only
> > > +/* Copyright(c) 2023 Intel Corporation */
> > > +#include <linux/bits.h>
> > > +#include <linux/dma-mapping.h>
> > > +#include <linux/slab.h>
> > > +#include <linux/stddef.h>
> > > +#include <linux/string_helpers.h>
> > > +#include <linux/stringify.h>
> > > +#include <linux/types.h>
> > 
> > The kernel.h comment applies to this patch too.
> > 
> > Thanks,
> 
> Will be resubmitted including kernel.h in this file.
> 
> For the last 2 submitted versions of this patchset we've tried to apply the Rule
> of Thumb mentioned in [1], understood as: Include kernel.h in every .C file that
> includes __3 or more__ headers directly included by kernel.h, otherwise include
> the directly used headers.
> 
> It seems this understanding is not correct. Could you help to understand which
> is the Good Practice in this regard?
> Should kernel.h be included in __every__ new C file a patch adds?
> 
> Thank you!
> 
> [1] https://lore.kernel.org/lkml/ZPAPSOnSTMgYrlV%2F@gondor.apana.org.au/

Patchset will be resubmitted based on the following asumption: If a C file needs
to include any header directly included by kernel.h, include kernel.h instead.

Regards