Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
Date:   Wed, 4 Oct 2023 10:52:57 -0400
From:   Daniel Jordan <daniel.m.jordan@oracle.com>
To:     Wang Jinchao <wangjinchao@xfusion.com>
Cc:     Steffen Klassert <steffen.klassert@secunet.com>,
        linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
        stone.xulei@xfusion.com
Subject: Re: Issue: Can padata avoid dealing with CPU-related operations?
Message-ID: <cwcbhk22vycf6di4d5x56l2e5sxm2o5s45v4w6abqggyluyzko@xhcveoev3vhu>
References: <ZRQtYnAhF2byr784@fedora>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZRQtYnAhF2byr784@fedora>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?8RrYws8OIR5KirZSrpVNKbNEWkLh8WxPHPApBw06DfZkDUWLOEwSrLCReu1X?=
 =?us-ascii?Q?RyHuh17FG6dX+Cg2YaBDK7UdxFcb/HkgPE6vwwHLE/ybxBMvD1lY7U9TRydM?=
 =?us-ascii?Q?PFN0skPmIsw6lQy4yg+UkGe5Y67+jxLp1X2Otjsgmn3rDntbZ+DQUfkVTVjm?=
 =?us-ascii?Q?BHwfseem00w9VtJdbkdkhy6ZQUoXPSbQ3XOUuV0X+JW8ouASJwcAD+4hJw8Z?=
 =?us-ascii?Q?Zue3dXvTnthJCKburcn2SifhJqbPNo+nH0ApuVl0spm0rj4gPPWLhZmloXWx?=
 =?us-ascii?Q?Wk5xdkGKv+eRUZ6+qtN5O9usUCTUXdi0e5pMjgbZJTmVD4g5uJC0kKU26qzl?=
 =?us-ascii?Q?/RM+RquJ6qNlv6+6Ep/vWT6byiWm7BefrrSZ7P/vRfdMgSXNClHXt2LdBxu4?=
 =?us-ascii?Q?R3XA9gFzgygnjmO03Z28RE9/1Hy64DS24OKdtaTffuSoWq/a+jCkU6GA8VUJ?=
 =?us-ascii?Q?JMboFsGgLTXoRYE9y2pu4/94ly5icrkRH8v9YVY4YP9RMicfADyrABvWqd37?=
 =?us-ascii?Q?244oHc3NbW3eICwuOiLaUE86OT/g8sFJjnrAlAQlfpF+dp9pb0sxdMiei2eo?=
 =?us-ascii?Q?+X3QkXncKqm2FNlpVDxMhLrShtUWIC7UsPrQGpwB95X2LYIy4U+u/8PBZbwf?=
 =?us-ascii?Q?p7WWbLF3IUMT6Jtbn0sjfVHgRXTzYW5bIhoDoj4xLLUDWT/W3hCZFlTXQeXt?=
 =?us-ascii?Q?XQnWih9m7qKsT4Jl9ih0RUR2BAUHwP1vpuemJ9dzgO/3FnCcVQVgQQMmJDjG?=
 =?us-ascii?Q?+X0UJYl0ON4REG0Iapk+fTsMqLpu/rBOtPJUZMzarnqTr0lttDvoLJ50+jBw?=
 =?us-ascii?Q?U0kTQ//lOFudYicp1Hzn8FzdJqZsSmqiU/0y4GlZm1cSGmtke8eMbJwVv0gu?=
 =?us-ascii?Q?MQ2GL+BlnOc3bmHSW3MKhrbXCJMUMdTwgYcs7BK+nVASonDm398shdPGFdlC?=
 =?us-ascii?Q?wDDVDFW3+VwRJcNqGYy+XFEzjnT3oh0LRMtRjyd7Ol/YaF89bV1CrR0Psar3?=
 =?us-ascii?Q?PL2AduRe/bOZgdDmXBXjsv/BXbrsKQK8QHIpAxZkosl/3sDegYu6Jr4fl7D6?=
 =?us-ascii?Q?yUjaxxlCO2m+VpA37LeOXCugBGFu0SQVcRAqlGhm24L+0e3UaTbEx65H5MJe?=
 =?us-ascii?Q?C6d73V+5o1B3hCOyBZ9tlAxs6DWrJYDjqnxgDyZSYK9rQnwgsNk7wsj9f26O?=
 =?us-ascii?Q?cSPXxf9MBrb39gdkqGVOYdw7Z89e5MaVMhN/QFWnGEUCoLK1ZSIjdSFehRCO?=
 =?us-ascii?Q?68oRSAOKdEPg01OAuJ7BgjItpVXx+RBLcPwnn4wx+tsnpu4riQvZpWmi9y/D?=
 =?us-ascii?Q?uxAND/YmhVh1WJwJjgcGceocKaXRdZyaEihxb3s1tQSyRZJpcLtgU9SGtIo0?=
 =?us-ascii?Q?VBtY9PghWKkGrJpdwlc73A4YngveH3Kuqqotps2cUNeAHYYNg6pb2i30atlU?=
 =?us-ascii?Q?Rit9cDEuqnH0PK69J5uhrK1TvgVbe0Z/7msmngZGHGU/x4ocqmW8Y6dLRRtw?=
 =?us-ascii?Q?KY3S+zpQEgBs7sbbA00dmXHAIqCvAcLfTqvPVS+llHyyB9053WRGfevBGQjL?=
 =?us-ascii?Q?mY+xdgY4BMz6LNyoim+tMwcirLKAYnVHMENmGy/yNa2+Ym1VAIEZlNG1GV58?=
 =?us-ascii?Q?Vw=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: CL94ZSqRBsVNekHK1IPPcP1Avo2RJ04NT4ciMGaDiVtzze/Q/v/RB3ugoCzCbaB8yB36D9gdV5Sh8xBfRtIGW+LGTFSTvzmhC218pZhCsBO8Q8jV+bXoqFMrMsShHHv9h6EX0OErTIf5gwWAJfI4gUO/Su824QT95Iddrc4WLq3dpsrPV6HRaXDXFUgdzFb/oWN0KI6q8O0zmo1Ro4vHvBQAW7Mq4JrI4B2mSUWe4DwHrlZBDtsb+09hLUZg/W+vy1hM1j4qdHjIXbJ2xqM45v7Iw2C9+CJOrQZ+2QrNSILPTEiqqxQELyoBazovyTuMyoXFpvIfkYpv0bDgAq/5sZSGGZSa2SjaGYp2uNMAREUV5K2YuD2uj+YM9nWrjX+3AOsdOOaOHDr9N+OJ6pD2SooqhYK9Np6yYb3X/BKO1zjZBJ0fGC2lsQqFWTA+OJai9CRAiWaB0D6SOk6zoCpFrJspg+I+IJ6GqhBH1JzMec38SORP5aP2c9EEal3vC+b+5iv7PTQPMuCqQSXxymGcKsyHntw0g+6PRc9U69JtbK8jRHAyTJmKp3RQ01X4YZGH+FrrSFnbqHD5AUnQXr0gXVg+8yp4Lmp7GzkENwXlbNjE56yQHfOvbZCYA3fAu/ldZhTnbUMlnBp/jTSnK4ykzTPPimmD3fBsupSxUIjERaAcoS8zc359Z7L4q7sIosDTW0n9wa9fMco9Ggf6S/RreciCMwmV3k4gCBxc7DKpoNeg01ooIFoCG0Cybsr/kgi7a01TyinJPOIdHs7M8s/caQR7PimzciFzUy0LiqVNEyNA90+Kxsv6zTAAW50VVOZ9lU+FNkVvF1KekO1aA2z7ww==
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1db4adb7-c051-4a1d-caef-08dbc4e99b6e
X-MS-Exchange-CrossTenant-AuthSource: SA1PR10MB5711.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2023 14:53:01.9912
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Es4y1zTJYyBIHIaTEN6PVEZylU5JF4VinhvhSr4+VM8tmWybGiqqLNa6MHqNfDClakts6i0OCp8wAAyOmglRgzkC21d5iphuXTKdQn/S4gw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR10MB6975
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-10-04_07,2023-10-02_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxscore=0 spamscore=0
 phishscore=0 bulkscore=0 mlxlogscore=954 suspectscore=0 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2309180000
 definitions=main-2310040107
X-Proofpoint-ORIG-GUID: X8QSzxZQ2noNwg-1qui_9ACEHDbuu0FO
X-Proofpoint-GUID: X8QSzxZQ2noNwg-1qui_9ACEHDbuu0FO
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Wed, 04 Oct 2023 07:53:12 -0700 (PDT)

Hi,

On Wed, Sep 27, 2023 at 09:25:54PM +0800, Wang Jinchao wrote:
> Hello, I have a few questions about the padata code I've been studying
> recently:
> 
> - Why does padata use the WQ_UNBOUND attribute of the workqueue?

There's background in this series:
    https://lore.kernel.org/all/20190813005224.30779-1-daniel.m.jordan@oracle.com/

> Because I've noticed a significant maintenance cost related to CPUs.
> Are there any specific benefits?

Aside from what Steffen said about serialization, the pcrypt cpumasks
can be set from sysfs to control where parallel and serial jobs run.

> - In what scenarios is it necessary to specify a CPU for serial
> execution, or is ensuring the order sufficient?

I'm not sure that it's necessary.  The way I read it, at least, it seems
pcrypt uses cb_cpu to load balance serialization across all CPUs allowed
in the serial cpumask.