Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
Date:   Wed, 4 Oct 2023 10:54:55 -0400
From:   Daniel Jordan <daniel.m.jordan@oracle.com>
To:     Wang Jinchao <wangjinchao@xfusion.com>
Cc:     Steffen Klassert <steffen.klassert@secunet.com>,
        linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
        nstange@suse.de, tangqingmei@xfusion.com, stone.xulei@xfusion.com
Subject: Re: Issue: padata: UAF in padata_serial_worker reproduce
Message-ID: <g6gbj5ailv5q2olhhlgpgkr3vuolvbagpf3bff5pxqkpikerj7@qyix5rcdkzyw>
References: <ZQft1jGSMSTRlxfi@fedora>
 <lq67pqfz4ucmrpbwmor7h23x2iafsnyh4yuz3mfrfaxrsqbyxz@wqp5rih7grwp>
 <ZQuTSeIskyDjkiMg@fedora>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZQuTSeIskyDjkiMg@fedora>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?27RTh6eHh667GOb3B6wlCH9Kso3WgvKhJd8xvbRegqg4Zx2cGudGsNoDIZAk?=
 =?us-ascii?Q?WRKGYttSRCBoivQHDmXUDqg4lSebqHED18vdxBkv9o/tn2s5GxVdeZ10EaJb?=
 =?us-ascii?Q?K76JHxQREzHPjDNlxOQmSdcTTObDOmtGvytJFNBQ8P2IVODxR+HlUMHhVIvp?=
 =?us-ascii?Q?17SemEM4lUV3oFYaDjlfD3hd0/9v1JoIsQY6ycpR6OzFf3ZGt5JipeIh5kE4?=
 =?us-ascii?Q?/fSsYao+fkial30daH6Bra1szwPYFzhuTPQoqWYgd8YFYNACBZn/bhZwKbfS?=
 =?us-ascii?Q?3UH4el/7HpLRfAa2Sy/jYEMWJkpD1UUoY6lVQXosqflkq1TkAJF2ca1GEAxX?=
 =?us-ascii?Q?EeYny3I7oWvO8jjxLJQd6r1J68p/ekisOKYJLMpC/SOW6JbW37AGo2ldQxyI?=
 =?us-ascii?Q?4NjTVVHMjJ9mHC9F6NxbhggvZWNZblXfVZ0ydbpUlfejwbuxf1mgvBEsh4fg?=
 =?us-ascii?Q?gFoLAwhBXGAevcWxpVnwZh/m/55xtopfBau9+IBaT7q7VVLtk8bIiYcYUWmV?=
 =?us-ascii?Q?rgPlYlKsgGK9LAwneFwb0R9j7WH0Jb5o5HqYU8hgGye3Q8In6rya+DgqLLvZ?=
 =?us-ascii?Q?E/7kX0ikaOjrKVH2tHLBSz9dyeKnr0YLF+1Vvdiq+CMkk6Hcvcr9FTk6XtDT?=
 =?us-ascii?Q?XhVUtdU0eLmmL1DxzUniBPOVCS6S5YY7Qw4VOacK6ukuRbz2l5/1o7eERwqe?=
 =?us-ascii?Q?6hoCOkFLlk/38Cb1nV2FtEcm0PtoTvgRff42YMHJfzFcJ1EaWIEpSr8M58hS?=
 =?us-ascii?Q?c2pLxEIw8Keo9t87HZZ7ne8q5rMrlFGu1/zA8gZbOaJWKbTRuI2gtG8iP7F6?=
 =?us-ascii?Q?8OopnWV9ay3UK3WC1tdoO8j5/FBalW9DF7DA8qaEX9DE5e9JnGILFPBkfdL8?=
 =?us-ascii?Q?l0P0ElSKw978KIGOEYXnIfgL6qVoiXL+Yi07aYWj68penjRnD71fdO3CNpCO?=
 =?us-ascii?Q?5WVwBKs2Qc22CyCr+Zl5IQrapZGW7SMDXGy7yY+6jsSxJVbpcib7k9HpvZIh?=
 =?us-ascii?Q?CEJl+Jo9jo2RFLVpZTc42L2qBPWeMiJtv9BKhGR19PyKsFNxaA4y8KnkJ3GX?=
 =?us-ascii?Q?iV5R6plg1XLIGM/rn6MaZNp0rKSSqMI6Wl01ft+HucpUQgHTcfDMu5z2GZDZ?=
 =?us-ascii?Q?tSnwYniys9yNvPu46rpE+z3ppEyCZAIjiT0stteRhbXUrHqZvaoOqW7fm+ps?=
 =?us-ascii?Q?VHZQFs1Kj6lEFMTVdXsZbF4qQ+68ozxjp36p+TvDZeNTITEs5ohv4x1wcTg0?=
 =?us-ascii?Q?eJPvp9gIPGOnxDfbHMw0RH++sjUEiYPXJahB5brfDMUmnmJ+u4d5fO3/JX2u?=
 =?us-ascii?Q?y0zMNb2vSEsEm6uW6wPcVCMtBpS8sQdx8IAEMDIzAIoD6q4Md0wPH2mWqIhs?=
 =?us-ascii?Q?9Z9LOkKBxW6MfUitYY2o4RPeDUUB0/jJ2Yhif4InNPswBxY6XVNXBAIEwpDc?=
 =?us-ascii?Q?oKOIeERr88blnH+p1GHUKMkl4JHV54U8rvviIgMqH2RePpahs9Y45HImWkjg?=
 =?us-ascii?Q?ejALp7IG4JbYJBL/i2x1bw/pxZIVuCqH1xsxi2hNbwaCHgJkCRSJQ07TlboL?=
 =?us-ascii?Q?wHRhknw62EG2KrXchXlxTumMdqkAYyGzIVwXvktjNiWpW4wUB6CE4PqhFw6+?=
 =?us-ascii?Q?aA=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: fK6IBIgtl4N0+eefvGxyaN2w+RBYR/Ufsh79GczZ3FjPDl3aVjY8vxhrm7ZIf4C91ZhmYvyo2ARzFEVf1eWibdYwR4fPu8/7vxfMuCkmW2lYaZJeUhbYnqnBKAnR/J5iNGie7xHJ7A8UZ3euooPNsjmSA8Jg9RMSsvkeP4Qgo5Z47zTtKl65lSz0k4cHog3sounLPA918A0EsxYOGDC4yuslVhkokOp8Wpn7BsUJARxCf+WxLScpxJN9WzRkCRbRVfRXnsFlGeGI7xo1XRwVASbNPZChnX4yKLPgvrN/gKArM5J8fRIzonfaLb3R20YHebZOQsJ1YTcD7iGL/ER6G7tacT7UWeHQ3JkJSzlVPOqPHfZJmKZwzp42CdhxZis6w9WIm3D0FdwCrdLWqEU5TO2i4iqc6wD6949dPO0qlADIWMerRXF+ZzSNcGJ8AJFdUeTQrqwD4ynV9iqrRWnU7iqPTo55LiknSJ6h5gLx3v6XLOgyg3ipHGztn8H93f+eZRWnQzpcAUettOV3X+kvHYWkGOC6yszsHR/jz8m60943IBRIymci7CFH33ZIoeGVxJzABUuozr6kVJQBGkRdMT1dBFfa13mA5TSQNLeYSE+mYTu+XBF0HPqEY+bNr4RGczKu8W1oJHApsi3oI2AMb75cwFYq7Py3rvzWzYqHQR99p03fqJfJhKriw/ANoJyKFGNZ9z9SbnsQS+22quaqLTDXmAt+0owBkOjEBlpIqnU33U6x4TfMx+eHne3Wop4wkEHPp7Fe11CIczMZvUKMIZ1pKairJ4ydyxcrhyNHXuWYGSwlj6ZuU5dWgDK6qznhFNMX56s06+KM4/tkgVeaCzUyUIEOpsh09nCcxwWVdIU=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1ab7f28c-d73f-4967-084e-08dbc4e9e177
X-MS-Exchange-CrossTenant-AuthSource: SA1PR10MB5711.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2023 14:54:59.3596
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GBsgxt9v2bJChkZFFjlarGnl9yP0k3ivPt8IZZOWUiWXyCeKp8FRT/SaJDozuJkz8KR+MzHbqYaeTLaElfVpz5IW+JKIKl7M2nT9+OnLFSw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR10MB4546
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-10-04_07,2023-10-02_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxscore=0 bulkscore=0
 adultscore=0 mlxlogscore=614 phishscore=0 spamscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2309180000
 definitions=main-2310040108
X-Proofpoint-GUID: H5YT-5JYiaq10DVG242EY_VdHK0jaq7h
X-Proofpoint-ORIG-GUID: H5YT-5JYiaq10DVG242EY_VdHK0jaq7h
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Wed, 04 Oct 2023 07:55:12 -0700 (PDT)

Hello,

On Thu, Sep 21, 2023 at 08:50:17AM +0800, Wang Jinchao wrote:
> On Mon, Sep 18, 2023 at 09:21:59AM -0400, Daniel Jordan wrote:
> > Hi,
> > 
> > On Mon, Sep 18, 2023 at 02:27:34PM +0800, Wang Jinchao wrote:
> > > Hello, I have reproduced the issue mentioned by Nicolai Stange on an arm64 server.
> > > After applying Nicolai Stange's patch, the issue did not reoccur even after running for two days.
> > > The test tools used were ltp20220121 and stress-ng-0.15.06.tar.gz.
> > > 
> > > refurl: https://lore.kernel.org/all/20221028160401.cccypv4euxikusiq@parnassus.localdomain/T/#u
> > 
> > Yeah, this series seems close to being finished, just hasn't made it
> > over the finish line quite yet.  I wonder if Nicolai has plans to
> > ressurect or whether someone else should take it over.
> 
> Hello, I'd like to inquire about something:
> 
> Since users of padata_free_shell need to ensure that all tasks in padata_shell have completed, 
> how can they confirm this when they are uncertain? Would it be better if Padata provided a mechanism, 
> such as padata_shell_status(), to maintain statistics like the number of tasks?

Looks like you found a way here:

    https://lore.kernel.org/all/ZRTLHY5A+VqIKhA2@fedora/