Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
Date:   Fri, 6 Oct 2023 11:47:22 -0700
From:   Dan Williams <dan.j.williams@intel.com>
To:     Lukas Wunner <lukas@wunner.de>, Bjorn Helgaas <helgaas@kernel.org>,
        "David Howells" <dhowells@redhat.com>,
        David Woodhouse <dwmw2@infradead.org>,
        "Herbert Xu" <herbert@gondor.apana.org.au>,
        "David S. Miller" <davem@davemloft.net>,
        Alex Williamson <alex.williamson@redhat.com>,
        <linux-pci@vger.kernel.org>, <linux-cxl@vger.kernel.org>,
        <linux-coco@lists.linux.dev>, <keyrings@vger.kernel.org>,
        <linux-crypto@vger.kernel.org>, <kvm@vger.kernel.org>
CC:     Jonathan Cameron <Jonathan.Cameron@huawei.com>,
        <linuxarm@huawei.com>, David Box <david.e.box@intel.com>,
        Dan Williams <dan.j.williams@intel.com>,
        Dave Jiang <dave.jiang@intel.com>,
        "Li, Ming" <ming4.li@intel.com>, Zhi Wang <zhi.a.wang@intel.com>,
        Alistair Francis <alistair.francis@wdc.com>,
        "Wilfred Mallawa" <wilfred.mallawa@wdc.com>,
        Alexey Kardashevskiy <aik@amd.com>,
        "Tom Lendacky" <thomas.lendacky@amd.com>,
        Sean Christopherson <seanjc@google.com>,
        Alexander Graf <graf@amazon.com>
Subject: RE: [PATCH 01/12] X.509: Make certificate parser public
Message-ID: <6520563a5865f_ae7e729459@dwillia2-xfh.jf.intel.com.notmuch>
References: <cover.1695921656.git.lukas@wunner.de>
 <e3d7c94d89e09a6985ac2bf0a6d192b007f454bf.1695921657.git.lukas@wunner.de>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <e3d7c94d89e09a6985ac2bf0a6d192b007f454bf.1695921657.git.lukas@wunner.de>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?7xM1oNkjSoC7JcBCjXenNOiaHblaHIjJkFOrjYx2TmMdnGRIpksSIo4wIn2z?=
 =?us-ascii?Q?Wl/brdVeD5X03XfvmQTTS8RlmdEyD64JojBzA4dkVoS7RIUsfIYKSUBhRYCH?=
 =?us-ascii?Q?1LyXcB9L3TSvQ2sfaGGDAll/SV8s+RMXvaAlTYNnrFILKK0zQvVGr23olix5?=
 =?us-ascii?Q?/KwbCfnfjJfYMY02gVLN7csS3oHEzMETaNkYx8JGrkm7YvOLQc+wEFwoDvFV?=
 =?us-ascii?Q?0sWuJLm2yB8ZXfVk7qN5xCSYkG1Ih7Vyjh1HWCD0sLKGC0P6m6brUbg/Ag8w?=
 =?us-ascii?Q?M8/Y8071OVR+an4CrfiL42bKaXQACh6PfBFi5PUU4ULCJ/OZtjIehmYQ44HS?=
 =?us-ascii?Q?7/gUovy9r9aKY9h7z67I02+WeUwa+hAZolOmT4Qdu9ybtrRbtMYZuLlMBwMp?=
 =?us-ascii?Q?/CzZTv30wFg/OOUzpMCoBCpLAF0bIgnpj6bc+21UIfe8Iw7xsizDNx8TGrXe?=
 =?us-ascii?Q?vwQdL4FxTRBLe+KkcY5u15oAvZDdlj1nZf6g6rAR97q/K1Ek9v7TKWt30yLe?=
 =?us-ascii?Q?K1eSlENTQNiDu9QWiZuYq3Durk8h9bGMC67/7wwe41iXjyLssK7xdN8cl5sX?=
 =?us-ascii?Q?n5KWNaslrUG0PxJMVGtbHMYjlL8f2/tBwE7lU/rwuiIzryeZa7t/nyitMvUU?=
 =?us-ascii?Q?vT9/yEpyJuUjmwqXbdwf5QW4pNllKXBKmiCNdj06Bb94JBiav43w7VZICKvC?=
 =?us-ascii?Q?nbkvLjS6C6HhPDDhbE2RIGm9FNQifAbLZ3yYpDKItwDw3MNAzgplutmcOFqI?=
 =?us-ascii?Q?yAm5wWjV1sXgm5krwMp/Ks+vCOOnV22zJDAfVPxWhdzlAHIZuRAaTTByoxcp?=
 =?us-ascii?Q?cVNLib5OQvq0OlVA8o5VBqMQwaoCyGHfdXwgq6Z+IwmT+d6RydusAK/hI8lr?=
 =?us-ascii?Q?bw1g2Ft7GJBGii60Uc0CzljhbA304rkLPt6zOE3MPUpzrOZ+fj/oif+LxsrN?=
 =?us-ascii?Q?6P7yK6DKcnL2rsVVA73ZxOQda8fZvRt1d/PxYvnbLtNus3XnlST93TBZESjC?=
 =?us-ascii?Q?Un4DoGGCsGLBltrb8CqA7+TA0dY7xazdXnuAMTRrPUIqWKyV4sp3/HwWCrpu?=
 =?us-ascii?Q?/OzK5P5CJMr8u2PDsevTcm4W7zLrNhkF/Erk0H+Gx+GW8Cmbd6zaINS2XGwb?=
 =?us-ascii?Q?M4eP2InE4FbPu4xRPdFVGFvIt0tu+lWfDz3AYSUarePEliNtvo0aqhyRuUwT?=
 =?us-ascii?Q?hy908nLPDZ2W3AL/2su3f0eT/zC3BPyWWPKSk5bhe6ZxrK63ouR7KZWY7M06?=
 =?us-ascii?Q?op29LYX20v13sHiooV8FBFTjPxO2x5iFIic+Zxe0z7Vp1TEOn8nTf23dWKDI?=
 =?us-ascii?Q?z5WYBS/52s3jyHzBRnrf+NNmOlGX0BSXNwruN8Cey3bXakBZCbeSO5dRxVCi?=
 =?us-ascii?Q?mtjphPZSD7tavj53VDWDoxHW0YQza36Fy6x0dELWBVdF4OaU+uMXAwr0cE4D?=
 =?us-ascii?Q?Qa9OQ3MhPoeF9dXTmyMH8WAtA6ydT0kiAtRPoA7xFX4RKKCLAfEAnhRybv/k?=
 =?us-ascii?Q?IB1+1ovi3EihmUv4AgE4ZsR5EJRm1GP1JBfj5G/VKC30d4ZH9hwBunqFvxVL?=
 =?us-ascii?Q?LSc38O9/HAYf4feO1WnVAjJQRd409HnxI9E8npVBT78fhRH8IRzFVLcvCTl3?=
 =?us-ascii?Q?dA=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 0e17d1e2-34d2-45ec-5dce-08dbc69caf89
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Oct 2023 18:47:26.6900
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zaoqZkJ4WA9sjKYMx/e/VXdieZeYV9P5WAJ2UwlhQ2TX4xt6lHpoMhM9XBmrYqD1+MwtVzyvZmsip0mvsP8FfDwLag2zonePa3849lZCrs0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB6839
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=2.7 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Fri, 06 Oct 2023 11:47:39 -0700 (PDT)
X-Spam-Level: **

Lukas Wunner wrote:
> The upcoming support for PCI device authentication with CMA-SPDM
> (PCIe r6.1 sec 6.31) requires validating the Subject Alternative Name
> in X.509 certificates.
> 
> High-level functions for X.509 parsing such as key_create_or_update()
> throw away the internal, low-level struct x509_certificate after
> extracting the struct public_key and public_key_signature from it.
> The Subject Alternative Name is thus inaccessible when using those
> functions.
> 
> Afford CMA-SPDM access to the Subject Alternative Name by making struct
> x509_certificate public, together with the functions for parsing an
> X.509 certificate into such a struct and freeing such a struct.
> 
> The private header file x509_parser.h previously included <linux/time.h>
> for the definition of time64_t.  That definition was since moved to
> <linux/time64.h> by commit 361a3bf00582 ("time64: Add time64.h header
> and define struct timespec64"), so adjust the #include directive as part
> of the move to the new public header file <keys/x509-parser.h>.
> 
> No functional change intended.
> 
> Signed-off-by: Lukas Wunner <lukas@wunner.de>

Looks good to me:

Reviewed-by: Dan Williams <dan.j.williams@intel.com>