Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
Date:   Fri, 6 Oct 2023 12:23:59 -0700
From:   Dan Williams <dan.j.williams@intel.com>
To:     Lukas Wunner <lukas@wunner.de>, Bjorn Helgaas <helgaas@kernel.org>,
        "David Howells" <dhowells@redhat.com>,
        David Woodhouse <dwmw2@infradead.org>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        "David S. Miller" <davem@davemloft.net>,
        Alex Williamson <alex.williamson@redhat.com>,
        <linux-pci@vger.kernel.org>, <linux-cxl@vger.kernel.org>,
        <linux-coco@lists.linux.dev>, <keyrings@vger.kernel.org>,
        <linux-crypto@vger.kernel.org>, <kvm@vger.kernel.org>
CC:     Jonathan Cameron <Jonathan.Cameron@huawei.com>,
        <linuxarm@huawei.com>, David Box <david.e.box@intel.com>,
        Dan Williams <dan.j.williams@intel.com>,
        Dave Jiang <dave.jiang@intel.com>,
        "Li, Ming" <ming4.li@intel.com>, Zhi Wang <zhi.a.wang@intel.com>,
        Alistair Francis <alistair.francis@wdc.com>,
        "Wilfred Mallawa" <wilfred.mallawa@wdc.com>,
        Alexey Kardashevskiy <aik@amd.com>,
        "Tom Lendacky" <thomas.lendacky@amd.com>,
        Sean Christopherson <seanjc@google.com>,
        Alexander Graf <graf@amazon.com>
Subject: RE: [PATCH 05/12] crypto: akcipher - Support more than one signature
 encoding
Message-ID: <65205ecfaf11a_ae7e729414@dwillia2-xfh.jf.intel.com.notmuch>
References: <cover.1695921656.git.lukas@wunner.de>
 <f4a63091203d09e275c3df983692b630ffca4bca.1695921657.git.lukas@wunner.de>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <f4a63091203d09e275c3df983692b630ffca4bca.1695921657.git.lukas@wunner.de>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?pIthdSrxpqJ3TOMjcNo8m+iohFLL9kwnrH2DME9/Wd9hKhzgW9BLeSRobH/m?=
 =?us-ascii?Q?NuSV/pxyDF9oiszjjNq2ymryDtUPxgbOdXJKbqBuC/YjsPbtYhHINBw18EnQ?=
 =?us-ascii?Q?VWUwdwUc3rTnKFKUJDBBdLSge7HfKw+n4OlEh39jNTJKxT407+318o2LV2Jr?=
 =?us-ascii?Q?ruRpbtptsIH/9RAZP+Pwmr9YB4zsvtnK8ezVARMRs41l6TKRbgg0Ce1z8kFd?=
 =?us-ascii?Q?c+8f/s3E5u9KgDEoroUJImIP1Kxl0zMaBeMWM733pqHo2bedZ9XuLtOwFpbK?=
 =?us-ascii?Q?vJcadFEYC3X/Nfv7hP5AZCDrEMh4f6xmz1Oz0UMzOyXQRVf32DiMAnQDPzZn?=
 =?us-ascii?Q?bgCgTwPYWBmaS2zJGA2ASaF1mGKBriabHQxVq25m7/ENVOj42ecRvt6bSaTZ?=
 =?us-ascii?Q?WJoZWN1I4suBmnMNVlueLEYM1zdBEEXjhw3inVq0fFzCf/41FLUQhEDqFuba?=
 =?us-ascii?Q?ArZT6vPY3I6zJqxOfAHAxqd/9FUeqO0ADzCkS58+cOkwdgWcpcLRemglPCgL?=
 =?us-ascii?Q?XbfKW3kIEODmvXfbmhiqIV1yVdOGjjKeWTYcCbj6bZruAy11bvK1ppG+ZW2c?=
 =?us-ascii?Q?svi2sziuvV5igNAegE/kTueR0ZslKbOo0jxP9xm/TBljJ2AgoN8hJLRNmro6?=
 =?us-ascii?Q?k+oZnMqGJ8NWEd8N1DUkQLmqNRepUE0Y2Wn3pZrZ2zYlJVyIOhtASnAN80PO?=
 =?us-ascii?Q?Cbn0xgd4niHddialYbQTRi+7+iY8RRGciC4gZ7WyOZA7oms0AZ7qxy6/XOBV?=
 =?us-ascii?Q?jFXknlW5CaY37SPxRUN3kTNMXZ7xDVP/KOad0TYDCZHRV4LZUfiKuh5JDq3K?=
 =?us-ascii?Q?7anUnphYqPHjTeOZ3pypD9QwG4jM4sSztus+Cy9c+dDkiiPphTmDLIzTr2uM?=
 =?us-ascii?Q?B1hPd5bgnoYg6ESQshYZ+Bk2li4PKtAfIHpBzXnEAiMCjZtH4ooS9pngZPQT?=
 =?us-ascii?Q?UrGNOYtg63DTGVVUsU4RIpLTYLl1qhTp/lGZkYpj34z1sorHpuYkvjAr3RnA?=
 =?us-ascii?Q?DJHEeSdWx6x4vSnCAYSWgKK3eV0NmPbHNpdX9ok26/0YgtQepwCBJ6VV0chL?=
 =?us-ascii?Q?7qD543rszTbYY1553B5i0zWeG++qntu3KwAZRClSa/w6VOVP0CRD4/m3jdZ6?=
 =?us-ascii?Q?+AQl5oe64IRBcGzDe5KnSfYzdW3xy8egZBfjh3pCm2ZrESR3mP8OoqFiLlO1?=
 =?us-ascii?Q?nrDMYTk61RvG8jqSoe2byNOkUQQDD0T9YtzTvWpykMrGOMhw8galxx7d+E5d?=
 =?us-ascii?Q?zuATKn99m1vgwZFpkFYLsfP0BFFJifgu4X2AP3nKWTCrU4gVmo0W1qFRtvFn?=
 =?us-ascii?Q?fwvaS2FC7f8RHmkbgrTw935/QCHGoZeSxJtqZ28khBos6HC43pyVx/hx/64K?=
 =?us-ascii?Q?WFHqsCA1GmDn9qW740qIqXFUr1wXP1DeGdO3Za7RAeDTeS2EQGy4vA2/v31x?=
 =?us-ascii?Q?CrHAlQ+Y/7mS9yUDvghgFWkZcKzSIwilq9Ojje1iqA/YOm5SE7GJCPuK+X1k?=
 =?us-ascii?Q?FKiiCL57qjn3rZHV0RT8XNGG2P0Fbf/bzHEGDopjsNV5Ohn/YgWoMQcs2529?=
 =?us-ascii?Q?/8p+akv8Df0P2jePQW3J8k5+0sycn4Ruwss87h9nHtZERujk9FjISnNfgioc?=
 =?us-ascii?Q?sg=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: f0317825-7844-41d2-2da6-08dbc6a1cd6e
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Oct 2023 19:24:04.3019
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +2CacS3d2kaBvAq43u3biEhR9qsL40FpMgE8F1gZcKnnikdzBsA5J8jaDa61cWUc78yi1B1/L2zqZC1UIUzo3X2+dy2IDbPHRiEzeBFvTmI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR11MB8335
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=2.7 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Fri, 06 Oct 2023 12:24:58 -0700 (PDT)
X-Spam-Level: **

Lukas Wunner wrote:
> Currently only a single default signature encoding is supported per
> akcipher.
> 
> A subsequent commit will allow a second encoding for ecdsa, namely P1363
> alternatively to X9.62.
> 
> To accommodate for that, amend struct akcipher_request and struct
> crypto_akcipher_sync_data to store the desired signature encoding for
> verify and sign ops.
> 
> Amend akcipher_request_set_crypt(), crypto_sig_verify() and
> crypto_sig_sign() with an additional parameter which specifies the
> desired signature encoding.  Adjust all callers.
> 
> Signed-off-by: Lukas Wunner <lukas@wunner.de>
> ---
>  crypto/akcipher.c                   |  2 +-
>  crypto/asymmetric_keys/public_key.c |  4 ++--
>  crypto/internal.h                   |  1 +
>  crypto/rsa-pkcs1pad.c               | 11 +++++++----
>  crypto/sig.c                        |  6 ++++--
>  crypto/testmgr.c                    |  8 +++++---
>  crypto/testmgr.h                    |  1 +
>  include/crypto/akcipher.h           | 10 +++++++++-
>  include/crypto/sig.h                |  6 ++++--
>  9 files changed, 34 insertions(+), 15 deletions(-)

I can only review this in generic terms, I just wonder why this decided to
pass a string rather than an enum?