Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Date:   Sat, 7 Oct 2023 12:01:48 +0800
From:   Wang Jinchao <wangjinchao@xfusion.com>
To:     Daniel Jordan <daniel.m.jordan@oracle.com>
CC:     Steffen Klassert <steffen.klassert@secunet.com>,
        <linux-crypto@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] padata: Fix the UAF issue related to parallel_data
Message-ID: <ZSDYLKRcGFp2Kcxe@fedora>
References: <ZRTLHY5A+VqIKhA2@fedora>
 <rjayevj3rwpj6wt2uq2jc7c3oqbewnobdqhs5bkrjte7fxzkct@k5rpt4g6tnqh>
 <paajlxnnp6isq435i7w2onndi56xpwahq6tl6hbjwqdhta375l@kqgpf5nkcsog>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <paajlxnnp6isq435i7w2onndi56xpwahq6tl6hbjwqdhta375l@kqgpf5nkcsog>
Precedence: bulk

On Wed, Oct 04, 2023 at 03:07:10PM -0400, Daniel Jordan wrote:
> On Wed, Oct 04, 2023 at 10:54:29AM -0400, Daniel Jordan wrote:
> > On Thu, Sep 28, 2023 at 08:38:53AM +0800, Wang Jinchao wrote:
...
> > This could use a Fixes tag.  From Nicolai's patch[0] we agreed on
> > 
> > Fixes: 07928d9bfc81 ("padata: Remove broken queue flushing")
> > 
> > With that,
> > 
> > Acked-by: Daniel Jordan <daniel.m.jordan@oracle.com>
> > 
> > Thanks!
> > 
...
> 
> Oh, I should've also said please move the declaration of pd to the top
> of the function like scripts/checkpatch.pl suggests.
> 
> > > +	if (refcount_dec_and_test(&pd->refcnt))
> > > +		padata_free_pd(pd);
> > >  	mutex_unlock(&ps->pinst->lock);
> > >  
> > >  	kfree(ps);
> > > -- 
> > > 2.40.0
> > > 
Thanks for suggestion, both were updated in V3.
V3: https://lore.kernel.org/all/ZSDWAcUxXcwD4YUZ@fedora/