Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Date:   Fri, 13 Oct 2023 18:37:03 +0800
From:   Herbert Xu <herbert@gondor.apana.org.au>
To:     Lucas Segarra Fernandez <lucas.segarra.fernandez@intel.com>
Cc:     linux-crypto@vger.kernel.org, qat-linux@intel.com,
        Giovanni Cabiddu <giovanni.cabiddu@intel.com>
Subject: Re: [PATCH v4] crypto: qat - add cnv_errors debugfs file
Message-ID: <ZSkdzy9EHeeFRxBm@gondor.apana.org.au>
References: <20231004103642.37876-1-lucas.segarra.fernandez@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231004103642.37876-1-lucas.segarra.fernandez@intel.com>
Precedence: bulk

On Wed, Oct 04, 2023 at 12:36:42PM +0200, Lucas Segarra Fernandez wrote:
> The Compress and Verify (CnV) feature check and ensures data integrity
> in the compression operation. The implementation of CnV keeps a record
> of the CnV errors that have occurred since the driver was loaded.
> 
> Expose CnV error stats by providing the "cnv_errors" file under
> debugfs. This includes the number of errors detected up to now and
> the type of the last error. The error count is provided on a per
> Acceleration Engine basis and it is reset every time the driver is loaded.
> 
> Signed-off-by: Lucas Segarra Fernandez <lucas.segarra.fernandez@intel.com>
> Reviewed-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
> ---
> v3 -> v4:
> - rebase on top of latest version (v6) of crypto: qat - add pm_status debugfs file
> - alphabetical order for intel_qat-$(CONFIG_DEBUG_FS) makefile target
> ---
> v2 -> v3:
> - remove unneeded header inclussion
> ---
> v1 -> v2:
> - Rebase on top of latest version (v4) of crypto: qat - add pm_status debugfs file
> ---
>  Documentation/ABI/testing/debugfs-driver-qat  |  13 +
>  drivers/crypto/intel/qat/qat_common/Makefile  |   1 +
>  .../intel/qat/qat_common/adf_accel_devices.h  |   1 +
>  .../crypto/intel/qat/qat_common/adf_admin.c   |  21 ++
>  .../intel/qat/qat_common/adf_cnv_dbgfs.c      | 299 ++++++++++++++++++
>  .../intel/qat/qat_common/adf_cnv_dbgfs.h      |  11 +
>  .../intel/qat/qat_common/adf_common_drv.h     |   1 +
>  .../crypto/intel/qat/qat_common/adf_dbgfs.c   |   3 +
>  .../qat/qat_common/icp_qat_fw_init_admin.h    |   5 +
>  9 files changed, 355 insertions(+)
>  create mode 100644 drivers/crypto/intel/qat/qat_common/adf_cnv_dbgfs.c
>  create mode 100644 drivers/crypto/intel/qat/qat_common/adf_cnv_dbgfs.h

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt