Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Date:   Fri, 13 Oct 2023 18:39:20 +0800
From:   Herbert Xu <herbert@gondor.apana.org.au>
To:     Dimitri John Ledkov <dimitri.ledkov@canonical.com>
Cc:     "David S. Miller" <davem@davemloft.net>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        Alexandre Torgue <alexandre.torgue@foss.st.com>,
        linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-stm32@st-md-mailman.stormreply.com,
        linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] crypto: remove md4 driver
Message-ID: <ZSkeWHdOAOfjtpwJ@gondor.apana.org.au>
References: <20231008040140.1647892-1-dimitri.ledkov@canonical.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231008040140.1647892-1-dimitri.ledkov@canonical.com>
Precedence: bulk

On Sun, Oct 08, 2023 at 05:01:39AM +0100, Dimitri John Ledkov wrote:
> No internal users left and cryptographically insecure. Users should
> upgrade to something else, e.g. sha256 blake3.
> 
> Some drivers have their own full or partial md4 implementation without
> using crypto/md4.
> 
> Userspace code search indicates a few copies of hash_info.h
> https://codesearch.debian.net/search?q=HASH_ALGO_MD4&literal=1 without
> need for MD4.
> 
> Preserve uapi hash algorithm indexes and array length, but rename the
> MD4 enum.
> 
> Signed-off-by: Dimitri John Ledkov <dimitri.ledkov@canonical.com>
> ---
>  crypto/Kconfig                 |   6 -
>  crypto/Makefile                |   1 -
>  crypto/hash_info.c             |   4 +-
>  crypto/md4.c                   | 241 ---------------------------------
>  crypto/tcrypt.c                |  12 --
>  crypto/testmgr.c               |   6 -
>  crypto/testmgr.h               |  42 ------
>  include/uapi/linux/hash_info.h |   2 +-
>  8 files changed, 3 insertions(+), 311 deletions(-)
>  delete mode 100644 crypto/md4.c

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt