Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp2718372rdg; Mon, 16 Oct 2023 12:37:18 -0700 (PDT) X-Google-Smtp-Source: AGHT+IERocaWgaaCLAmMHGGSGBm1n1+HxpD/c7FrAGaJC9wU09fxIQjx3S8LIipiWLX47BwMsecU X-Received: by 2002:a05:6870:51:b0:1e9:858e:ff23 with SMTP id 17-20020a056870005100b001e9858eff23mr80672oaz.55.1697485037778; Mon, 16 Oct 2023 12:37:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697485037; cv=none; d=google.com; s=arc-20160816; b=hYMQTTosP5ZZ/HDZPTEEiZnb0yYY2L/VPjb4E/d+mhx2WgIaikKynf01/JXbbFGqUv THb2/CZUg3w1A8plqz2pvSI8qbaODAYWakiLQ89t+BDA18G3enmRwPa0j1JpzrTSFYLs 8N5iuK9WBnlH7S56j1+W0F1Gg7M5l+JkQ8Q9Wmaxctn07T2dUctCZniT8/9yIYFHTQjf 7iOhXyj612gEITjAybCUwAkVIy53EPnILw/OSjWeprRrko1Mh8b/aAa9ckWAAuCao1CT fhiwpxwK32Uqx6QJesy+4b+vOTHjFEyFPTMqBIG3qdfm2xyWQzPqKw/VWrtbkHK9b7HZ TVfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=6paLYXnAOeT4tceyUbnVYWZhYebDk9ZkaF8qziV46gI=; fh=aBhZaqRVi7Qb571DtwwoVOUTG+EeIJ6szAVw5i0nvXk=; b=P+5rvGlBooVuABlXuNQDgzH0/dcxoVfFt+ReYOid8v2jVXw1/fRZRJO7Z6JVt9456H fDK4G0+TIupRJtMM0vjHMlhJMs7EY1MG/EJCuCdC9FgYjYklyY9m7WSprjYZi1qfmqCt s76+GIx3+NnSaBLFSNnZ2higcpqXUwh5FBCi3Mce8e5e5UTdy1d2W8hR3+v85GN9LHzv emC5ZtS/y3Bczu9vE4RUfgsN6CjVYQIJ+jjQSvrMwYdfNky3r8wgTQaPMKGHeapokXnX 9/k28kvxnrsUYj45b8l4abwnqJhsbGgTF1ozHG5wrgWvJtU7G/rgW5q8A+c7dPhwaxJw deAQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=D9fY2qXB; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id k7-20020a633d07000000b005ad91e8b473si1034pga.626.2023.10.16.12.37.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Oct 2023 12:37:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=D9fY2qXB; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 8A6248020D90; Mon, 16 Oct 2023 12:37:15 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232949AbjJPThN (ORCPT + 99 others); Mon, 16 Oct 2023 15:37:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47616 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229848AbjJPThM (ORCPT ); Mon, 16 Oct 2023 15:37:12 -0400 Received: from mail-oo1-xc32.google.com (mail-oo1-xc32.google.com [IPv6:2607:f8b0:4864:20::c32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C431BAB; Mon, 16 Oct 2023 12:37:09 -0700 (PDT) Received: by mail-oo1-xc32.google.com with SMTP id 006d021491bc7-57b635e3fd9so2471339eaf.3; Mon, 16 Oct 2023 12:37:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697485029; x=1698089829; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=6paLYXnAOeT4tceyUbnVYWZhYebDk9ZkaF8qziV46gI=; b=D9fY2qXBh5rY4rWj1hDfYnYdQwHDCFpqbT46Erk6nwdVaCUBW/1rfkD7yWPKdr062A +uBlyHtx+BG4fybriSnSqKiiK6/DreatAkt6ySIjlYiXtnfnxWE00OWEJLnRdYGb3DoD qXsXsxeOpqCqbFYQOXoI0wRJsOj2Iiqnh4jwqaY9zaoOEGJNjpR4KrMjT6kJjcArj+tr wDKFa4akf3C91dQVUuRTq5KIIbAkFca2I+ifwxNM59kQE1PDya+/YKDMWqGCgg3qXAgM 27L/G/A1GLADzJnetvCro0P9bA3BSIcmKQdiWRhCKpEp3gZgKUN0IbEnoEqczVoBE8DY ImjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697485029; x=1698089829; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6paLYXnAOeT4tceyUbnVYWZhYebDk9ZkaF8qziV46gI=; b=RgTZV3YTU7Ehlwr8LJBooAZkzicWmPo05TrDSzSZP3L4ec2KGPqimd+HAKsP0v+ZOn IZzPjXd9oXIZtwhYy/AySrZ6wW4fHDOYR/vHSPxcr+m0KwHzvrEDoqDFeY+dcGYTFDHA Dw0qIHkx6SM3XZ8DwC84SmrQ/rD3nso5o7OnPMava2pW1VoTkIe9w8pbWMExsYvV0hOG CN4h2meouGxFl7YDy8bKY0VB0pJhxd+a7VqdW8pr87JUhKJZNx/BqetZ9mR0bOg5XXrB 4aFbnCjFAi7TwU4yCIXUmSvLEjUqyWKJge8cvOwT1m0ZQNcvTIV+CVAaXn9qUjKCQyOW j2Eg== X-Gm-Message-State: AOJu0YzTAp/ZBPZkpCvk9LSuUTG989sB1XIxRRZwSbga+N29rf23e8xh U3S3NhEKo9B015eNy9zrba72+JabLdY= X-Received: by 2002:a05:6820:1503:b0:57e:1c6a:d551 with SMTP id ay3-20020a056820150300b0057e1c6ad551mr23130oob.3.1697485029043; Mon, 16 Oct 2023 12:37:09 -0700 (PDT) Received: from [172.16.49.130] (cpe-70-114-247-242.austin.res.rr.com. [70.114.247.242]) by smtp.googlemail.com with ESMTPSA id e18-20020a056820061200b0057b722edbd5sm1201979oow.1.2023.10.16.12.37.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Oct 2023 12:37:08 -0700 (PDT) Message-ID: <99eb29ee-3ebd-443e-ac33-32a8e4676afe@gmail.com> Date: Mon, 16 Oct 2023 14:37:07 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] KEYS: asymmetric: Fix sign/verify on pkcs1pad without a hash Content-Language: en-US To: Herbert Xu Cc: Linux Crypto Mailing List , Marcel Holtmann , James Prestwood , David Howells , keyrings@vger.kernel.org, Jarkko Sakkinen References: <1d22cd18-bc2a-4273-8087-e74030fbf373@gmail.com> From: Denis Kenzior In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Mon, 16 Oct 2023 12:37:15 -0700 (PDT) Hi Herbert, On 10/16/23 03:35, Herbert Xu wrote: > On Thu, Oct 12, 2023 at 10:08:46AM -0500, Denis Kenzior wrote: >> >> Looks like something took out the ability to run sign/verify without a hash >> on asymmetric keys. > > Indeed this is what it was. Please try this patch. Thanks! > I can confirm that this fix does make all unit tests pass again. Feel free to add: Tested-by: Denis Kenzior Regards, -Denis