Received: by 2002:a05:7412:f690:b0:e2:908c:2ebd with SMTP id ej16csp808773rdb; Thu, 19 Oct 2023 22:52:09 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHIgU80w/qjJQr+/ssEcpvw/ge94qS6s3Ry/+oCfcftmVUSqTdeThTCI0SgH33RxMnmsTMg X-Received: by 2002:a17:902:e1c1:b0:1c9:e774:58dc with SMTP id t1-20020a170902e1c100b001c9e77458dcmr965839pla.7.1697781129136; Thu, 19 Oct 2023 22:52:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697781129; cv=none; d=google.com; s=arc-20160816; b=Epj3YEIath6PgRDGrJB4KuG2BXtAp8F3AiFdDb7qdK7S8tkEnAPOeTpE6/fytndRjJ M+litkgI82CpCGivblzVZbyz0o7chDDSYbqfHhnsNru/5JJUFEfIPltP0EOH9Zylxdsr MuRA8l7VQeLKYqDfollUtCdjmeWSdce59FJZb/mN9NkHt0+W2yO6Kc2UCX5afuScYXLU Yzb39vqxQODAi2n+E2dDhm+ZOW1jlxi+p7UsFYYjd0HpXPntjUK4pn4sQbLscmVmp553 9ChhFwui8JvZFQUoR5a5IXCTnZEZU0i59p5H41pm4XsqxLoftqNYnI7/y3tMovT2pjIJ C+Zw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=1t0JLJyVirV5HnfWgMzyt0rdbWovlM11aAY2NHx1qBY=; fh=GCHnNZaqG42JzZ/C8fBxn/7RZdwt3sOV12+K6gLWRHM=; b=QZPKPlVXmdIQVH2gbs1HrnrE+k/hFExbEc6QsTJZhlOQSXBg1U1skxLzlzSGoQwU/u MmE+NA6D8YpjdsC/KziXXRcOCpXdrWUMZCpQHF0YvrkBI+hiwZSQYt51ir+vOTD2ayMl w+nx2yDETkNNfX0nseD8+52WGvf0Qf077bgRDvwrztP4rwgEL9xXdBwdLccha3KMP6pR cyKM98atGujLp/6XfOGjEuuOnRER3N1cGVtl0qb5M40To6U9jCQXffkIN/lWYH8IAwgR 5mmgS7iwPPb1QEp/uYwKArN3SckQX9l3O/2W2WmHnzg9NcRpq44djauxhFydrgayrjvd AZ4w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from howler.vger.email (howler.vger.email. [23.128.96.34]) by mx.google.com with ESMTPS id b4-20020a170903228400b001bdad5f0f0bsi1114062plh.543.2023.10.19.22.52.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Oct 2023 22:52:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 987C88083A84; Thu, 19 Oct 2023 22:50:35 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235599AbjJTFuf (ORCPT + 99 others); Fri, 20 Oct 2023 01:50:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48742 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233497AbjJTFue (ORCPT ); Fri, 20 Oct 2023 01:50:34 -0400 Received: from abb.hmeau.com (abb.hmeau.com [144.6.53.87]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1312BCA; Thu, 19 Oct 2023 22:50:32 -0700 (PDT) Received: from loth.rohan.me.apana.org.au ([192.168.167.2]) by formenos.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1qtiOV-0097Rl-OJ; Fri, 20 Oct 2023 13:50:00 +0800 Received: by loth.rohan.me.apana.org.au (sSMTP sendmail emulation); Fri, 20 Oct 2023 13:50:05 +0800 Date: Fri, 20 Oct 2023 13:50:05 +0800 From: Herbert Xu To: zhenwei pi Cc: mst@redhat.com, arei.gonglei@huawei.com, linux-crypto@vger.kernel.org, jasowang@redhat.com, linux-kernel@vger.kernel.org, Halil Pasic Subject: Re: [PATCH] virtio-crypto: handle config changed by work queue Message-ID: References: <20231007064309.844889-1-pizhenwei@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231007064309.844889-1-pizhenwei@bytedance.com> X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Thu, 19 Oct 2023 22:50:36 -0700 (PDT) On Sat, Oct 07, 2023 at 02:43:09PM +0800, zhenwei pi wrote: > MST pointed out: config change callback is also handled incorrectly > in this driver, it takes a mutex from interrupt context. > > Handle config changed by work queue instead. > > Cc: Gonglei (Arei) > Cc: Halil Pasic > Cc: Michael S. Tsirkin > Signed-off-by: zhenwei pi > --- > drivers/crypto/virtio/virtio_crypto_common.h | 3 +++ > drivers/crypto/virtio/virtio_crypto_core.c | 14 +++++++++++++- > 2 files changed, 16 insertions(+), 1 deletion(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt