Received: by 2002:a05:7412:f690:b0:e2:908c:2ebd with SMTP id ej16csp809477rdb; Thu, 19 Oct 2023 22:54:19 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEe9vatb3Es4IQrrZ3lnEQXaL2899pz4xwt25Uxc+2kD2b5VZrNwrKhqjfNDmKBgE9/BkrZ X-Received: by 2002:a05:6a20:8f01:b0:15e:2d9f:cae0 with SMTP id b1-20020a056a208f0100b0015e2d9fcae0mr987784pzk.10.1697781259475; Thu, 19 Oct 2023 22:54:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697781259; cv=none; d=google.com; s=arc-20160816; b=CRHHov3ubYUAISAB9lsV94OgSZ34c/JprEj4suq4VnGLKzLRiXTv3pvecEQANRhglM wavZFgVw9qG4VgNIm+O/MI2y+ZOWfGd7bg/iTaF21lQ4crytkjqmWY+f2D6T5+lMSGHE Cml/YU7ylw4bWfkRoeuhs76BBgds4x2iAyeH5zxKFYTKyOKzr/0Ecth9txw7gE5ROf41 XuDVyLM8DK2bchFsSe1wZz5OL11luZnuYtoOFoKR7bKqOkcJjdD4pSBDZcpJYkMWnXRW E80BUkb7S1ACN1CPWdN+7eL83Jfyup8svvwbufDnztnLN1qiRdObr0XPkUJLOo+YNoKZ eHBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=Ec1sitsdfmHC9RBwuHZBYBmtHpQvW20dP5t+Sw2i8/o=; fh=rxCGSCS8tVzWrKL9jG7MggPnRL28YELQ6sZuZOrBzU4=; b=NrTE9MU2fMz8vBPwG9X843hzbFfnhanqiuPHb0Fe96ijrfC8OcAHyyRPd8HML+Csb7 oJ5EgIQTqii3SGXwasSGFZqqE9vneGkiL4Y9fAMLYaBH22CEYx0V309Vg9H5acx7ro4E j7hmwulRQwsvGCsW5+u5ibtu5ir5K/duUwJ/h3GXvO00sR0KNqWP5OZUOZb5/l1WkZP8 YeOJrkNPYkGqW7H84bOhWn5pg6mDpTfHMa1hR54IB8i7vDBwBA0CarADs5DGNFYUvIT+ 0ch+V35FpICNGRKARiu75MHtKia/791MmDX0qpJeJKA7eS17c6UgrZNe0UQ/SORUdoLA AjkQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from howler.vger.email (howler.vger.email. [23.128.96.34]) by mx.google.com with ESMTPS id l1-20020a170902eb0100b001b878f9e11csi1100234plb.54.2023.10.19.22.54.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Oct 2023 22:54:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 9D96782DFD0C; Thu, 19 Oct 2023 22:54:14 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235599AbjJTFyO (ORCPT + 99 others); Fri, 20 Oct 2023 01:54:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39880 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233507AbjJTFyN (ORCPT ); Fri, 20 Oct 2023 01:54:13 -0400 Received: from abb.hmeau.com (abb.hmeau.com [144.6.53.87]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 20E27CA; Thu, 19 Oct 2023 22:54:12 -0700 (PDT) Received: from loth.rohan.me.apana.org.au ([192.168.167.2]) by formenos.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1qtiSV-0097ak-Ff; Fri, 20 Oct 2023 13:54:08 +0800 Received: by loth.rohan.me.apana.org.au (sSMTP sendmail emulation); Fri, 20 Oct 2023 13:54:13 +0800 Date: Fri, 20 Oct 2023 13:54:13 +0800 From: Herbert Xu To: John Allen Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.lendacky@amd.com, mario.limonciello@amd.com Subject: Re: [PATCH] crypto: ccp - Dump SEV command buffer registers on SEV command error Message-ID: References: <20231010204432.899126-1-john.allen@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231010204432.899126-1-john.allen@amd.com> X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Thu, 19 Oct 2023 22:54:15 -0700 (PDT) On Tue, Oct 10, 2023 at 08:44:32PM +0000, John Allen wrote: > PSP firmware may report additional error information in the SEV command > buffer registers in situations where an error occurs as the result of an > SEV command. In this case, check if the command buffer registers have been > modified and if so, dump the contents. > > Signed-off-by: John Allen > --- > drivers/crypto/ccp/sev-dev.c | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt