Received: by 2002:a05:7412:f690:b0:e2:908c:2ebd with SMTP id ej16csp912489rdb; Fri, 20 Oct 2023 03:13:42 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGyk4dMwmUisgK4MIv13H60Z2iDdwjrQ68TZp5bvBBi9yd0+quYbpZf1lD/riKDmjWtC/Ef X-Received: by 2002:a17:90a:1dd:b0:27d:375d:c16e with SMTP id 29-20020a17090a01dd00b0027d375dc16emr1245642pjd.42.1697796822540; Fri, 20 Oct 2023 03:13:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697796822; cv=none; d=google.com; s=arc-20160816; b=X4JtS3GKxaVNpA3pzhyHElvsEvRZPtk/af6cCKIEc6u/P6Rnb8blCtSCjdSLsehsnJ tIp0PdL4l31iScE6fSvVF/iEQHydy7zfWw6dWwdLv0rOillQMCpQZ0MxBpNEakHkSQX1 A2v7kgo2ObrkkveY3gSPx01GuAfAEmfFl3Oebu9nxgk3L0XM44RlZIK759SSmkx68dBe R9oe6m/ynXJPVestZn+e9dqxKA56o+rTPKPSIMCP2X/oFdrnE7v9uQubhn33RuTf5Ugk tBjAeSE3a4JL7jnzVaTZNMiKjF4R8JsSD5p/2sV2FfZPk7UDm3m5SDCq7RSWrDkrX18i lU6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date; bh=i0p0ICgIFMH23OS3ChKD2cVHg0tKFd5kx7uPrsm8E+Y=; fh=KwtFcDHgbzLu+eU6UBiTTebq+r3vGyRy+FRju2W9wd8=; b=D4ygrqtq/IjF3zCfSakaoXJS5GniP7+E7YqYYLRvlbjt7EFNGRMt0NiolnjJ/JI6S/ GmXyHpNh0Hvx7WBWY1QF+PcYkfv54TBM8rMUqh/Sbid1H9+z916S/ieaPwS0Af3LIPz1 StxJvlQshV4UCc7KLXagjmBM6M+K4OWGUJuex2KX/9dH+Sruk9Ea1+J4zhBiw9XB0TjL 8wAuXRcgUW88slfxAaln9nFSnkVj0VCi8FzDgPuzf581L80euMSUkh2NgHrLfA7n6oZT SYF1E/9XHCrUcb3f3otn9x2Mza6/G5TOsFMy4haYkylOqeXL5ZQtFzn1Asdc8JqrLmJ/ Nndw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from morse.vger.email (morse.vger.email. [2620:137:e000::3:1]) by mx.google.com with ESMTPS id ls11-20020a17090b350b00b0027d09bab505si4388159pjb.66.2023.10.20.03.13.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Oct 2023 03:13:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 48C45807E44E; Fri, 20 Oct 2023 03:13:40 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1376722AbjJTKN3 convert rfc822-to-8bit (ORCPT + 99 others); Fri, 20 Oct 2023 06:13:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50984 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1376842AbjJTKNN (ORCPT ); Fri, 20 Oct 2023 06:13:13 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id A71B5D72 for ; Fri, 20 Oct 2023 03:12:39 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3EB082F4; Fri, 20 Oct 2023 03:13:20 -0700 (PDT) Received: from donnerap.manchester.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A0FDF3F5A1; Fri, 20 Oct 2023 03:12:37 -0700 (PDT) Date: Fri, 20 Oct 2023 11:12:35 +0100 From: Andre Przywara To: Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= Cc: Herbert Xu , "David S. Miller" , Corentin Labbe , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Jonathan Corbet , Rob Herring , linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, kernel@pengutronix.de Subject: Re: [PATCH 03/42] crypto: sun8i-ss - Convert to platform remove callback returning void Message-ID: <20231020111235.413fc617@donnerap.manchester.arm.com> In-Reply-To: <20231020075521.2121571-47-u.kleine-koenig@pengutronix.de> References: <20231020075521.2121571-44-u.kleine-koenig@pengutronix.de> <20231020075521.2121571-47-u.kleine-koenig@pengutronix.de> Organization: ARM X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.32; aarch64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Fri, 20 Oct 2023 03:13:40 -0700 (PDT) On Fri, 20 Oct 2023 09:55:25 +0200 Uwe Kleine-König wrote: Hi, > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is ignored (apart > from emitting a warning) and this typically results in resource leaks. > > To improve here there is a quest to make the remove callback return > void. In the first step of this quest all drivers are converted to > .remove_new(), which already returns void. Eventually after all drivers > are converted, .remove_new() will be renamed to .remove(). > > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > > Signed-off-by: Uwe Kleine-König Reviewed-by: Andre Przywara Cheers, Andre > --- > drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c b/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c > index 4a9587285c04..f14c60359d19 100644 > --- a/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c > +++ b/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c > @@ -908,7 +908,7 @@ static int sun8i_ss_probe(struct platform_device *pdev) > return err; > } > > -static int sun8i_ss_remove(struct platform_device *pdev) > +static void sun8i_ss_remove(struct platform_device *pdev) > { > struct sun8i_ss_dev *ss = platform_get_drvdata(pdev); > > @@ -921,8 +921,6 @@ static int sun8i_ss_remove(struct platform_device *pdev) > sun8i_ss_free_flows(ss, MAXFLOW - 1); > > sun8i_ss_pm_exit(ss); > - > - return 0; > } > > static const struct of_device_id sun8i_ss_crypto_of_match_table[] = { > @@ -936,7 +934,7 @@ MODULE_DEVICE_TABLE(of, sun8i_ss_crypto_of_match_table); > > static struct platform_driver sun8i_ss_driver = { > .probe = sun8i_ss_probe, > - .remove = sun8i_ss_remove, > + .remove_new = sun8i_ss_remove, > .driver = { > .name = "sun8i-ss", > .pm = &sun8i_ss_pm_ops,