Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
Date:   Fri, 20 Oct 2023 13:58:38 +0100
From:   Giovanni Cabiddu <giovanni.cabiddu@intel.com>
To:     Mikulas Patocka <mpatocka@redhat.com>
CC:     Herbert Xu <herbert@gondor.apana.org.au>,
        "David S. Miller" <davem@davemloft.net>,
        <linux-crypto@vger.kernel.org>, <qat-linux@intel.com>
Subject: Re: [RFC PATCH] crypto: de-prioritize QAT
Message-ID: <ZTJ5fngubmYWgt8r@gcabiddu-mobl1.ger.corp.intel.com>
References: <0171515-7267-624-5a22-238af829698f@redhat.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <0171515-7267-624-5a22-238af829698f@redhat.com>
Organization: Intel Research and Development Ireland Ltd - Co. Reg. #308263 -
 Collinstown Industrial Park, Leixlip, County Kildare - Ireland
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?0VdRQddUYEbl36TrJ9O+q3YSzPSwtRgHoZz2488h9kjgA0Fl/n5INKusDN0b?=
 =?us-ascii?Q?IfLU0rL8dfuudtdcPzN9KfPBilmM4HTpMGRSOuLfMp7vJvaXugUMGSs0QIDF?=
 =?us-ascii?Q?VB97znVBroCjUnmKnEDUq0E9+yhi4R+qRt3jdyFp6JvaQqlylW6rJR72vkBG?=
 =?us-ascii?Q?diJIvSQEf9/BxivALy8viIgJxY01Ic3l1Jc+r5/ncUPyOvNNB9JJvu+266GZ?=
 =?us-ascii?Q?CvrOUpE2PyIbBU3kzL2tM4bPHyT3tOkOEfRU3V+ZL+okXsd/pboCzY2v3bF+?=
 =?us-ascii?Q?DSf5ja1PicH1j3JXQWYU7U7LjoynYUlBk3r5lnQocDuEkndxDKBEukDcpHUP?=
 =?us-ascii?Q?1zgcgJ131oNvTX0vwYUvv3nkk3cTqtk+IU04gTAQu8S6799ou//O7nl5Q7ub?=
 =?us-ascii?Q?pI7cFKKdh96O5r3eUzdml3tzU9L5xPJRoQLGE+o72B4vRkTXNej3jLnrnv0C?=
 =?us-ascii?Q?zx7BCEz4HLG5S51cy+AnvKQuHCaEia6YgeY6RxMS21k+MRGWmqfDWUVam+Up?=
 =?us-ascii?Q?EDcL+2dDdwA87XADQ2jatBCJFq5hK3fIa+eDQiiB0iQqwju6iuMbK0sDPqCX?=
 =?us-ascii?Q?U8cnHz4sL5yAo9s2qUVZwt+TS0+XiUJ1NN9xteq3XPGqsyB6b4jDtb3aORLi?=
 =?us-ascii?Q?5gVrH2mCg3NS/K+d6F17q6NauXnoyFjko/J9vPGG21f9nNqWqmvqgdHKdTXT?=
 =?us-ascii?Q?XYHsewaoBoMlRNSwSduMDfn5Lg56kbQp3Ln8EuDPnkRf62Um1iGIPphLod3v?=
 =?us-ascii?Q?FdWfadVfM7PXOjKohNjU+jBcsREmq0G5s8Zqpb2PPtqCYTd+ipQIk7sZPfKX?=
 =?us-ascii?Q?y1km+Be/GtpsfuG/EOChlkNX0pKXMJG5WV6F9cwF+QLtU+RVNUFGTc/DqOLW?=
 =?us-ascii?Q?Zl920G5EaWF6qC4s9m9hdnqmltB9OG5LPOBK+bACaulvlQAeCqtQ0sZ6uu+p?=
 =?us-ascii?Q?vZBvQCmp4SXG5RH5ZwWb0B+voPZZZjCKzdNXnz73qxDVYm7SOzvE7Ic7K7NK?=
 =?us-ascii?Q?qrC4bN9YPCuJX+rBOvi8TAbycwHZ5ZdK6fxnhNXeiLN8wvPSS3pfDlQ0jDDQ?=
 =?us-ascii?Q?YU5KTQEEXyIas9P9TQAEtAzCxOdxatPBZKPhFo42Uu7QkcAitlsht+IcO1Vt?=
 =?us-ascii?Q?mfWhe+RcCSrM/7cziUecdn11p+5c4w+LQVNlZIfToRpycl3or6quYTxaPf8l?=
 =?us-ascii?Q?SFrtyvD8dqSxhN6J6VYbM2PkMPk3NZ3Y3Pb/qQkPt4Kh+qU9Jm0Vq/7kVQ1s?=
 =?us-ascii?Q?a9Xr+8+BwZhsnMBSFt/oMtFVvGuURrNorCQnMXqO7xDAVw+ln7ssYVfMR/7I?=
 =?us-ascii?Q?VlLgA4lubLyfPSqaYjy7GVUn4GDGhf+ROY6FssI7YQnDwKjrdC0mxVUG3YwC?=
 =?us-ascii?Q?wxW65J5rxCOXVnpg2sTspZ/dVg2OS+Ti9nLPM5lbbodn9rm0OpncaWHOSCpx?=
 =?us-ascii?Q?BPhHqdrWpq9ynq9Vop4awYlqZv76KWgPqPB6CqQTHt5qvJafyl8ilEP0P6a3?=
 =?us-ascii?Q?EVkHU6U/VAnn+ek4tHk95boP58wHiucpF+OZcpVJiVq+cw0polxtt6WY3PDH?=
 =?us-ascii?Q?5yiJPGioz7GsDZ7fxYSO0fuSbYAEHLa1j29XyjGl2b1UKfBh9Cq+JfAgIspU?=
 =?us-ascii?Q?0w=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 9eb9c1cf-27e1-4055-446f-08dbd16c49b2
X-MS-Exchange-CrossTenant-AuthSource: CY5PR11MB6366.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2023 12:58:42.8247
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Es7V4/tdECHe97+cjD9HoXGQNUPeMOq5TQ8cwcsWyQo1l6GirSoh53GcGxp89wA7pUPjf2Q/3cnffn0LDUmG80rghmjux1oDl24FGqxzXHg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4717
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Fri, 20 Oct 2023 05:58:58 -0700 (PDT)

On Mon, Oct 16, 2023 at 01:26:47PM +0200, Mikulas Patocka wrote:
> Hi
> 
> I created this kernel module that stress-tests the crypto API:
> https://people.redhat.com/~mpatocka/benchmarks/qat/tools/module-multithreaded.c
> 
> It shows that QAT underperforms significantly compared to AES-NI (for 
> large requests it is 10 times slower; for small requests it is even worse) 
> - see the second table in this document: 
> https://people.redhat.com/~mpatocka/benchmarks/qat/kernel-module.txt
> 
> QAT has higher priority than AES-NI, so the kernel prefers it (it is not 
> used for dm-crypt because it has the flag "CRYPTO_ALG_ALLOCATES_MEMORY", 
> but it is preferred over AES-NI in other cases).
Probably you can get better performance by modifying your configuration
and test.
From your test application I can infer that you are using a single QAT
device. The driver allocates a ring pair per TFM and it loads balances
allocations between devices.
In addition, jobs are submitted synchronously. This way the cost of
offload is not amortised between requests.

Regards,

-- 
Giovanni