Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Date:   Mon, 23 Oct 2023 09:58:29 -0400
From:   Daniel Jordan <daniel.m.jordan@oracle.com>
To:     Herbert Xu <herbert@gondor.apana.org.au>
Cc:     WangJinchao <wangjinchao@xfusion.com>,
        steffen.klassert@secunet.com, linux-crypto@vger.kernel.org,
        linux-kernel@vger.kernel.org, stone.xulei@xfusion.com
Subject: Re: [PATCH v4] padata: Fix refcnt handling in padata_free_shell()
Message-ID: <nqc5zfj5hjgk476o4iyehhmyadxvzjkz76ama72fzaasxjrpk3@liejkxexgg35>
References: <202310160854+0800-wangjinchao@xfusion.com>
 <ZTIKP94KBuqhyj/k@gondor.apana.org.au>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZTIKP94KBuqhyj/k@gondor.apana.org.au>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?MsIgK/xJHmyRpUWPTp8PdGjwAp9GwxfdHe6bicPnJxX2jcmKIOczivRmj6m0?=
 =?us-ascii?Q?OEXm3pR0vaSKYdkwdzWpWctv54SjoRkku4qloNLTuAbPmkX87SILVDtfMZzi?=
 =?us-ascii?Q?m2eUoWd2CpV5H4XFDJietFkCggDbemdtoHrqs6+mKwhAcH6m0sYiZkd2UcLt?=
 =?us-ascii?Q?SQmL69fRYdiP4r5DFullF13Lsl5QB8fjIsWC2eyVfO3dAfoZIcC8CxgwThkb?=
 =?us-ascii?Q?lVKHKucwsLk93lnx98gnypLWRZNp0UI1PvJrfQj6K5bwFA1L8wvutZeFh9mm?=
 =?us-ascii?Q?iiUwZmd3WFX951P5rXYOR2pHR3FYh84n2DY/55eqka5C7xEDAO2JC/GIEDZE?=
 =?us-ascii?Q?11DcCcASQ5gyMESmwaaQxvED8WmKcu+gUEK96EaubOHc012CpvdIlX6g31/d?=
 =?us-ascii?Q?nEz6wJaaYmr/r94rqBrb/2pJDOw/ZJ57q64s4g3lOjugWGnKzRIqTH1jjiL9?=
 =?us-ascii?Q?Kxz0Nn2aEW8hibjad4U2TzVw6oB8oXKd5a18PVB9Xf7G21ZlJfbjGl59w/Kg?=
 =?us-ascii?Q?KC0X/4U1ZdAzO5qxedEHI19QJdqCukS92+sSfVL7vnKOfWip5u4k2Vq/gC5Q?=
 =?us-ascii?Q?+6XHvPAe84WwlpKYfCftGoPcziR+mrssHeHdreOmbNeMecLcrNAoBD/AYSGB?=
 =?us-ascii?Q?faNINcRgohLz4KMQSSyYVOMqcIj+bLV8T0dGNK+fxKc/RJ1c9R1Wst1150+S?=
 =?us-ascii?Q?aIRMuyPrSSPa9Q3STfFLx5vTT2s5GTQoUO8dVJmMX1ShIUjW+3G3RT4bLvcJ?=
 =?us-ascii?Q?u9+sL1GqIGufIPLbt0vHRLhZhujaaA3aBfwWGsBTpOJGLUDCtdyRJgMXsyJO?=
 =?us-ascii?Q?kl1+1q0yXkDpAoVRvq77Aj+ZOQN7dFbeFDMlvExgbeJjvQurHsbX6kfC3cgn?=
 =?us-ascii?Q?Qe3F0ytKtMq2tCd+/hKjZjj/2qhpl4C+l9Lm+tzu0F1acblhsLlXdEUPgIxc?=
 =?us-ascii?Q?NjfXqDKJzGbAyHdlGPWUagPk6sW8Rh5xOVX9i7wtA9oHyajITDHcUz4DWCb4?=
 =?us-ascii?Q?o4z1Ejj+qxkjdCPtLQMc3UdCJXNK/SCf8KGgVXBT/sK7fQ04bAl6GkF5uJlO?=
 =?us-ascii?Q?KHlSjiRG9ZKAlBWjwauUSiYXjc+V43MRx1/R8ql09YdZhDxISqtJwxacmINP?=
 =?us-ascii?Q?L+KOci02naSP6IJMTD3F6s88DN1y4YWgwbHi/Bx/s/M9mjCeS1cl7Y/BtHLG?=
 =?us-ascii?Q?NtE4rMFkxanK50QJ2orbs4CrHt5Odotikt+ZJm1b2sWLO3YTuRy91yj4gTRd?=
 =?us-ascii?Q?6/jC113720yuZXGtpL9vyzKAFhJZmfAI2Yh/IVV+OCZBytHYX6HjyR/MoZzk?=
 =?us-ascii?Q?HqnfqwQHBfiegam/bfVrio6OGFfat/a2AvcjPSVj4zmB3xPKMdAaI1/yqr8A?=
 =?us-ascii?Q?lfbnBjA3pVxyATxGpy9aAmsjvfdFUxed4jLJXR4nUwus85+BJ+XPccWwmd8x?=
 =?us-ascii?Q?UCV+0zA9Q2E/uPb0TOuX+z+Qy2i+IyOkxTHqkaJ9JDMnR4G7t8+t0FhUrus2?=
 =?us-ascii?Q?Op2l3wKBIgqUAB5LEh/UDz03gI1X5oSuLdC7M1jLfEdngVRjudITxXlgXCHT?=
 =?us-ascii?Q?gw683rj7EPDyC29DnkJqF3Q51IlGBWMT5VHgJ5z9v5Evb42pwXAl6PQBMFLi?=
 =?us-ascii?Q?pA=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: iObDny2ZKWvZlo2KWNCSbE0gqtDoHowgxBQGJShRZx+s2AVBTOnXNMON9lqTg2LTILnrCzzMn37JgAPB/py3QogMuDVISn0OMXhw+Srk/aanS/B+WN3gz2Bps+fAH6ESlpWx4HM5N4A/7xwRBK/dGSUDE4NPebBl3hXkBc1/auIPXvcl4FNI2NxhywjTQYx8V1WkEWwYB3yu0wTDLwRMj6yK0EZoUKUzYarRhMwdO3d9vnF/sHxHGceFVj8gOTUV6djuzpxHJ7sDeuiaUIXDKqrMVSiSXqufr8lPnqx4PXX0Ie2sLk7cdC2Zmay9NIkZqf0kLIOR+T5PWOx8nR6t5M+9uE/WXz6zm/JFALegAUhVmpoM8x3HypoyGJ8683H1/+4uW+xnB3aSSZLBG+mDxOmT4vQvJmy8WeTMIsFujxKpPcZh1SwMKYJYs4nbAqIXaz03s8EHaIWbl0TtvNPQ+K1utaGaJs1HEwKDu6zKDR0/9P9xa1O+eyxN4tuQKXaPXq+cCRFlDD6Ieu4ZeIGpL5MaB0Ibq07/boUm7IrJKK0G4RvGAb6NFhfYlWD1H7pliytBBopjnBY5Nm9+kMSQIL3hPadwRdRvCyIClGOr75P+WN27FqR51O9davQMXU5Z/OKgB7CSYQQSUNFYaEn/bds6IDSrVIIFbDlxbXKliBTiep48m/eb4zU4m3+40bjpzm3onf7zDhJYPjZSCGWrpl2aLrGTdo13s8//UX6uRTIk0xzVf0hqo2fZXzzojsHf/tihwUYOBvBGQBiAfgyfuEWiRN4iz68mOFzLedzMCLDo76XdCWZrG5fd8jllxrX7bSrB6v5Z28F8wiVEicoZVzFZa8ozmre4odgQmpQlMh1cuEM0lY9+4PJlJ9eW+k0A
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b836bcd8-3c3b-49e9-1948-08dbd3d02533
X-MS-Exchange-CrossTenant-AuthSource: SA1PR10MB5711.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Oct 2023 13:58:33.6026
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Rgxt629Nq80tjikfrsjCpcahkI/mUk/Ni95v0j0VAydTOv92MmEwDa8O19KKaR1+VVeyJ9mErHr62/AbGexK1lHwzEScdLxFCpRUm+DfQxc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB4413
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-10-23_12,2023-10-19_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxlogscore=999
 bulkscore=0 mlxscore=0 spamscore=0 malwarescore=0 suspectscore=0
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2310170001 definitions=main-2310230122
X-Proofpoint-GUID: ALoZDMAd3qPrD4GekJ7wCwUNfNFnFVoq
X-Proofpoint-ORIG-GUID: ALoZDMAd3qPrD4GekJ7wCwUNfNFnFVoq
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Mon, 23 Oct 2023 06:59:01 -0700 (PDT)

On Fri, Oct 20, 2023 at 01:03:59PM +0800, Herbert Xu wrote:
> WangJinchao <wangjinchao@xfusion.com> wrote:
> > diff --git a/kernel/padata.c b/kernel/padata.c
> > index 222d60195de6..73108ac75f03 100644
> > --- a/kernel/padata.c
> > +++ b/kernel/padata.c
> > @@ -1102,12 +1102,15 @@ EXPORT_SYMBOL(padata_alloc_shell);
> >  */
> > void padata_free_shell(struct padata_shell *ps)
> > {
> > +       struct parallel_data *pd;
> >        if (!ps)
> >                return;

The \n after the declaration disappeared in this version but would be
nice for consistency with the file.  Maybe when applying, no need for
another post.

> Daniel, could you please reconfirm that you're still with v4?

Yes, regardless of above,
Acked-by: Daniel Jordan <daniel.m.jordan@oracle.com>