Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
Message-ID: <b743d759-8f6b-b4f8-afc6-d8f11a5562ff@amd.com>
Date:   Thu, 26 Oct 2023 09:53:50 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [PATCH 0/3] Introduce DMA APIs to allocate and free TEE shared
 memory
Content-Language: en-US
To:     "NK, JESHWANTHKUMAR" <jeshwanthkumar.nk@amd.com>,
        Sumit Garg <sumit.garg@linaro.org>
Cc:     john.allen@amd.com, herbert@gondor.apana.org.au,
        davem@davemloft.net, jens.wiklander@linaro.org,
        jarkko.nikula@linux.intel.com, mario.limonciello@amd.com,
        linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
        op-tee@lists.trustedfirmware.org,
        Mythri.Pandeshwarakrishna@amd.com, Devaraj.Rangasamy@amd.com,
        Rijo-john.Thomas@amd.com, nimesh.easow@amd.com
References: <20231025065700.1556152-1-JESHWANTHKUMAR.NK@amd.com>
 <CAFA6WYPKXFftMzqJ4GnXT-zqu21_Jzn8aKti_wU-pQ4KpEVNrA@mail.gmail.com>
 <4a261870-03e0-49f8-b968-4cbcf646d9eb@amd.com>
From:   Tom Lendacky <thomas.lendacky@amd.com>
In-Reply-To: <4a261870-03e0-49f8-b968-4cbcf646d9eb@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aERINXVmc2FEZnVtbEMwQy9qUkpPcGpSTi9jbFlCZnNTc0V6UllTMUdaMDVZ?=
 =?utf-8?B?UENUMjExSDJ0S2RLMWF0WXdkcmZ4UWlnaFhianZTdkVxQVpQM0FKeUdqSm1a?=
 =?utf-8?B?UmxUK1lrWFR3WUR5dEg5eHoycDFJWmFmcGlOeTc3SGpldys3OGtMWXA3MjJL?=
 =?utf-8?B?RDFkdVlMTUhEaXA0aFhwZnMzbVlwL0xOd1VSa245MXlEa2U5RVVwdjVYTFcx?=
 =?utf-8?B?UnFJVVBjM1EzNXk0aVhVS0c2dEJ0dU9Zci9EWmkrR3J6eFo0emFnQjVVUERo?=
 =?utf-8?B?WTdYVXZ1Vk5iNGw0dUE4TCtBVFJrSmtpVjk1NDFhcUY5VkQvckdDbTgwT1lJ?=
 =?utf-8?B?UGZITWxNVmYrU29YWGRLUjVNL2RjRDZNc08rak9YUlN6K0FvUEVXRjlTdmZK?=
 =?utf-8?B?L0hrbDVwSXdkaHNWVDgxYmN3c0w4NVhpZkx1Uk85WTdlbXpBSVpNSFhzbWhR?=
 =?utf-8?B?YTFjOWlSTDZOaGcvdkE2VEFvVEtwSS9NUm56b3NYdVJXSGU5V3V4Wm9CMVlW?=
 =?utf-8?B?dmcvSmpjV05uK21SOHB1bHllL3JQM1FmR243V0IyMmF6NjcvdlFwMTc1am84?=
 =?utf-8?B?VFdoMmZHT25RYkVrRU16dUo1empWUGM1cGQrUmk5WXl3YVRHTkc0R1hDRmVG?=
 =?utf-8?B?dWxSZ0hReEpaZ3pvWktuVVFadlFwclJOemtGQ25wcXdTdzVTendmc3pEcTk4?=
 =?utf-8?B?TG9JK2JBVzN1MkxpaWVPVFdkeGVrWWNra2JnTlhodXhCcVM5clhFbFY5K3pM?=
 =?utf-8?B?ZGlDTzhqQXArbWl2UEVtamJPaUlXK2FqRG5jZXNzTFBubkxHTHdaU1JId0xU?=
 =?utf-8?B?YmZ0d1NkbkN2Nkd6RU5KcE5uWHhSTDhGaHhTZUhNbUM5SXlVcFhFNlNud1Vv?=
 =?utf-8?B?dWp1R3BjWkk1dC8zTlhUVU53SWVRNk1oVDRCdFJSMFFRTlEwemhranFlVUs5?=
 =?utf-8?B?NGg5YVdEdzAwVkJWS0crSUR6NEh5WUMrdHRuMnNaNXUyNXZRTFNZZTJYOWls?=
 =?utf-8?B?Sm42eDFCcC9CMitIdjBZYVo4YlE3WDBoR2FiZ2Y2dTVwZTNpcU1KZUQrVXJX?=
 =?utf-8?B?bjVoNlozWnRYN0hZbk5MQ1o0bDNPSGhtNWI3cW80N0VEM2o3ZG1QM3JWTGg3?=
 =?utf-8?B?cEowS0lGUCt4dWxyWlFhMXlxSGxUS05SRHlzRGNYcFdQWXZvSzIvdm90cXZQ?=
 =?utf-8?B?WHhKVlRmY2NFNlRmTlkreXhzd3B6TUNySHNVOXdxZHR2ZU9zTEt4amd0WHRu?=
 =?utf-8?B?bG9MalBxSFVLdytwdGhERytFd3paZ2tCZUkyUnFzN2xIbGtsVzNLdkpCQ01D?=
 =?utf-8?B?WWUrNGtZY2xwdk1OQzB2OWw3akhITTBiNUV5RjlsVXRSdER2ZHNpYUNrR29r?=
 =?utf-8?B?d0FBa3Q4d05VM3FVNko4ckhsTG5ZTnpOWXpCNlM1OGFwLzlwWG8rajhabGVZ?=
 =?utf-8?B?UVUzRFRqM29CVkhNUU8vUk9kMzlLRjAzMTJxWG84VlczdU5TU0RWNWdqUlFP?=
 =?utf-8?B?QjdrRjEzYzFOTjcxSDV6V0Z6K1hsWVpxSFd0c1pqSUR0bUxBYzZkK2VnNlFL?=
 =?utf-8?B?K1o1bTlhd2NVaTh5WVI5bVIveGZ3d25BUWZwbEFBWWUzSkREYjRvVDB2ZTZn?=
 =?utf-8?B?RjdKaGkrVFdDb0RFcmRtS2UzR2JzZXhlMjNCYitja1ZXU05mQ3pBMzFDUU9C?=
 =?utf-8?B?T0oyQ1R3NUUycE5mS0Rna2NDM2ZVRnhQU0V1dE1LcFBBVUF1eUR4RFNUbGpS?=
 =?utf-8?B?NXphRytVbFAySkExcGJEOUQ5ZGhvR3VvWFd4cVNPTnFvN21yM2VjUjNoR25h?=
 =?utf-8?B?dDc2SnJiM3ZLQWVyTUJGNStENGFnSWxVaVpLNldtQVd6cnlLWTVrbXVTOTlV?=
 =?utf-8?B?OXdjMUEwYlZocktZRTNISEEyTFkrRWNnWGV2V0JPdHNHOVFMazUrb1FBazYy?=
 =?utf-8?B?eWlDMGRXMUlnYkZ3MnRCTHVhNmdkam42VlYzQllaV2wrSXl1T25UQTlheUhT?=
 =?utf-8?B?OWtUaVVyWS9TeGlWVnVPd2hnY2VZY0QrT3JkbDc1TTNxN1ViQjRpU1pIbUJW?=
 =?utf-8?B?M0FZREFJVkczLzMyRThRZXRzZTdTdHFScFlod1pIRTlhTkl6V0tSTnFaR3dX?=
 =?utf-8?Q?QlEQOUgjgTsalJwGBWSlylSOE?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 23a0056a-0921-475a-e915-08dbd6336067
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5732.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2023 14:53:55.4427
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: O++25BqlXH5wbVwMkEggu9+7ES+glK7wlebqruMQE2FIa4k+gsYcFiCFOfz+yVEZ+5o+oNcBa/7Ldue8cpfA3A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN6PR12MB8472
X-Spam-Status: No, score=-4.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Thu, 26 Oct 2023 07:54:06 -0700 (PDT)

On 10/26/23 05:30, NK, JESHWANTHKUMAR wrote:
> 
> On 25-Oct-23 7:01 PM, Sumit Garg wrote:
>> Hi Jeshwank,
>>
>> On Wed, 25 Oct 2023 at 12:27, jeshwank <JESHWANTHKUMAR.NK@amd.com> wrote:
>>> From: Jeshwanth Kumar N K <JESHWANTHKUMAR.NK@amd.com>
>>>
>>> At present, the shared memory for TEE ring buffer, command buffer and
>>> data buffer is allocated using get_free_pages(). The driver shares the
>>> physical address of these buffers with PSP so that it can be mapped by
>>> the Trusted OS.
>>>
>>> In this patch series we have replaced get_free_pages() with
>>> dma_alloc_coherent() to allocate shared memory to cleanup the existing
>>> allocation method.
>> Thanks for putting this together but I can't find the reasoning behind
>> this change neither in this commit message and nor in the patch
>> descriptions. Care to explain why?
>>
>> -Sumit
> Hi Sumit,
> 
> We see that there is an advantage in using dma_alloc_coherent() over 
> get_free_pages(). The dma-ops associated with PSP PCIe device can be 
> overridden. This capability will be helpful when we enable virtualization 
> support. We plan to post a virtualization related patch in future.

To be specific, you are referring to Xen virtualization support, correct? 
Because I don't see how this works in a Qemu/KVM environment where you 
would get a GPA and not an SPA.

If that is the case, you should clearly specify that. Also, this looks 
like it should be introduced with the virtualization support that you 
submit in the future and not before.

Thanks,
Tom

> 
> Regards,
> 
> Jeshwanth
> 
>>
>>> Rijo Thomas (3):
>>>    crypto: ccp - Add function to allocate and free memory using DMA APIs
>>>    crypto: ccp - Use psp_tee_alloc_buffer() and psp_tee_free_buffer()
>>>    tee: amdtee: Use psp_tee_alloc_buffer() and psp_tee_free_buffer()
>>>
>>>   drivers/crypto/ccp/psp-dev.c        |   3 +
>>>   drivers/crypto/ccp/tee-dev.c        | 119 ++++++++++++++++++----------
>>>   drivers/crypto/ccp/tee-dev.h        |  11 +--
>>>   drivers/tee/amdtee/amdtee_private.h |  18 ++---
>>>   drivers/tee/amdtee/call.c           |  74 ++++++++---------
>>>   drivers/tee/amdtee/core.c           |  72 ++++++++++-------
>>>   drivers/tee/amdtee/shm_pool.c       |  21 ++---
>>>   include/linux/psp-tee.h             |  47 +++++++++++
>>>   8 files changed, 221 insertions(+), 144 deletions(-)
>>>
>>> -- 
>>> 2.25.1
>>>