Received: by 2002:a05:7412:a9a2:b0:e2:908c:2ebd with SMTP id o34csp1032197rdh; Fri, 27 Oct 2023 02:46:44 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFG7OfgoEjIuiRGP1IrvhAliTrt7HMWBiIXx6uo5gIHdBGZPHEBogU0rUaxHK4J7UPgfQux X-Received: by 2002:a1f:a0d3:0:b0:48d:1b20:268e with SMTP id j202-20020a1fa0d3000000b0048d1b20268emr2407108vke.10.1698400003856; Fri, 27 Oct 2023 02:46:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698400003; cv=none; d=google.com; s=arc-20160816; b=xn7HprfOiPhbBQ0TgcBJR3ZM3CwpTzzipwDsdeHOBiB6ViX4zqcqdPKQVawQ2FXvtV Gm5r216VgnS/PTfxTFmDHyaW84LQU/y6HLH5eDNTacuSvbWonUU+A3RxVHnN5xFBFq9r Ec4bO9iqe0nau2x2zIl2FTrWs9CX4nP22lZFPRfaLx+3qoT9igZBwWrBoSfWag6umA5c NfgcQZTbsgecelTKbHHLeVbDJaxNJeaF0msQ+O6yO2Ez88RFzl3q+NNrf/U6c5rPxNbm hkoPiUYdB8lDacnvxkA0QGS4gX+9ujGlp3LlLQFPlykOOcMjwsQ7h82by2tXdUcO3w87 P3xw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=LufGFyRyjQPZ/UM028gP7VzXCOAOFA25duMbjIUh1bI=; fh=L6F44S3oCJ6yuXhAu++ZSL9Ml/3up/jiamAQ92+Rwts=; b=PLDrGXCID2WOdJJk63/Zv+Odt2/kaafkWML461lCtBeEbAFZEJSQSVke6sEZjrqTIB 1dbBME4UAPmdP4ToQIUxFQ8YtuM6ewHl0LazzO8LQv8eHzPz/ihWm55yCqbWqF3W1K5n GJQwoOoWzxV0wE1GJ6fb6gPRk90jKE6gHhjZHZS4W8pu2NfsDN4j62HOuYuNIpoLX9le K61QqiiNxPTsNtqwYuwWHJ5aF9/B3HIR8e7NkfAJXZ8baAMhv8hAFDEEqyClwaiINAz1 bnxxZvZzfLjtiUwGAEMWop4yN9LFs1Qyx2lvSytV4kOE55m+COfmy/yYwx5C9p+M4snz TFNw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id n204-20020a0dcbd5000000b0059bcbaaeab1si2090670ywd.302.2023.10.27.02.46.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Oct 2023 02:46:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id C5576807F4A7; Fri, 27 Oct 2023 02:46:05 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231360AbjJ0Jpz (ORCPT + 99 others); Fri, 27 Oct 2023 05:45:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35224 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230502AbjJ0Jpy (ORCPT ); Fri, 27 Oct 2023 05:45:54 -0400 Received: from abb.hmeau.com (abb.hmeau.com [144.6.53.87]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 64BE29D for ; Fri, 27 Oct 2023 02:45:52 -0700 (PDT) Received: from loth.rohan.me.apana.org.au ([192.168.167.2]) by formenos.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1qwJPX-00Bd5p-N5; Fri, 27 Oct 2023 17:45:48 +0800 Received: by loth.rohan.me.apana.org.au (sSMTP sendmail emulation); Fri, 27 Oct 2023 17:45:53 +0800 Date: Fri, 27 Oct 2023 17:45:53 +0800 From: Herbert Xu To: Shashank Gupta Cc: linux-crypto@vger.kernel.org, qat-linux@intel.com, Damian Muszynski , Giovanni Cabiddu , Lucas Segarra Fernandez Subject: Re: [PATCH] crypto: qat - add heartbeat error simulator Message-ID: References: <20231020155541.240695-1-shashank.gupta@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231020155541.240695-1-shashank.gupta@intel.com> X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Fri, 27 Oct 2023 02:46:06 -0700 (PDT) On Fri, Oct 20, 2023 at 04:55:26PM +0100, Shashank Gupta wrote: > > +#ifdef QAT_HB_ERROR_INJECTION Please move this into the code. > +#ifdef QAT_HB_ERROR_INJECTION > + hb->dbgfs.inject_error = debugfs_create_file("inject_error", 0200, > + hb->dbgfs.base_dir, accel_dev, > + &adf_hb_error_inject_fops); > +#endif So this would look like if (IS_ENABLED(CONFIG_CRYPTO_DEV_QAT_ERROR_INJECTION)) { struct dentry *inject_error __maybe_unused; inject_error = debugfs_create_file("inject_error", 0200, hb->dbgfs.base_dir, accel_dev, &adf_hb_error_inject_fops); #ifdef CONFIG_CRYPTO_DEV_QAT_HB_ERROR_INJECTION hb->dbgfs.inject_error = inject_error; #endif } Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt