Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
Date:   Fri, 27 Oct 2023 18:53:32 +0800
From:   Herbert Xu <herbert@gondor.apana.org.au>
To:     Stephan =?iso-8859-1?Q?M=FCller?= <smueller@chronox.de>
Cc:     linux-crypto@vger.kernel.org, "Ospan, Abylay" <aospan@amazon.com>,
        Joachim Vandersmissen <git@jvdsn.com>
Subject: Re: [PATCH v2] crypto: jitter - use permanent health test storage
Message-ID: <ZTuWrAvzHaQ1DqwZ@gondor.apana.org.au>
References: <5719392.DvuYhMxLoT@positron.chronox.de>
 <2706159.mvXUDI8C0e@positron.chronox.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <2706159.mvXUDI8C0e@positron.chronox.de>
Precedence: bulk

On Thu, Oct 19, 2023 at 09:40:42AM +0200, Stephan M?ller wrote:
> Changes v2:
> 
> - mark function jent_health_failure as static
> 
> ---8<---
> 
> The health test result in the current code is only given for the currently
> processed raw time stamp. This implies to react on the health test error,
> the result must be checked after each raw time stamp being processed. To
> avoid this constant checking requirement, any health test error is recorded
> and stored to be analyzed at a later time, if needed.
> 
> This change ensures that the power-up test catches any health test error.
> Without that patch, the power-up health test result is not enforced.
> 
> The introduced changes are already in use with the user space version of
> the Jitter RNG.
> 
> Fixes: 04597c8dd6c4 ("jitter - add RCT/APT support for different OSRs")
> Reported-by: Joachim Vandersmissen <git@jvdsn.com>
> Signed-off-by: Stephan Mueller <smueller@chronox.de>
> ---
>  crypto/jitterentropy.c | 125 ++++++++++++++++++++++++-----------------
>  1 file changed, 74 insertions(+), 51 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt