Received: by 2002:a05:7412:a9a2:b0:e2:908c:2ebd with SMTP id o34csp2067003rdh; Sat, 28 Oct 2023 21:59:04 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF4NikG8WwYl1cyDBM3rbDGwbVDHOUm0UtXMpCj/rrtQdUeC3b/2xe9/0/BoX5u/oaSLELM X-Received: by 2002:a05:6a00:3a03:b0:68f:ce6a:8685 with SMTP id fj3-20020a056a003a0300b0068fce6a8685mr8086220pfb.14.1698555544362; Sat, 28 Oct 2023 21:59:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698555544; cv=none; d=google.com; s=arc-20160816; b=PqBJNWhKC/jXnZhy57nROmLXe6fc6GLnhqGX9RJbiHkLUXednoMTW2POnzLDjjfC2/ hgvHIDiHRXX01ZW4whE9R6F/k1iV49Q/TgEbseXEL66F18GeGiF/TnD7LWkIua2s7NJb 2esxiRlKUwV2Av4VZ29oM0WiKjxMh8Uco8uNnkNdyI62zC7NVidYE1Ky7v/MMc/HYYE5 3UO0SXWRkPB1DpRezqfGUokAsf4VzTqoKlcGTk+BDiex2oXS2dtHCR5XXG1RIp5QKPGC T9s59XaOcF5GwBP40/ju2/mtXy6tel/ePg6YI/HczBf1cl1fkF/8ZsEuNcO7z6WYN9Qv +4aw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=3Uy9s+oo4EU/HXM3HrJWctNwMFMmJATUX9GJz0Vd7FE=; fh=xjS8A9phhM01m65X4FCI14AHGKg2ddBYae/rmCW0of4=; b=ruuA9DsRcodI7g7g7tU1ipPbCnTIGtk2ixYa/BpeM0V5VGpve6a2S+ZpjCzEqPIGgS PhM3/0g97HfXHFhVfA4KxTC7DH/KcjFTYk3fdNFJw3xYwyvD0XywiVgUH4ZX0GxHChYU 9lIexlD+1scMk4reFWY7+WeXwUItpbm6/+djEVAyZ6OYY+QyUVXZHppPyINOuk7EzRGz kObBdNU5Zndb1RrcSMx2J6sI1OPh1lcEy7bgQ7W7jDk5ihcrSpTQxfrcv88lCRBZuUMQ IlVTuYocY6h4vwRkCk1/AGsQp3rApGxbolDV6fDxlkuKv6JKSVX4EcewrdxIAoAJECx1 V1dA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=YqPpo7OC; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from pete.vger.email (pete.vger.email. [23.128.96.36]) by mx.google.com with ESMTPS id z3-20020aa78883000000b006826c8d5a31si3295111pfe.21.2023.10.28.21.59.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 28 Oct 2023 21:59:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=YqPpo7OC; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 135438051634; Sat, 28 Oct 2023 21:59:00 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229533AbjJ2E7A (ORCPT + 99 others); Sun, 29 Oct 2023 00:59:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43714 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229446AbjJ2E67 (ORCPT ); Sun, 29 Oct 2023 00:58:59 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DC19FC5; Sat, 28 Oct 2023 21:58:57 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 565CCC433C7; Sun, 29 Oct 2023 04:58:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1698555537; bh=75TmNIw9o5wwMcE/v+GkI5Pw98/aJRyGJi9NVTJa7bg=; h=From:To:Cc:Subject:Date:From; b=YqPpo7OCdKYtvbsrLiZmUZ2BY9ZFLJbFmS4MFMQVLGNk4OvkT9cDpT+8EFplfS9lR TtFhrydRd1wDOp9ft25n+NB1QtyvDbkL7yS/zhwAniQ0nxO1vG1SG/r0LVK9C/ZoDq r5mCyagNT97SS0fWE/gfI7nzAnV5mHd3Ml4bZddx+O9WOiK2dqgQOLc1ClEYuZ3iJ4 mjLIqbMYElXvHShQnfOYeTFyPVpjuZrUl3KOMORl6C92pFOaB66B9CiN+1CcWXdHth IQBfTB/cH/ylGXhIspK1ec1CNKnNiyz5bbjy5y+W8SGZfPr36ECmFaz+16vKoyaJUL TvQpV6HXeYY+w== From: Eric Biggers To: Bernard Metzler , Jason Gunthorpe , Leon Romanovsky , linux-rdma@vger.kernel.org Cc: linux-crypto@vger.kernel.org Subject: [PATCH] RDMA/siw: use crypto_shash_digest() in siw_qp_prepare_tx() Date: Sat, 28 Oct 2023 21:58:39 -0700 Message-ID: <20231029045839.154071-1-ebiggers@kernel.org> X-Mailer: git-send-email 2.42.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Sat, 28 Oct 2023 21:59:00 -0700 (PDT) From: Eric Biggers Simplify siw_qp_prepare_tx() by using crypto_shash_digest() instead of an init+update+final sequence. This should also improve performance. Signed-off-by: Eric Biggers --- drivers/infiniband/sw/siw/siw_qp_tx.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/infiniband/sw/siw/siw_qp_tx.c b/drivers/infiniband/sw/siw/siw_qp_tx.c index 60b6a4135961..5b390f08f1cd 100644 --- a/drivers/infiniband/sw/siw/siw_qp_tx.c +++ b/drivers/infiniband/sw/siw/siw_qp_tx.c @@ -242,28 +242,24 @@ static int siw_qp_prepare_tx(struct siw_iwarp_tx *c_tx) c_tx->pkt.c_untagged.ddp_mo = 0; else c_tx->pkt.c_tagged.ddp_to = cpu_to_be64(wqe->sqe.raddr); } *(u32 *)crc = 0; /* * Do complete CRC if enabled and short packet */ - if (c_tx->mpa_crc_hd) { - crypto_shash_init(c_tx->mpa_crc_hd); - if (crypto_shash_update(c_tx->mpa_crc_hd, - (u8 *)&c_tx->pkt, - c_tx->ctrl_len)) - return -EINVAL; - crypto_shash_final(c_tx->mpa_crc_hd, (u8 *)crc); - } + if (c_tx->mpa_crc_hd && + crypto_shash_digest(c_tx->mpa_crc_hd, (u8 *)&c_tx->pkt, + c_tx->ctrl_len, (u8 *)crc) != 0) + return -EINVAL; c_tx->ctrl_len += MPA_CRC_SIZE; return PKT_COMPLETE; } c_tx->ctrl_len += MPA_CRC_SIZE; c_tx->sge_idx = 0; c_tx->sge_off = 0; c_tx->pbl_idx = 0; /* base-commit: 2af9b20dbb39f6ebf9b9b6c090271594627d818e -- 2.42.0