Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Message-ID: <be7a774e-54d7-4ebf-8476-de137c47f020@amd.com>
Date:   Mon, 30 Oct 2023 11:35:57 +0530
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 1/3] crypto: ccp - Add function to allocate and free
 memory using DMA APIs
Content-Language: en-US
To:     Christoph Hellwig <hch@infradead.org>
Cc:     thomas.lendacky@amd.com, john.allen@amd.com,
        herbert@gondor.apana.org.au, davem@davemloft.net,
        jens.wiklander@linaro.org, sumit.garg@linaro.org,
        jarkko.nikula@linux.intel.com, mario.limonciello@amd.com,
        linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
        op-tee@lists.trustedfirmware.org,
        Mythri.Pandeshwarakrishna@amd.com, Devaraj.Rangasamy@amd.com,
        Rijo-john.Thomas@amd.com, nimesh.easow@amd.com
References: <20231025065700.1556152-1-JESHWANTHKUMAR.NK@amd.com>
 <20231025065700.1556152-2-JESHWANTHKUMAR.NK@amd.com>
 <ZTtJdU5a/P4kg/Ss@infradead.org>
From:   "NK, JESHWANTHKUMAR" <jeshwanthkumar.nk@amd.com>
In-Reply-To: <ZTtJdU5a/P4kg/Ss@infradead.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QXAxZFdVaFFqbW9nNWp6L0ZHS2xmMjczYzEvNTJ3Vkd1a3ZrMjBQd1NRbERo?=
 =?utf-8?B?SWk2SVpGWlA0dThSYVprbGV4dnJHbFRMWkp3U1gvS3ZPRHZKaWJFblZaM3JY?=
 =?utf-8?B?WitUMmRqUC9PUzNTZ1NLVU12alRGMUZ2aDdPaGFGT01LNCtJc0lVODk4WG1X?=
 =?utf-8?B?WXVPVTNXUmtWUVFtSy9Md0VqbU1IVzlpZjFxNGZKTHUwaHdIZS8yWnNVMlV2?=
 =?utf-8?B?Mmp3Z2N5Z21UbUFZeU9vc2lFRFVjNHI1dmxpMFJqTkRQeGpETW9hYVVmalh6?=
 =?utf-8?B?aTlmRTRhd2FJM0xRVUJHMmFxalpKWXFCdVZqbFY4U2ptWGRMeWxTaWI3RElW?=
 =?utf-8?B?NElIRXhYaXFnVTZVcUR5MDFFN0tBRHY4OVp5QWdtUkpJaTl2WEc1bTVJQ3d3?=
 =?utf-8?B?bituRlFCM0xQUmVTdDh0Ukdoc2REdEp5eWJqT011SURzbVgzS0IvZlZrbTcz?=
 =?utf-8?B?QnRDY0ZSNGdxWmtzY3lnSnh6YXp1eTNjN2JycWs1SG1iNEp0NmxmQm0veEhV?=
 =?utf-8?B?cTh5M3hpRC8yNzlaZGJqYVNjbzlzUkNYY3Mwd2NhSVEyanB1SkFEMDZ3WHRU?=
 =?utf-8?B?RldiTFlCN0xDUXNXallRREVIdHZha1RackhVUmFzOTR5RVpYbklDWTJyOWpn?=
 =?utf-8?B?Vm8yM1ZqYjljcTd2Y2IvcnJjUTJWNmtsNlAyTzNtMEpVK21UdTNUdjhtOUx6?=
 =?utf-8?B?TGw3R1pZQVU5enBKb25xelRENDZicm5lZDd2ZUI0ZjNFOW1MUWF2SGNBTG1G?=
 =?utf-8?B?VEI3T1JEVmZsazlLeE1mZDEvK2lVbk05V3pOb3dtbDFQNktjb29McjR0S1RV?=
 =?utf-8?B?OCtCWmZEY0w5MitUNXVyRFdOaC9UZWdKMEY3QXNrS1c3QTlvMWZvdXhHL0lF?=
 =?utf-8?B?dkFlWS9IaE1RTEpyUVc2aU01QkFCSVlkKzBSZnBNSEx1Y3F6RW5JR0RKSlJT?=
 =?utf-8?B?UWxvL2p5elhCdHBGUjFsaWR0Q3BRQnlKUkJEZklhZmlvaktWZFdjVlpSS0cy?=
 =?utf-8?B?TWJQMXR5a3Joc1NHSTM0MTAxdWFXZ0xrUmJlakdiYTRIYzNPUmtmVlJidzVR?=
 =?utf-8?B?VWZhVDQ0TWx3eU9NS3dVNWRJWHU0YWJmT1ViTHVDWWFlbnlzR0cwZktqK0p5?=
 =?utf-8?B?a1NGbzE5Q0VrOW5PTUFLdjlhbmZIbjhtU3YxWEdjWWFiU2JFLzQrV2dXZ0Nt?=
 =?utf-8?B?bWFweU5iblBvU0lYM2NiWnJTOVFZb2Qxd1U3dE9vU0JPUUI3VWErM0kvcmdu?=
 =?utf-8?B?RUJGNkNuNGxNWjdweGtKMnJhZGFwR2hDd2l1Vi81c2xPamNUSlhjL0l6SjJO?=
 =?utf-8?B?WllQeThqWFdZWFp2aFFoZmt3K295Z2UvMUlpaEJrMmk3blRpYkhEeTFlUzBC?=
 =?utf-8?B?TkZJWjRtVjhZYUp3RlNqbnNMQWlicFp4NDdhUDZoVE1jcWlIeWxpTVVtK1gy?=
 =?utf-8?B?OXZBWGRZK01RSmNjd2REcFJ1V3loaGhYd0h2eHBIbjlZaFhOaWV1NW9DWDJM?=
 =?utf-8?B?L1d2VXJoZ1dpRmF0Z0lSZm9TeXhCRnMxWEs3K0I3em51L0UxeU85eFNqck9I?=
 =?utf-8?B?Vzl1SU9GQzFRZExLbzdQb2NxclZDOHU2cDFRQlk5RGQzUHdFYzVLd042WmJj?=
 =?utf-8?B?bmp0NjBxeWNDa0U5OUxWaUt1ZHg3WHowWHVpZEEwK2pZQktleHhIR2NGdXBO?=
 =?utf-8?B?T1k3dUlYaERteURWYm43RXVZLzFaL2xTWXZUaW1wOEdYL2VkUWV1MnRWdXh1?=
 =?utf-8?B?OUhqRDM5QzRVVGo0WUdaREFDbFQySE9zV1BhYk5MaXVNbUprS1llRnQrUUNx?=
 =?utf-8?B?VVYxTTZDREhoV1JzMzQ2bjhra0RsN0YrcFMxN1JtNDF5MUFrekRYVSs2QU8z?=
 =?utf-8?B?UW04Wi9zN3dpMHhjakZOazB2aEhWeUlqMzh6SW1JTURWNHhWS21xbitFVzNQ?=
 =?utf-8?B?c1ZnMmRlZThSWmw2cnM5bTE4bU9jTm1KYlZlalJ4d25sdC9EV1B1L1kvSHZ2?=
 =?utf-8?B?NWlpZlBvSnY1cHpxblVwQXc0eVhKdnpSaHB6cnZrUktteXhFOGlqM3dJZXJM?=
 =?utf-8?B?SzdlMHVVbzcyUWZnRjNNaXVWNWRTb0g2ZXN4c3NUTXZIbXQvR2JCS1lSWkRy?=
 =?utf-8?Q?B5TiGqp3kC36pgwQ6Q3GrJAFG?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 87b75436-3f02-4075-8bfc-08dbd90e4eec
X-MS-Exchange-CrossTenant-AuthSource: SA1PR12MB8641.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Oct 2023 06:06:08.0778
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: lvjU8aBHEFyXGDIOqjIzy/KrQNsku3J0rAWexLZeefWOFTEL11fN8Cni79SjG0mkKIKikqm0yLmzTTybpEoehg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB6994
X-Spam-Status: No, score=-1.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Sun, 29 Oct 2023 23:06:16 -0700 (PDT)

Hi Christoph,

On 27-Oct-23 10:54 AM, Christoph Hellwig wrote:
> On Wed, Oct 25, 2023 at 12:26:58PM +0530, jeshwank wrote:
>> +	tee_buf->vaddr = dma_alloc_coherent(psp->dev, size, &tee_buf->dma, gfp);
>> +	if (!tee_buf->vaddr || !tee_buf->dma) {
>> +		kfree(tee_buf);
>> +		return NULL;
>> +	}
>> +
>> +	tee_buf->size = size;
>> +
>> +	/* Check whether IOMMU is present. If present, translate IOVA
>> +	 * to physical address, else the dma handle is the physical
>> +	 * address.
>> +	 */
>> +	dom = iommu_get_domain_for_dev(psp->dev);
>> +	if (dom)
>> +		tee_buf->paddr = iommu_iova_to_phys(dom, tee_buf->dma);
>> +	else
> No, you can't mix the DMA API and iommu API.  You need to stick to one
> or the other.
Can you please elaborate?