Received: by 2002:a05:7412:f589:b0:e2:908c:2ebd with SMTP id eh9csp309793rdb; Tue, 31 Oct 2023 08:07:43 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGc/zcuz2ut77T/1Es3cO8AA/9Orh5QCMYkC3kRNwCW+sUYwsDOLDhRTl7C47+9Omu9+Tf+ X-Received: by 2002:a05:6a00:391a:b0:6c0:148f:74de with SMTP id fh26-20020a056a00391a00b006c0148f74demr3891373pfb.5.1698764862705; Tue, 31 Oct 2023 08:07:42 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1698764862; cv=pass; d=google.com; s=arc-20160816; b=C6D3zlfnQaplyGsLZawZfK8bYwPXZVZ/2egPoiQGbXwgf1RTPXbUxxDtizV3y+vKTS 2B1ReTJOj8533tkyYkfDQp0ODp20R4eFDcC0NI4+iJuyYb5/EFLXm4WWWpEcvmLBLMNx 501F4Z4knoYegorto15URT3rRidWsHteE4r7pSTPsjxZgfgOco/ZeA+IyTPO3VAaeNdv vh8uDaf/rarjVTIG7WlV2eHLqO2X8jGauE8u/8H9AcyoLWXMS/Y/+HBo1FhdZWQJL66V bC55ADsnEbPExrarZ8SI1POluwNR4dRnxqLU5kUHtXh8ZZrKVZ31YJp1YK3ammsbPPBQ DQuw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:date:references:in-reply-to:subject :cc:to:from:dkim-signature:message-id; bh=mwcYmzMGLrIJAKwwPAsSOg0b5letFz0OQC+Kd8SAaXA=; fh=xyHz1NiwUMPkYfgV6gIOMlb9CcFI6r3QEo1h+o2hjqY=; b=YZwY6A5y1ToXJAENGZJes8fgEZ5XjesHo4SN7ENqO+wHRP1S29va9uHliJY0wEsLlt 7/xtIH/oFIMugFAV6zvkftptdRVLYfVZMp9TqjopEYxSDvwB1AeWXkIxL6HLDABuqQ6L tsoS7brzyUiR4OSbi6eRZ570dgf0qb09UmVy3pyrwDqf8k1M3uM0WdwjuQ8uVXkCF5Lc gVb9ltDepp3WNr6JFi+NgRfQbzA0J6gioo8OcLiSgr+wTtsi1L/3LspLQTxelyQ+Cvgu dCK0FBQFee61kile/ze5vhL/IFfp0rHGjKu24Ao7b0Sl966Ck+ygtNmhX3ub9tELDA7Z ucNg== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@manguebit.com header.s=dkim header.b="I1e1Nm3/"; arc=pass (i=1); spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=manguebit.com Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id fi24-20020a056a00399800b006be0559d029si1116216pfb.109.2023.10.31.08.07.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Oct 2023 08:07:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@manguebit.com header.s=dkim header.b="I1e1Nm3/"; arc=pass (i=1); spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=manguebit.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 82E1580A13A4; Tue, 31 Oct 2023 08:07:39 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231516AbjJaPHk (ORCPT + 99 others); Tue, 31 Oct 2023 11:07:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47818 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233467AbjJaPHj (ORCPT ); Tue, 31 Oct 2023 11:07:39 -0400 X-Greylist: delayed 595 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Tue, 31 Oct 2023 08:07:37 PDT Received: from mx.manguebit.com (mx.manguebit.com [IPv6:2a01:4f8:1c1e:a2ae::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 976369F for ; Tue, 31 Oct 2023 08:07:37 -0700 (PDT) Message-ID: <24f65f57980f7010cdc44f17023d475b.pc@manguebit.com> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=manguebit.com; s=dkim; t=1698764258; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mwcYmzMGLrIJAKwwPAsSOg0b5letFz0OQC+Kd8SAaXA=; b=I1e1Nm3/SfRhcsEPVlr3BsdMch/5F6GBpdFrsAg1JJujq9CXM8y4rxR24iCsA7o6/kyGZp 1eCCN7BrEhrlr29kw8EycGIAC+5VDuUcJYePQHMu2vEAmJ4yxojoixAajxg0pawMUhgVTX QDBrcp7oSZRLbOeOSt7aOJyvxUcicZECrSuV0JKJEDb6DYVjDr21xE7l+QvMMYABmigplc 1AfzaAYXQ6e8jTxHcF/kWRS333VQxMV5+N5KodR26RDwk7QubXRb6jXNnXjJsdQLu+XTkp Nf4mYapUIelWMsR6I/nkAX8L5IccpK/9kI4hTmeWRvj/Fbm/AJn6/sj1G1lvTA== ARC-Seal: i=1; s=dkim; d=manguebit.com; t=1698764258; a=rsa-sha256; cv=none; b=i9bohQPBrDXw9uor/Yysn5EWlj4iUdv06t7PRa/UiMtTBkwnQGge9pdjQJ7Hr8Xo2+WfyW SieYjt/UzTwhv/9WosiDwa+kun/pe0Z/IjNKc2fZh99Qv/HkIFTw7fCrLyIDgjdacLaGrN Rn9CgiFZozdDnrPWH/jjr1OOL7SxCqPXFMXu4hMA1CxTniOzpzVWDGXkuHOBe+VCmGx6BT cuosu+OfgYR0WR54D6OHSv65Cm+flu3+5SCyeQHx+grfkHOhnRC12eP3K/J7c7csP1zH3W VJ9Cfisoru1tmYPhBa9Mu4fPdfjldAJE3wfeQABw9KWg2Ofd9ojtH76FtOovPg== ARC-Authentication-Results: i=1; ORIGINATING; auth=pass smtp.auth=pc@manguebit.com smtp.mailfrom=pc@manguebit.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=manguebit.com; s=dkim; t=1698764258; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mwcYmzMGLrIJAKwwPAsSOg0b5letFz0OQC+Kd8SAaXA=; b=VdZSD1LxJvjK1IQrc4FCTSyQxFh1H5WvOt5KnTyBWEXhcC4ghqf1GKZrrG9YF5/S9sPf6E mffkbQaRcqyisi6hXv0k4N3cjRcZVVgS5K1Jn8EsFN3fYV+ZRUeFDgqLtLIpT/F+CFSOq1 P8NibH9fLliAA47kBmqFGG9sGy0OT5Jr+oGkvDRZaBZa8am/gcvTGpenflRKK4mzZ+kXv/ +sbZjFouzCUDeI8IkKk1wKIyheRybaI9KkOKSXSKwwtg6+cIBF3MS+OLd1V5h45cBZGwsw kTcjrWtxPpG4a357qe2phi913waBylEG2q5+mzCBqdLDiUShTaah+tIhQTMmHw== From: Paulo Alcantara To: Eric Biggers , Steve French , linux-cifs@vger.kernel.org Cc: linux-crypto@vger.kernel.org Subject: Re: [PATCH] smb: use crypto_shash_digest() in symlink_hash() In-Reply-To: <20231029050300.154832-1-ebiggers@kernel.org> References: <20231029050300.154832-1-ebiggers@kernel.org> Date: Tue, 31 Oct 2023 11:57:33 -0300 MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Tue, 31 Oct 2023 08:07:39 -0700 (PDT) Eric Biggers writes: > From: Eric Biggers > > Simplify symlink_hash() by using crypto_shash_digest() instead of an > init+update+final sequence. This should also improve performance. > > Signed-off-by: Eric Biggers > --- > fs/smb/client/link.c | 16 ++-------------- > 1 file changed, 2 insertions(+), 14 deletions(-) > > diff --git a/fs/smb/client/link.c b/fs/smb/client/link.c > index c66be4904e1f..a1da50e66fbb 100644 > --- a/fs/smb/client/link.c > +++ b/fs/smb/client/link.c Reviewed-by: Paulo Alcantara (SUSE)