Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Message-ID: <b32913fd-3b86-cebf-8240-4e0bc05f883d@oracle.com>
Date:   Tue, 31 Oct 2023 17:37:47 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.15.1
Subject: Re: [PATCH v6 05/14] x86: Secure Launch main header file
Content-Language: en-US
To:     Matthew Garrett <mjg59@srcf.ucam.org>
Cc:     linux-kernel@vger.kernel.org, x86@kernel.org,
        linux-integrity@vger.kernel.org, linux-doc@vger.kernel.org,
        linux-crypto@vger.kernel.org, iommu@lists.linux-foundation.org,
        kexec@lists.infradead.org, linux-efi@vger.kernel.org,
        dpsmith@apertussolutions.com, tglx@linutronix.de, mingo@redhat.com,
        bp@alien8.de, hpa@zytor.com, ardb@kernel.org,
        James.Bottomley@hansenpartnership.com, luto@amacapital.net,
        nivedita@alum.mit.edu, kanth.ghatraju@oracle.com,
        trenchboot-devel@googlegroups.com
References: <20230504145023.835096-1-ross.philipson@oracle.com>
 <20230504145023.835096-6-ross.philipson@oracle.com>
 <20230512110003.GC14461@srcf.ucam.org>
 <2f7689e0-b79a-c642-815f-a487c1b9e700@oracle.com>
From:   ross.philipson@oracle.com
In-Reply-To: <2f7689e0-b79a-c642-815f-a487c1b9e700@oracle.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TE9VemRXano2b01sZHlEYllHUDZkeU1COTZxaHNsY2hKZGdaSGZhSlJPUjB1?=
 =?utf-8?B?ZndiVU5NK1NXSzhwa1FpYlFVSkJ3UmVlcEQ2MDVhVlc2eWNWZFBvWkdWR0RF?=
 =?utf-8?B?RWUzZmZ0cTZ0dFZZQVBPTUpmRGZXOUhaZG16M2VBTzZzdE1OZmhTZmY4VE5J?=
 =?utf-8?B?NURreUMrREdWWUp4UmRtUFAySWE1c3dDRndhMEQ4eVdPa251cGJ3V2NyQkRh?=
 =?utf-8?B?eEZpNUZHS25tV1FZMjg0QmZtR2hLcU5CdHlabUpsOGQvbk1kNFhJaEcrd01r?=
 =?utf-8?B?aFNxbi9GYzJSN0owbFZzK29Xa1dUQ0VsTS9GenJ1V1dtZm44YktxaTJUNnlj?=
 =?utf-8?B?MmtUOWh4KzgzVTNBUVRPNmlDbUxWcERqSW9VdGJNTU5sdmxqeEZFQ0hmb2Vl?=
 =?utf-8?B?WG04YlpmclBnemkvc1RvNlNQOFhVb09nODZJVmU1ODlYUWxScjNMODdFNEVu?=
 =?utf-8?B?aVZzNXZDZEtpWVd6NTdVWXNYYm9RalJTeUdSemdSa0QxNHpUV0puUitZK2Vs?=
 =?utf-8?B?U2N5NTlNbDJubTFwRnltWUdSOXEzZW9Xbk1QMGNpZzhpYzFBbmE5TlEwUXRw?=
 =?utf-8?B?U2puTUVIUTJpUCtyVmNPRmJPTEt3RG0wY2pjZjJKUWdWWTZtaHJhKzhlV1cy?=
 =?utf-8?B?Ui85eFE2QkVNUWJBR3kvZVB6M2t0RjVDblU1WTBQNmJONVFSYnZITEdLM3o1?=
 =?utf-8?B?dlpndFdIWDFkMDlrTkEyUnJvVFMyL2RkYVcwRXQwdkxjZC9aOTR4R3ovWWcz?=
 =?utf-8?B?ZGtPMkdGbXRJZXhGbEppQUxUZEhCRVZNRDdha21BUldtaGxMOUdoUzJzbGhH?=
 =?utf-8?B?d1YvVGhZYyt3YnFWV3BSckdpaEcrT1pEVjVLYW9xeGRPQnhoV2N6TzJyei9X?=
 =?utf-8?B?S00xcExsVUdFcjNVaEpKQUZWRkdGekNiMlB1MG5Ha0dBZjU3OERQUEhvSGpS?=
 =?utf-8?B?Tld4K3V3WTlZQ1VLWTdQb3B2SVBROGl3QkYyaW43dkUvaTBVTVd2czRjc1Nn?=
 =?utf-8?B?ZExGU2g3NXhqTXFFT0lEK0cxSEtLaU5FaXhpbUtGOVZSYVNtSUhZYVRmOExi?=
 =?utf-8?B?cS9YVHoreDVhb1JzSmo3MnNaNUpEbkhTVzVhdTJnK0Npa3ZpeVZLNlFJemJi?=
 =?utf-8?B?QkNhdi9YdHNGaXlMa3lxcGhURFdvWlZtQ3lqcmNLazlQaEVVVFJZeDgzRXM0?=
 =?utf-8?B?c3A2eVQxaWN5Q1pBRlZUVlFkZmcxdTRzTmRiUldYVUFubytwU1R1SHFvSUpU?=
 =?utf-8?B?dnlaaXh3b1htWEZqVFY0NXlwVFJwSTJvVVV0V3U1d0gzelE1aWVwS05PcVhr?=
 =?utf-8?B?LzZMUVF6RjNyRFZ0bzRjMXYrVjM2amttYWZheWcwZmczVmJpNXpBMDFTZXln?=
 =?utf-8?B?STl3eS9FL2pyWmo4VU0xRWVIRFZFOVZ6UmlSSXFZWnM3cm9oWFFVaEtveU83?=
 =?utf-8?B?K1RMWHkwM05OY2RiaDRNVTZiMFhEZU9QdVRwRmRncWdKeldKRGZwYUJ3S0Y1?=
 =?utf-8?B?NGNMM0ttY3pSVXF0a1VqcHIwYUJHYml2R2l3cEk3RzZZZU1tRG8xUnE3S1dy?=
 =?utf-8?B?OEo5TlNLV2xZdlY3OHIvL3U1VGU0aFo2TXZqYWU3N0lVV2xPTGduaFZKekZ4?=
 =?utf-8?B?eDNWd21NS1ZvWnlEbitpRG96ZGNmckJtYUs1TFNJV0hrMDM1QjYzdFI5L1ZS?=
 =?utf-8?B?cTcxS2xtczE4d3NnajNFbEZFY0lmV29vbXFPd1p0MDl6R0hhWURLbXg1ck9H?=
 =?utf-8?B?WkxuWHIrVU10S2FJTDhMSm4vVDJCYmZTMk9leXhzc0tGVVlxelFJdHRPUTNx?=
 =?utf-8?B?WlltZlVoSEJhMlNwcDh6WTBKSVNxVWQ4UzRsNVFZcHlKb1FydVZRV0hkNnhH?=
 =?utf-8?B?dUdwK01kTWM4Mlk4QnlITTR3TldWZWtMVmFMbEdhMkdnL2Nkc3lXdDRhRlJO?=
 =?utf-8?B?QUxnZ0VmeGt4RVNBd1dXN2tLTnZSRHRORXNWR0xpRE5BSnlnUlJGUkJrQ1Rj?=
 =?utf-8?B?NzlMa2lFVFFWQkFpdEpUc09kQ2JVQnNiS0R2WmE4YVluZkFrUlBTblpPMVVn?=
 =?utf-8?B?T05PWi9WVGszREZ3eG5HZHR3Q0p4OFpTN0JaQm5JV2w2Qk9UbDdoVEEyOWdI?=
 =?utf-8?B?UnExSmIyKzlqR3ZNS0hkK0Z3eXdwWWtqRDluVWJRaUNIZ2tURis2SkVjOUdt?=
 =?utf-8?B?OWc9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?UlBlOHRXZFFJdFpTeW9LVWVwY0FxZVZ5RkhNS2pNUTYxMUZlVUhBVG5WWnFx?=
 =?utf-8?B?bWwzTGVRbTlnRStvVG5sUUVoYUg4dEk3UkRzN3luYWs4ME5NNnZFRjg1TzBT?=
 =?utf-8?B?a3JyUll0YVN0SEZtdjNmSThCUHNrQlFyd294eit3U1oyd1lpOTMrQ2NoRWhF?=
 =?utf-8?B?eFJHQU05ZjhqSUsvY2NTMnRHMWJoUzdSZ1pCcmJsQlhEalc3VUlmRWtvUU80?=
 =?utf-8?B?MUkydHpjMkM4VWJIT2doWG56K3l0YUdXNzVKaUhQOWFSajNFcktrR29vWU5B?=
 =?utf-8?B?VlhMUVZJNzdBYnhrQVMrSzVGZVZMNjk5cVhQSE1xaHFyMzlTaTJhQUlCVnAr?=
 =?utf-8?B?YS93SDlzdlZEanJOd1E2RFFiZmRZdFEwNXNEbVkzY2cvRFkzb3p1bldxRTc2?=
 =?utf-8?B?MnFvMHRkVGloNlZSU3ZmWmNrRWovdWNuRzhIbFoyVjVnY2tTNmVEWTRuM1RW?=
 =?utf-8?B?YVVRZE5TeWkvK2VhbWNHUXA1WHJmV0JEcG8zVkx2aXlabDlBV1VidXhIUkZk?=
 =?utf-8?B?NUJGcE1vLzVNWEZOOURhNmxmaERGdkhySytGRnplcXcxbmY4NmNqeS81NjYr?=
 =?utf-8?B?aVNVYU1zdHZOWmlrMDlKeFNrY2hVZS91YWFmSjJ4Y2VoWmU4eGl4YmRjK0wz?=
 =?utf-8?B?Z1hBMGNtc1dKb1VBQWlXWTFpV1l3cG53eWd4czd4VFhUMWRMRk1JSUZYd1hk?=
 =?utf-8?B?ZjVNKzhlNmRud243L0JQbDRGWWd2RllwMWhXdm1wVEtRNy9JOXU5K2p6bnRp?=
 =?utf-8?B?MmE4Sm1tNTE3eXY0cTFNUmlvdmtoZTFTZE5GejhIVlNWdDZ5YVplenk1cGlK?=
 =?utf-8?B?dS9zQ0xxSmdpWjBZSTdGdW15Yk12Qzkremx5TkErVVUrN0xuRWRwWlFielhN?=
 =?utf-8?B?Y0dFMit2RCs5Nm5xNUc5Ulo4NzZseklVRCtIek9Nbmk4eHhld0F4clZEL2R4?=
 =?utf-8?B?bFdJOFRjKzdzeDFOUWRlNklUME9zalJLcHhoMFUzamNpUUcwMXRQeGw3NWtS?=
 =?utf-8?B?WEVwalJlTHowZGs3Vk5VT1pHbzZKanpCRWUvTlZNeWQ3VFBiYXNzclBvRkNN?=
 =?utf-8?B?Lzc3cGQvSmo3RzFhTXN3TDl3SVlxUVZDb0J1M0c3SGlxYjVNYmliUjM5Y2pC?=
 =?utf-8?B?ajF3QWJBR3RHT1hFenlYcW5zTVpNZ0ZZUFVIYkgzUklSMkVQVXVjU1VYb2Jp?=
 =?utf-8?B?Z1lWOElDZDF0U0tpb25weDF2RW1jdjU0UVFkbGsvVE5EVkVieGl6eXYyOFlG?=
 =?utf-8?B?M240QWtEb2FEaWpQQnJ2SjVNM2xBVlpqUzFWOEt5ZUQ1bVJERHFmdkMxeTVz?=
 =?utf-8?B?U3BWcW5KSC9SV3R3RXpwQVFOZGt4WUpEVnJRNTBzQ29Ca0VFdFRZckJ1ZUNG?=
 =?utf-8?B?bVVUSUR1eU9aZStFb1VmbDlJNFVpUVZYMzZLUmY0RjdGYmhGQzZVRElxakJh?=
 =?utf-8?B?bmQ1c0R1MzBCTW95SFJ6TDQxdkhNZVZML1E0N1hLcHZxM1VFSnkyaFRaQVZL?=
 =?utf-8?B?OFRxRUM5Q25DUTJybEtQanZ3YWUyaEhtYUlWVzFWb1FCMldVOXRpb3ZZZzhL?=
 =?utf-8?B?Zk5vVHZFU3BHcVg1b0RzQTlPUmdBUG5EeXduVjBUZnBQQzJmRndkV2k1aVQw?=
 =?utf-8?B?NEV5bStnTUxGZzR5RUxuVTR3b1RUT3RZaDMwZFkrMERWdldWYVNlRWgzemdM?=
 =?utf-8?B?bElhNExKdGl6TFQ1TlAwVVNaL2xBZWs5VWk4SkZpeUYzWjhPOWxsNnRMdnl5?=
 =?utf-8?Q?HIOStTIjs+ak3aISjQ=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 69152d7c-2c60-4cc8-0e1b-08dbda59a3b2
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB3793.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Oct 2023 21:37:53.8866
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NDmyqRjuxBgvSw12gUvhc8z7tmsQkA1nLtpi0iaL77SITcEVZOnvSLDyEUx2ghLmd5S15F437naD/4l6g5f1hzTMpnDWSLPJHv0IfxRSe98=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR10MB7273
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-10-31_08,2023-10-31_03,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 suspectscore=0 mlxscore=0
 spamscore=0 phishscore=0 adultscore=0 mlxlogscore=999 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2310240000
 definitions=main-2310310177
X-Proofpoint-ORIG-GUID: 7YlG4XtHoV1Gmv4bQffotyyOaCj86ZGv
X-Proofpoint-GUID: 7YlG4XtHoV1Gmv4bQffotyyOaCj86ZGv
X-Spam-Status: No, score=-3.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Tue, 31 Oct 2023 14:38:36 -0700 (PDT)

On 5/12/23 9:10 AM, Ross Philipson wrote:
> On 5/12/23 07:00, Matthew Garrett wrote:
>> On Thu, May 04, 2023 at 02:50:14PM +0000, Ross Philipson wrote:
>>
>>> +static inline int tpm12_log_event(void *evtlog_base, u32 evtlog_size,
>>> +                  u32 event_size, void *event)
>>> +{
>>> +    struct tpm12_event_log_header *evtlog =
>>> +        (struct tpm12_event_log_header *)evtlog_base;
>>> +
>>> +    if (memcmp(evtlog->signature, TPM12_EVTLOG_SIGNATURE,
>>> +           sizeof(TPM12_EVTLOG_SIGNATURE)))
>>> +        return -EINVAL;
>>> +
>>> +    if (evtlog->container_size > evtlog_size)
>>> +        return -EINVAL;
>>> +
>>> +    if (evtlog->next_event_offset + event_size > 
>>> evtlog->container_size)
>>> +        return -E2BIG;
>>> +
>>> +    memcpy(evtlog_base + evtlog->next_event_offset, event, event_size);
>>> +    evtlog->next_event_offset += event_size;
>>> +
>>> +    return 0;
>>> +}
>>> +
>>> +static inline int tpm20_log_event(struct 
>>> txt_heap_event_log_pointer2_1_element *elem,
>>> +                  void *evtlog_base, u32 evtlog_size,
>>> +                  u32 event_size, void *event)
>>> +{
>>> +    struct tcg_pcr_event *header =
>>> +        (struct tcg_pcr_event *)evtlog_base;
>>> +
>>> +    /* Has to be at least big enough for the signature */
>>> +    if (header->event_size < sizeof(TCG_SPECID_SIG))
>>> +        return -EINVAL;
>>> +
>>> +    if (memcmp((u8 *)header + sizeof(struct tcg_pcr_event),
>>> +           TCG_SPECID_SIG, sizeof(TCG_SPECID_SIG)))
>>> +        return -EINVAL;
>>> +
>>> +    if (elem->allocated_event_container_size > evtlog_size)
>>> +        return -EINVAL;
>>> +
>>> +    if (elem->next_record_offset + event_size >
>>> +        elem->allocated_event_container_size)
>>> +        return -E2BIG;
>>> +
>>> +    memcpy(evtlog_base + elem->next_record_offset, event, event_size);
>>> +    elem->next_record_offset += event_size;
>>> +
>>> +    return 0;
>>> +}
>>> +
>>
>> These seem like they'd potentially be useful outside the context of SL,
>> maybe put them in a more generic location? Very much a nice to have, not
>> a blocker from my side.
> 
> Yea we can look into finding a nice home somewhere in the TPM event log 
> code for these.

After looking at it, it seems we would have to drag a whole bunch of TXT 
related structures into the TPM event log code. I don't think this is 
really worth it for what these functions do.

Thanks
Ross

> 
>>
>>> +/*
>>> + * External functions avalailable in mainline kernel.
>>
>> Nit: "available"
> 
> Ack
> 
> Thanks
> 
>>
>