Received: by 2002:a05:7412:f589:b0:e2:908c:2ebd with SMTP id eh9csp909947rdb; Wed, 1 Nov 2023 06:26:31 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHSqCgb2+R1RNmhc6Z2BGsUb4dIoK/dUAIpVa7YwF+RLbh+JvH5TF6NMBWUFhTawf5YZr8m X-Received: by 2002:a17:902:e0c5:b0:1c8:8f5f:b610 with SMTP id e5-20020a170902e0c500b001c88f5fb610mr13360980pla.13.1698845190807; Wed, 01 Nov 2023 06:26:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698845190; cv=none; d=google.com; s=arc-20160816; b=qhRF/xWR1xKoClqr0JwESstc32mycLEg1C4lzTZLv8t+OeNF39iy+6rXARq82xYOy7 zciJZ1eB0/hsedHUwWa1S+Q2OhBnGH0RUfkDt5qko2ZKMfD70M5B6ErU7Jlwc6wFmoVZ xFreX7nhPlQAt1XGThq33VyzAbXHXS/yHJqaa0U362aUYdPWgmqUPVyDkHu2PRS6cXEr w02iBYi+9zgK/7qZtN5XmoJJRRtwlwioJXVg2Jlh6lpxmOKg1nI0JGDWrelT5DYhwADT CZfflUfS8+1HEbp2C+5ABn/6O4AuhysoMdnwf2JylpOnb2uEvXt4ouWOcQzIBehCcMSY eCIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=5vuuw2hgFSjYMbIsoJnBkA458K2z+JiLRYE0TFB3z/Q=; fh=ZdtpZ5SsL3kukRhdoMWboBohfEvfKNpbNDVMTDejI7k=; b=HSTXRcfw1EGrgW+GtmDjpvBspPzC4z5AM2qodPqQyaGmXhznA2FQB3UUoV5tBEBHxQ 23AqBxsEyKoL6q9zoMCeuaxUTT56khEDIrEk7PWSeAzVs0M0SzEnNpZGKRCvXWQwepYo zVJ8VqsuKt9U+jft53t8N1AgauSfgTs1HbOKupM/JZva98TfShzVq8lM/9VsarfdbUcm /vUV22Zvov7HrGrlo5x9yWndLjve7sh24lJfxXYPtlt8uuN4KOkoXCcvH7Zjz136l7Tr R8uUbWTU6Q0o2SwGR2JvGajeaz9qglR+/8r5IXtXdVUhrQeSnbCl8aMdzTnSgLcsz2sD o3pA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=FyDwE40i; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from groat.vger.email (groat.vger.email. [2620:137:e000::3:5]) by mx.google.com with ESMTPS id z11-20020a170903018b00b001cc47e75d58si3235499plg.512.2023.11.01.06.26.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Nov 2023 06:26:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=FyDwE40i; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 9BC04807744E; Wed, 1 Nov 2023 06:26:25 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343828AbjKAN00 (ORCPT + 99 others); Wed, 1 Nov 2023 09:26:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45758 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344071AbjKAN0Z (ORCPT ); Wed, 1 Nov 2023 09:26:25 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C4E5D103 for ; Wed, 1 Nov 2023 06:25:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1698845142; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5vuuw2hgFSjYMbIsoJnBkA458K2z+JiLRYE0TFB3z/Q=; b=FyDwE40id3B+I1StnmclzA7Zb2ect/dG8dNPflteUutQQpIdLIFbVUgftnPdaGqq6TENQg IiCllp/pYdKA9nPmyma9PIVoxVRtKBH+TxjAU27Mo/NypaNBSvLTFkJExIh+gKc+ZYDCmO GA8HF4r6oojvWFwWxhQ1jDWxKFxHWro= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-319-9xMMn1IYP0KOZYPpfTEUVQ-1; Wed, 01 Nov 2023 09:25:40 -0400 X-MC-Unique: 9xMMn1IYP0KOZYPpfTEUVQ-1 Received: by mail-ej1-f69.google.com with SMTP id a640c23a62f3a-9a62adedadbso475248166b.1 for ; Wed, 01 Nov 2023 06:25:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698845139; x=1699449939; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=5vuuw2hgFSjYMbIsoJnBkA458K2z+JiLRYE0TFB3z/Q=; b=A+TTRyHjox4pBFmiNCVB7FmKx5ZDiHk77xgSWnE9vdq4V919jkEMkfKJUwgWSWRWEN gnpck/Bhbk1ehSeWGRo39VbOjuN/hhDoU43vzR4njGtfZjc6sUV0IiL3JqjF1zZVrNfq +qC3Cxoh10lwqWZ2Chgw/uG//qWOAK03nKRbPS0yNFjNuoIyLHF+U20IWs9HPXM1p9kA kJVv+NrrTcaDV6kRZHjWWwh5lKvoOKN/F4kVCbA0Y5uF5IpNhCBUnz1hAEW0fuFU8bsO w50QrZNym6Zq3zpYsF2FvkOe4hb65REBMrZ+AG3wlQV8BQZU5mMaF8ESQxqICrNCWInt bpHw== X-Gm-Message-State: AOJu0YwApVrVWyX6l2i26E5pHbgV758MAnNnJYXfyIsw2Ze3qMWHwCIs yePkTmHMF7RvbYlWdNOhqm/cwQMlxe2cfEFEpT960cEpkGEdY4zSvx8s/m2PTI8SByq4OINNVSx AGh1LCS27xrm/4AH5Lkj9yWJP X-Received: by 2002:a17:907:da1:b0:9d7:139:ca02 with SMTP id go33-20020a1709070da100b009d70139ca02mr1593789ejc.18.1698845139551; Wed, 01 Nov 2023 06:25:39 -0700 (PDT) X-Received: by 2002:a17:907:da1:b0:9d7:139:ca02 with SMTP id go33-20020a1709070da100b009d70139ca02mr1593777ejc.18.1698845139229; Wed, 01 Nov 2023 06:25:39 -0700 (PDT) Received: from redhat.com ([2a02:14f:1f7:e470:9af7:1504:1b35:8a09]) by smtp.gmail.com with ESMTPSA id cl21-20020a170906c4d500b0099bd1a78ef5sm2397533ejb.74.2023.11.01.06.25.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Nov 2023 06:25:38 -0700 (PDT) Date: Wed, 1 Nov 2023 09:25:33 -0400 From: "Michael S. Tsirkin" To: Halil Pasic Cc: "Gonglei (Arei)" , Herbert Xu , Jason Wang , "virtualization@lists.linux-foundation.org" , "linux-kernel@vger.kernel.org" , "linux-crypto@vger.kernel.org" , Marc Hartmayer Subject: Re: virtcrypto_dataq_callback calls crypto_finalize_request() from irq context Message-ID: <20231101092521-mutt-send-email-mst@kernel.org> References: <20230922154546.4f7447ce.pasic@linux.ibm.com> <20230924193941.6a02237f.pasic@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230924193941.6a02237f.pasic@linux.ibm.com> X-Spam-Status: No, score=-1.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Wed, 01 Nov 2023 06:26:26 -0700 (PDT) On Sun, Sep 24, 2023 at 07:39:41PM +0200, Halil Pasic wrote: > On Sun, 24 Sep 2023 11:56:25 +0000 > "Gonglei (Arei)" wrote: > > > Hi Halil, > > > > Commit 4058cf08945 introduced a check for detecting crypto completion function > > called with enable BH, and indeed the virtio-crypto driver didn't disable BH, which needs > > a patch to fix it. > > > > P.S.: https://lore.kernel.org/lkml/20220221120833.2618733-5-clabbe@baylibre.com/T/ > > > > Regards, > > -Gonglei > > Thanks Gonglei! > > Thanks! I would be glad to test that fix on s390x. Are you about to send > one? > > Regards, > Halil Gonglei did you intend to send a fix?