Received-SPF: pass (google.com: domain of linux-crypto+bounces-183-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Precedence: bulk
MIME-Version: 1.0
References: <20231118225451.2132137-1-vadfed@meta.com>
In-Reply-To: <20231118225451.2132137-1-vadfed@meta.com>
From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Date: Sat, 18 Nov 2023 15:23:46 -0800
Message-ID: <CAADnVQLBE1ex-B=F07R0xQKo-r22M0L6eiS8DjOAtsur-hEbFQ@mail.gmail.com>
Subject: Re: [PATCH bpf-next v5 1/2] bpf: add skcipher API support to TC/XDP programs
To: Vadim Fedorenko <vadfed@meta.com>
Cc: Vadim Fedorenko <vadim.fedorenko@linux.dev>, Jakub Kicinski <kuba@kernel.org>, 
	Martin KaFai Lau <martin.lau@linux.dev>, Andrii Nakryiko <andrii@kernel.org>, 
	Alexei Starovoitov <ast@kernel.org>, Mykola Lysenko <mykolal@fb.com>, 
	Herbert Xu <herbert@gondor.apana.org.au>, Network Development <netdev@vger.kernel.org>, 
	Linux Crypto Mailing List <linux-crypto@vger.kernel.org>, bpf <bpf@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sat, Nov 18, 2023 at 2:55=E2=80=AFPM Vadim Fedorenko <vadfed@meta.com> w=
rote:
>
> +/**
> + * struct bpf_crypto_lskcipher_ctx - refcounted BPF sync skcipher contex=
t structure
> + * @tfm:       The pointer to crypto_sync_skcipher struct.
> + * @rcu:       The RCU head used to free the crypto context with RCU saf=
ety.
> + * @usage:     Object reference counter. When the refcount goes to 0, th=
e
> + *             memory is released back to the BPF allocator, which provi=
des
> + *             RCU safety.
> + */
> +struct bpf_crypto_lskcipher_ctx {
> +       struct crypto_lskcipher *tfm;
> +       struct rcu_head rcu;
> +       refcount_t usage;
> +};
> +
> +__bpf_kfunc_start_defs();
> +
> +/**
> + * bpf_crypto_lskcipher_ctx_create() - Create a mutable BPF crypto conte=
xt.

Let's drop 'lskcipher' from the kfunc names and ctx struct.
bpf users don't need to know the internal implementation details.
bpf_crypto_encrypt/decrypt() is clear enough.