Received-SPF: pass (google.com: domain of linux-crypto+bounces-192-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Precedence: bulk
MIME-Version: 1.0
References: <20231118225451.2132137-1-vadfed@meta.com> <20231118225451.2132137-2-vadfed@meta.com>
In-Reply-To: <20231118225451.2132137-2-vadfed@meta.com>
From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Date: Sun, 19 Nov 2023 13:58:01 -0800
Message-ID: <CAADnVQ+tLbMppLNT7HOV5=k+8075qjjyO5wWEDvLRoPi5WALJw@mail.gmail.com>
Subject: Re: [PATCH bpf-next v5 2/2] selftests: bpf: crypto skcipher algo selftests
To: Vadim Fedorenko <vadfed@meta.com>
Cc: Vadim Fedorenko <vadim.fedorenko@linux.dev>, Jakub Kicinski <kuba@kernel.org>, 
	Martin KaFai Lau <martin.lau@linux.dev>, Andrii Nakryiko <andrii@kernel.org>, 
	Alexei Starovoitov <ast@kernel.org>, Mykola Lysenko <mykolal@fb.com>, 
	Herbert Xu <herbert@gondor.apana.org.au>, Network Development <netdev@vger.kernel.org>, 
	Linux Crypto Mailing List <linux-crypto@vger.kernel.org>, bpf <bpf@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sat, Nov 18, 2023 at 2:55=E2=80=AFPM Vadim Fedorenko <vadfed@meta.com> w=
rote:
>
> +
> +SEC("fentry.s/bpf_fentry_test1")
> +int BPF_PROG(skb_crypto_setup)
> +{
> +       struct bpf_crypto_lskcipher_ctx *cctx;
> +       struct bpf_dynptr key =3D {};
> +       int err =3D 0;
> +
> +       status =3D 0;
> +
> +       bpf_dynptr_from_mem(crypto_key, sizeof(crypto_key), 0, &key);
> +       cctx =3D bpf_crypto_lskcipher_ctx_create(crypto_algo, &key, &err)=
;

Direct string will work here, right?
What's the reason to use global var?