Received-SPF: pass (google.com: domain of linux-crypto+bounces-193-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <ee9e6afb-479e-d38f-9424-5c79feded44d@linux.dev>
Date: Sun, 19 Nov 2023 23:52:51 +0000
Precedence: bulk
MIME-Version: 1.0
Subject: Re: [PATCH bpf-next v5 2/2] selftests: bpf: crypto skcipher algo
 selftests
Content-Language: en-US
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>,
 Vadim Fedorenko <vadfed@meta.com>
Cc: Jakub Kicinski <kuba@kernel.org>, Martin KaFai Lau
 <martin.lau@linux.dev>, Andrii Nakryiko <andrii@kernel.org>,
 Alexei Starovoitov <ast@kernel.org>, Mykola Lysenko <mykolal@fb.com>,
 Herbert Xu <herbert@gondor.apana.org.au>,
 Network Development <netdev@vger.kernel.org>,
 Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
 bpf <bpf@vger.kernel.org>
References: <20231118225451.2132137-1-vadfed@meta.com>
 <20231118225451.2132137-2-vadfed@meta.com>
 <CAADnVQ+tLbMppLNT7HOV5=k+8075qjjyO5wWEDvLRoPi5WALJw@mail.gmail.com>
From: Vadim Fedorenko <vadim.fedorenko@linux.dev>
In-Reply-To: <CAADnVQ+tLbMppLNT7HOV5=k+8075qjjyO5wWEDvLRoPi5WALJw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

On 19.11.2023 21:58, Alexei Starovoitov wrote:
> On Sat, Nov 18, 2023 at 2:55 PM Vadim Fedorenko <vadfed@meta.com> wrote:
>>
>> +
>> +SEC("fentry.s/bpf_fentry_test1")
>> +int BPF_PROG(skb_crypto_setup)
>> +{
>> +       struct bpf_crypto_lskcipher_ctx *cctx;
>> +       struct bpf_dynptr key = {};
>> +       int err = 0;
>> +
>> +       status = 0;
>> +
>> +       bpf_dynptr_from_mem(crypto_key, sizeof(crypto_key), 0, &key);
>> +       cctx = bpf_crypto_lskcipher_ctx_create(crypto_algo, &key, &err);
> 
> Direct string will work here, right?
> What's the reason to use global var?

Mmm, yeah, should work. I'll update the test, thanks!