Received-SPF: pass (google.com: domain of linux-crypto+bounces-409-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Content-Type: text/plain; charset="utf-8"
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20231129152145.7767-1-n.zhandarovich@fintech.ru>
References: <20231129152145.7767-1-n.zhandarovich@fintech.ru>
Subject: Re: [PATCH] crypto: safexcel - Add error handling for dma_map_sg() calls
From: Antoine Tenart <atenart@kernel.org>
Cc: Nikita Zhandarovich <n.zhandarovich@fintech.ru>, Herbert Xu <herbert@gondor.apana.org.au>, David S. Miller <davem@davemloft.net>, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
To: Nikita Zhandarovich <n.zhandarovich@fintech.ru>
Date: Thu, 30 Nov 2023 11:36:43 +0100
Message-ID: <170134060353.9758.8481937396435146454@kwain>

Hello Nikita,

Quoting Nikita Zhandarovich (2023-11-29 16:21:45)
>=20
> diff --git a/drivers/crypto/inside-secure/safexcel_cipher.c b/drivers/cry=
pto/inside-secure/safexcel_cipher.c
> index 272c28b5a088..ca660f31c15f 100644
> --- a/drivers/crypto/inside-secure/safexcel_cipher.c
> +++ b/drivers/crypto/inside-secure/safexcel_cipher.c
> @@ -742,9 +742,9 @@ static int safexcel_send_req(struct crypto_async_requ=
est *base, int ring,
>                                 max(totlen_src, totlen_dst));
>                         return -EINVAL;
>                 }
> -               if (sreq->nr_src > 0)
> -                       dma_map_sg(priv->dev, src, sreq->nr_src,
> -                                  DMA_BIDIRECTIONAL);
> +               if ((sreq->nr_src > 0) &&
> +                   (!dma_map_sg(priv->dev, src, sreq->nr_src, DMA_BIDIRE=
CTIONAL)))
> +                       return -ENOMEM;

You can remove one level of parenthesis. Also I'm not sure -ENOMEM is
the right error to return. Looking around it seems people got creative
about that, IMHO -EIO would be best, but not 100% sure.

Same comments for the other chunks.

Thanks,
Antoine