Received: by 2002:a05:7412:b10a:b0:f3:1519:9f41 with SMTP id az10csp883265rdb; Fri, 1 Dec 2023 00:40:14 -0800 (PST) X-Google-Smtp-Source: AGHT+IHtkmRM8WE1+M4vzWU2TDIAsAPX31KW9BLTWe0IfSaeCVzyh2tOtyXF7uQd1FwGOJT8MRpC X-Received: by 2002:a05:6a21:2724:b0:15b:c800:48af with SMTP id rm36-20020a056a21272400b0015bc80048afmr20636318pzb.23.1701420014672; Fri, 01 Dec 2023 00:40:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701420014; cv=none; d=google.com; s=arc-20160816; b=BpNZgjLjHO4wWMoFwdkBrJ795v8q7uR4t59LtuI7dpZC2Ghzx07J+7dXXq43jKmjIZ SIDTUfkO2dRV9ULF4mYs8EvTaWOSCwpcPIMbG/9Jij5iaAENINwxzaAiVP6RYiR9ojku RrZAMhoGMX6MEGHHec67mNi445QRt+0Ln7ARwj670/dIBKZNVvt7aROz/thL31QhGein 5dm6jTviOBddz5t+ujnFXyhln11WfBcERji1Zl9epjIjpg7SupFKUZTv0D1ec1+z84n2 l3UY57NjTquevscaPhrn26NQSTjE+7FgWorRSiiav1aOfe13J3TI/9KqCdnMwOMda0YH oAzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from; bh=ktCpm0cYH80plU7aTI6HWCg1vmORejiKOSIJbukjPPM=; fh=ZB6potfRA4mQgK7jo/Em9quxUaPMvmFZ/U7nUDImqas=; b=Ct1Ha5Ssf0A1RJ7T07EzWhPfrwIxbg18xjDOvJuA/y/Jq4Ngqhhh95XwT4p2hT696z /U85xRusxriCzv/d+OEqOeDtS927Nd/EL17NkE1Ae4wcgPEHG2icIHHrjjgYQzFGxN5s s/ne2qcka63xcNFiuhm+JzZEKa3Q9aPn3sbBG8h9ghjek7Dg7tg38kTMSYLwh4B6WpmF S/C0G0PUbgf0x1dgM0i1ZWwS2DkWMgwfOm3BKcWjl2SI1oOmH2IaeWnqHIfdvn7MV0fo mhN/mMWN1+RMNuqZ++Gy3j30hBhNbmCgP7rpSfUertwOc/2RVHoqyKpNFoIHri/Z0jNx pO5g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto+bounces-439-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-crypto+bounces-439-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id u3-20020a63f643000000b00578e0ff59bbsi3033065pgj.865.2023.12.01.00.40.14 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Dec 2023 00:40:14 -0800 (PST) Received-SPF: pass (google.com: domain of linux-crypto+bounces-439-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto+bounces-439-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-crypto+bounces-439-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 8DF9EB20EB5 for ; Fri, 1 Dec 2023 08:40:11 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 234E51C681 for ; Fri, 1 Dec 2023 08:40:10 +0000 (UTC) X-Original-To: linux-crypto@vger.kernel.org Received: from dggsgout11.his.huawei.com (unknown [45.249.212.51]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 89BF410FF for ; Fri, 1 Dec 2023 00:16:49 -0800 (PST) Received: from mail.maildlp.com (unknown [172.19.93.142]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4ShQrX3Cz0z4f3jqX for ; Fri, 1 Dec 2023 16:16:44 +0800 (CST) Received: from mail02.huawei.com (unknown [10.116.40.112]) by mail.maildlp.com (Postfix) with ESMTP id 6438B1A01D7 for ; Fri, 1 Dec 2023 16:16:45 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.103.91]) by APP1 (Coremail) with SMTP id cCh0CgCn9gxplmllkWe4CQ--.30052S4; Fri, 01 Dec 2023 16:16:45 +0800 (CST) From: Yang Yingliang To: linux-crypto@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com Cc: herbert@gondor.apana.org.au, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, gatien.chevallier@foss.st.com, yangyingliang@huawei.com Subject: [PATCH] hwrng: stm32 - add missing clk_disable_unprepare() in stm32_rng_init() Date: Fri, 1 Dec 2023 16:20:48 +0800 Message-Id: <20231201082048.1975940-1-yangyingliang@huaweicloud.com> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-crypto@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID:cCh0CgCn9gxplmllkWe4CQ--.30052S4 X-Coremail-Antispam: 1UD129KBjvdXoWrKrW8trW8Aw4ktrW8uF1kGrg_yoWfJrg_CF 1xZ3yIgFyIgFy7Aw1qv3WUX34F9rZ8urWvgws2vw45GFy7Zw4Yqr10qwsayry7CrWDKF95 AF97tw1SvrnFyjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUboAYFVCjjxCrM7AC8VAFwI0_Gr0_Xr1l1xkIjI8I6I8E6xAIw20E Y4v20xvaj40_Wr0E3s1l1IIY67AEw4v_Jr0_Jr4l8cAvFVAK0II2c7xJM28CjxkF64kEwV A0rcxSw2x7M28EF7xvwVC0I7IYx2IY67AKxVW7JVWDJwA2z4x0Y4vE2Ix0cI8IcVCY1x02 67AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVAFwI0_GcCE3s1l84ACjcxK6I8E87Iv6xkF7I 0E14v26rxl6s0DM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40E x7xfMcIj6xIIjxv20xvE14v26r1Y6r17McIj6I8E87Iv67AKxVWUJVW8JwAm72CE4IkC6x 0Yz7v_Jr0_Gr1lF7xvr2IYc2Ij64vIr41l42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Y z7v_Jr0_Gr1lx2IqxVAqx4xG67AKxVWUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zV AF1VAY17CE14v26r126r1DMIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4l IxAIcVC0I7IYx2IY6xkF7I0E14v26r1j6r4UMIIF0xvE42xK8VAvwI8IcIk0rVWrZr1j6s 0DMIIF0xvEx4A2jsIE14v26r1j6r4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Gr0_Gr1UYxBI daVFxhVjvjDU0xZFpf9x07UGYL9UUUUU= X-CM-SenderInfo: 51dqw5xlqjzxhdqjqx5xdzvxpfor3voofrz/ From: Yang Yingliang Add clk_disable_unprepare() in the error path in stm32_rng_init(). Fixes: 6b85a7e141cb ("hwrng: stm32 - implement STM32MP13x support") Signed-off-by: Yang Yingliang --- drivers/char/hw_random/stm32-rng.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/char/hw_random/stm32-rng.c b/drivers/char/hw_random/stm32-rng.c index 41e1dbea5d2e..efd6edcd7066 100644 --- a/drivers/char/hw_random/stm32-rng.c +++ b/drivers/char/hw_random/stm32-rng.c @@ -325,6 +325,7 @@ static int stm32_rng_init(struct hwrng *rng) (!(reg & RNG_CR_CONDRST)), 10, 50000); if (err) { + clk_disable_unprepare(priv->clk); dev_err((struct device *)priv->rng.priv, "%s: timeout %x!\n", __func__, reg); return -EINVAL; -- 2.25.1