Received-SPF: pass (google.com: domain of linux-crypto+bounces-453-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <94981d84-52c4-4c9a-8042-c622d73d1e0e@foss.st.com>
Date: Fri, 1 Dec 2023 11:18:59 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] hwrng: stm32 - add missing clk_disable_unprepare() in
 stm32_rng_init()
To: Yang Yingliang <yangyingliang@huaweicloud.com>,
        <linux-crypto@vger.kernel.org>,
        <linux-stm32@st-md-mailman.stormreply.com>
CC: <herbert@gondor.apana.org.au>, <mcoquelin.stm32@gmail.com>,
        <alexandre.torgue@foss.st.com>, <yangyingliang@huawei.com>
References: <20231201082048.1975940-1-yangyingliang@huaweicloud.com>
Content-Language: en-US
From: Gatien CHEVALLIER <gatien.chevallier@foss.st.com>
In-Reply-To: <20231201082048.1975940-1-yangyingliang@huaweicloud.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit

Hi Yang,

Good spot, thank you.

Reviewed-by: Gatien Chevallier <gatien.chevallier@foss.st.com>

Best regards,
Gatien

On 12/1/23 09:20, Yang Yingliang wrote:
> From: Yang Yingliang <yangyingliang@huawei.com>
> 
> Add clk_disable_unprepare() in the error path in stm32_rng_init().
> 
> Fixes: 6b85a7e141cb ("hwrng: stm32 - implement STM32MP13x support")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
>   drivers/char/hw_random/stm32-rng.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/char/hw_random/stm32-rng.c b/drivers/char/hw_random/stm32-rng.c
> index 41e1dbea5d2e..efd6edcd7066 100644
> --- a/drivers/char/hw_random/stm32-rng.c
> +++ b/drivers/char/hw_random/stm32-rng.c
> @@ -325,6 +325,7 @@ static int stm32_rng_init(struct hwrng *rng)
>   							(!(reg & RNG_CR_CONDRST)),
>   							10, 50000);
>   		if (err) {
> +			clk_disable_unprepare(priv->clk);
>   			dev_err((struct device *)priv->rng.priv,
>   				"%s: timeout %x!\n", __func__, reg);
>   			return -EINVAL;