Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp326861rdb; Tue, 5 Dec 2023 06:37:46 -0800 (PST) X-Google-Smtp-Source: AGHT+IF7WV9t4YmxC+lYOzML4ZlnpsqML467ivIEfPOi9IsVxD3ammrIN71hrpde4CSDicEIO4Js X-Received: by 2002:a05:6a00:a29:b0:6cb:bb92:1ce6 with SMTP id p41-20020a056a000a2900b006cbbb921ce6mr1449118pfh.18.1701787065747; Tue, 05 Dec 2023 06:37:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701787065; cv=none; d=google.com; s=arc-20160816; b=jSlnRQsJnX68meBWutrPRbFSxy1jgnsz7sk7ibCmkagz+NfdoV1gJRRVj/4/lv2NZL xRrFTTqx35Eo+B+v+6HO7CPIPWU66uiCNbHToINN03g3vY4jDVPtv7f6cg+uu4aoq0La PLY8ewBbhUlbaCxlX4GGl1NBsVw9T/l/Wfu/42qirRHj7GsTcu90RqpKRPzTEfzrfQut AE+YtVJdMW1+ALE0buPDF3hmYnM448Nd36LRB1FBRR+34iwImoUu53pUxe9OejToJ17i mM7/G3K2iSWKgsRUwboFk7cKG1/ti7itPVQO4qs0kr21aoSF6MisYPQEmPep5r7mf+da WUCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:dkim-signature; bh=T7XU6GHHiBgdkrXmdGsRu2k0uowM8mZD/GX6dh9pTT4=; fh=JBV+SmA05k12BmnkvNrYeJGQ5m3DPnyHstdyt9/6DB4=; b=x2k6psVfY2ioMoWNRV08613P1tNw79lY1s8L1jmMmTsSRO0zYOmY8VIaHmVdYbiIac 5MXv9HLxNQjRt05dRO4yhWPFd8eKb3/98vyC6eW8C7E7o81T1/U9gASFIVsRzHMvmL1y Y9eCoH8zijyzI8sxomJ5cNUoe8+uwtF1lLNvr9dW4jcR7kATup8ZizGGGxluz2vQw9PK 12Ukbelfz7Sl64+sQ++ldLgBt6k+2F/9Td5u68R53toBpIWmJgnEwRuN9EsPJrqWSGly Yk/bGIVapyFthjw9o2TWfpdBluuFtpbyzYksK0MT4iPRQ9c9P9D24hq8lURYeYB7j0Si Z+2A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=bTic1WUZ; spf=pass (google.com: domain of linux-crypto+bounces-575-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-crypto+bounces-575-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id bv8-20020a056a00414800b006ce719a5927si924842pfb.255.2023.12.05.06.37.45 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Dec 2023 06:37:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-crypto+bounces-575-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=bTic1WUZ; spf=pass (google.com: domain of linux-crypto+bounces-575-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-crypto+bounces-575-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 7B6A1B20E19 for ; Tue, 5 Dec 2023 14:37:41 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id EE726584C7 for ; Tue, 5 Dec 2023 14:37:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bTic1WUZ" X-Original-To: linux-crypto@vger.kernel.org Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com [IPv6:2a00:1450:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E2B4AA1 for ; Tue, 5 Dec 2023 06:23:58 -0800 (PST) Received: by mail-ej1-x62a.google.com with SMTP id a640c23a62f3a-a1b6b65923eso318024866b.3 for ; Tue, 05 Dec 2023 06:23:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701786237; x=1702391037; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=T7XU6GHHiBgdkrXmdGsRu2k0uowM8mZD/GX6dh9pTT4=; b=bTic1WUZZIDioBcJjLFmlgmec4z3xPLXPR6cZ4cw34EWiVZQF76MaPa3cnILBZ/A0Y rzDOan2uT+U+C1wuN7hjfegbrspxmRu0gBIt+zOcfOU8RIrBPLgCgggnZ1+1af1Leftk gwNs+ea7fBlqTHtQ/n4ZOGfIEJiYzsOEPQeVRW7gZfHehFcn7KdNPWee52WGuhJHmfox 1ykQFKXqRF3mq/gIvI7BCZDlaTQT604WS1/ukvr+1ckr3GpxdLFLIf8SpYw+t3L3zutD BPUEYByqCiFgi1V0adrEiCOuKoQAQGjxmwNO43m5i4ED82SyZolUa2j4BD9hqAY8GSL3 sJZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701786237; x=1702391037; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=T7XU6GHHiBgdkrXmdGsRu2k0uowM8mZD/GX6dh9pTT4=; b=RoWikgSojcUSYgACakUnI5lHq26NwROww8ow0HMxIfvsE2THeaKH7W1FnNWE7dQtkH ol4TD/XbJEAbBEQxgXpVU9O1IlMa8q+sYZXiCBR2KnUaYO1MMOADJ3qVleaE+jGVTq02 ZyIcPh91IEBR2h+mK0NP+sG11MxnNgIcWRaWAX2D4ZqCDI4vxJW1Gvnkup1+Mbibjn9r TzxS1QFeR8j+HL+hdCfvCkdjX7Au3n/Ye51vxYf8uZXfUKmQohXIULbQUWCWqRDZKAfi FJFwegbMEzbSJjWIhzQjNgSWST0X74UqWoM9E3D944Jocx9un5DLlQTToobCDXCG+8nD 7bpA== X-Gm-Message-State: AOJu0Yx+DqEWGBI014zJ23vH8N6UU0d/YcstMJ/K4wLAPNSncRw/ZzMI x+cDmHRd4HMiPAErTEF/RlhIwBRaAIGErTL8ol8= X-Received: by 2002:a17:906:73cf:b0:a1c:c376:85ca with SMTP id n15-20020a17090673cf00b00a1cc37685camr248747ejl.216.1701786236507; Tue, 05 Dec 2023 06:23:56 -0800 (PST) Precedence: bulk X-Mailing-List: linux-crypto@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <5a0e8b44-6feb-b489-cdea-e3be3811804a@linux.alibaba.com> <649a3bc4-58bb-1dc8-85fb-a56e47b3d5c9@linux.alibaba.com> <275f025d-e2f1-eaff-6af1-e909d370cee0@linux.alibaba.com> In-Reply-To: From: Juhyung Park Date: Tue, 5 Dec 2023 23:23:44 +0900 Message-ID: Subject: Re: Weird EROFS data corruption To: Gao Xiang Cc: Gao Xiang , linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, linux-crypto@vger.kernel.org, Yann Collet Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Gao, On Tue, Dec 5, 2023 at 4:32=E2=80=AFPM Gao Xiang wrote: > > Hi Juhyung, > > On 2023/12/4 11:41, Juhyung Park wrote: > > ... > > > >> > >> - Could you share the full message about the output of `lscpu`? > > > > Sure: > > > > Architecture: x86_64 > > CPU op-mode(s): 32-bit, 64-bit > > Address sizes: 39 bits physical, 48 bits virtual > > Byte Order: Little Endian > > CPU(s): 8 > > On-line CPU(s) list: 0-7 > > Vendor ID: GenuineIntel > > BIOS Vendor ID: Intel(R) Corporation > > Model name: 11th Gen Intel(R) Core(TM) i7-1185G7 @ 3.00GH= z > > BIOS Model name: 11th Gen Intel(R) Core(TM) i7-1185G7 @ 3.00GH= z None CPU > > @ 3.0GHz > > BIOS CPU family: 198 > > CPU family: 6 > > Model: 140 > > Thread(s) per core: 2 > > Core(s) per socket: 4 > > Socket(s): 1 > > Stepping: 1 > > CPU(s) scaling MHz: 60% > > CPU max MHz: 4800.0000 > > CPU min MHz: 400.0000 > > BogoMIPS: 5990.40 > > Flags: fpu vme de pse tsc msr pae mce cx8 apic sep m= trr pge mc > > a cmov pat pse36 clflush dts acpi mmx fxsr ss= e sse2 ss > > ht tm pbe syscall nx pdpe1gb rdtscp lm consta= nt_tsc art > > arch_perfmon pebs bts rep_good nopl xtopolog= y nonstop_ > > tsc cpuid aperfmperf tsc_known_freq pni pclmu= lqdq dtes6 > > 4 monitor ds_cpl vmx smx est tm2 ssse3 sdbg f= ma cx16 xt > > pr pdcm pcid sse4_1 sse4_2 x2apic movbe popcn= t tsc_dead > > line_timer aes xsave avx f16c rdrand lahf_lm = abm 3dnowp > > refetch cpuid_fault epb cat_l2 cdp_l2 ssbd ib= rs ibpb st > > ibp ibrs_enhanced tpr_shadow flexpriority ept= vpid ept_ > > ad fsgsbase tsc_adjust bmi1 avx2 smep bmi2 er= ms invpcid > > rdt_a avx512f avx512dq rdseed adx smap avx51= 2ifma clfl > > ushopt clwb intel_pt avx512cd sha_ni avx512bw= avx512vl > > xsaveopt xsavec xgetbv1 xsaves split_lock_det= ect dtherm > > ida arat pln pts hwp hwp_notify hwp_act_wind= ow hwp_epp > > hwp_pkg_req vnmi avx512vbmi umip pku ospke a= vx512_vbmi > > 2 gfni vaes vpclmulqdq avx512_vnni avx512_bit= alg tme av > > x512_vpopcntdq rdpid movdiri movdir64b fsrm a= vx512_vp2i > > Sigh, I've been thinking. Here FSRM is the most significant difference b= etween > our environments, could you only try the following diff to see if there's= any > difference anymore? (without the previous disable patch.) > > diff --git a/arch/x86/lib/memmove_64.S b/arch/x86/lib/memmove_64.S > index 1b60ae81ecd8..1b52a913233c 100644 > --- a/arch/x86/lib/memmove_64.S > +++ b/arch/x86/lib/memmove_64.S > @@ -41,9 +41,7 @@ SYM_FUNC_START(__memmove) > #define CHECK_LEN cmp $0x20, %rdx; jb 1f > #define MEMMOVE_BYTES movq %rdx, %rcx; rep movsb; RET > .Lmemmove_begin_forward: > - ALTERNATIVE_2 __stringify(CHECK_LEN), \ > - __stringify(CHECK_LEN; MEMMOVE_BYTES), X86_FEATURE_= ERMS, \ > - __stringify(MEMMOVE_BYTES), X86_FEATURE_FSRM > + CHECK_LEN > > /* > * movsq instruction have many startup latency Yup, that also seems to fix it. Are we looking at a potential memmove issue? > > Thanks, > Gao Xiang