Received-SPF: pass (google.com: domain of linux-crypto+bounces-740-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: Lukasz Stelmach <l.stelmach@samsung.com>
To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
Cc: Olivia Mackall <olivia@selenic.com>,  Herbert Xu
	<herbert@gondor.apana.org.au>,  Krzysztof Kozlowski
	<krzysztof.kozlowski@linaro.org>,  Alim Akhtar <alim.akhtar@samsung.com>,
	linux-samsung-soc@vger.kernel.org,  linux-crypto@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,  kernel@pengutronix.de
Subject: Re: [PATCH 03/12] hwrng: exynos - Convert to platform remove
 callback returning void
Date: Tue, 12 Dec 2023 10:31:32 +0100
In-Reply-To: <817e91f7bb257745c0fb483037b83c1a6ba14e75.1702245873.git.u.kleine-koenig@pengutronix.de>
	("Uwe =?utf-8?Q?Kleine-K=C3=B6nig=22's?= message of "Sun, 10 Dec 2023
	23:12:18 +0100")
Message-ID: <oypijdfs07937v.fsf%l.stelmach@samsung.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-="; micalg="pgp-sha256";
	protocol="application/pgp-signature"
CMS-TYPE: 201P
References: <817e91f7bb257745c0fb483037b83c1a6ba14e75.1702245873.git.u.kleine-koenig@pengutronix.de>
	<CGME20231212093133eucas1p1c19ba5aa058ca1e159bfd070aec0f306@eucas1p1.samsung.com>

--=-=-=
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

It was <2023-12-10 nie 23:12>, when Uwe Kleine-K=C3=B6nig wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
>
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new(), which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-K=C3=B6nig <u.kleine-koenig@pengutronix.de>
> ---
>  drivers/char/hw_random/exynos-trng.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>

Acked-by: Lukasz Stelmach <l.stelmach@samsung.com>

> diff --git a/drivers/char/hw_random/exynos-trng.c b/drivers/char/hw_rando=
m/exynos-trng.c
> index 30207b7ac5f4..0ed5d22fe667 100644
> --- a/drivers/char/hw_random/exynos-trng.c
> +++ b/drivers/char/hw_random/exynos-trng.c
> @@ -173,7 +173,7 @@ static int exynos_trng_probe(struct platform_device *=
pdev)
>  	return ret;
>  }
>=20=20
> -static int exynos_trng_remove(struct platform_device *pdev)
> +static void exynos_trng_remove(struct platform_device *pdev)
>  {
>  	struct exynos_trng_dev *trng =3D  platform_get_drvdata(pdev);
>=20=20
> @@ -181,8 +181,6 @@ static int exynos_trng_remove(struct platform_device =
*pdev)
>=20=20
>  	pm_runtime_put_sync(&pdev->dev);
>  	pm_runtime_disable(&pdev->dev);
> -
> -	return 0;
>  }
>=20=20
>  static int exynos_trng_suspend(struct device *dev)
> @@ -223,7 +221,7 @@ static struct platform_driver exynos_trng_driver =3D {
>  		.of_match_table =3D exynos_trng_dt_match,
>  	},
>  	.probe =3D exynos_trng_probe,
> -	.remove =3D exynos_trng_remove,
> +	.remove_new =3D exynos_trng_remove,
>  };
>=20=20
>  module_platform_driver(exynos_trng_driver);

=2D-=20
=C5=81ukasz Stelmach
Samsung R&D Institute Poland
Samsung Electronics

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEXpuyqjq9kGEVr9UQsK4enJilgBAFAmV4KHQACgkQsK4enJil
gBCRvQf+PyurfFZWbPslu37bFwG3yyfvKYGrFjJYjQl2baKl3uF9IRWnKIxklNqw
FARwvOuCuSVyWJNRRAHrATFZ5wls96Pc0UU+BBExjIze+5babcF6yxAchQ/iaFj1
gGOJzfEcLHXLZKGXOG5hYiaxf8rE4YAyu6ny1xXWkRSmE5+Q8foxCV5WFQm/M7nZ
8bzOkGaIrpIjvFHqzAX5EWiysKqDkvH+3zZZofacSzu/mghR0dYhmwu2zzsz4S2i
ZZ2WDOQh5rGzo9shSPlN95x7zSxIHv668dxki239m89AifAB2pdpaScoxXEGY2W2
lvUkbzHnJnV2TZzEyDEcwejvkQy+RQ==
=keMH
-----END PGP SIGNATURE-----
--=-=-=--