Received-SPF: pass (google.com: domain of linux-crypto+bounces-821-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <3287f6c9d5fb68a8ef915c0e7af8f3a6a262cd89.camel@linux.intel.com>
Subject: Re: [PATCH] crypto: tcrypt - add script tcrypt_speed_compare.py
From: Tim Chen <tim.c.chen@linux.intel.com>
To: Wang Jinchao <wangjinchao@xfusion.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>, "David S. Miller"
 <davem@davemloft.net>, Steffen Klassert <steffen.klassert@secunet.com>, 
 Daniel Jordan <daniel.m.jordan@oracle.com>, linux-crypto@vger.kernel.org,
 linux-kernel@vger.kernel.org,  stone.xulei@xfusion.com
Date: Wed, 13 Dec 2023 15:03:02 -0800
In-Reply-To: <ZXkecmQGYT81R17C@fedora>
References: <202312101758+0800-wangjinchao@xfusion.com>
	 <118d0b232f7daffc56db814f90dba7bad266c5ab.camel@linux.intel.com>
	 <ZXkecmQGYT81R17C@fedora>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4 (3.44.4-2.fc36) 
Precedence: bulk
MIME-Version: 1.0

On Wed, 2023-12-13 at 11:01 +0800, Wang Jinchao wrote:
> On Tue, Dec 12, 2023 at 01:56:56PM -0800, Tim Chen wrote:
> > On Sun, 2023-12-10 at 18:19 +0800, WangJinchao wrote:
> > > Create a script for comparing tcrypt speed test logs.
> > > The script will systematically analyze differences item
> > > by item and provide a summary (average).
> > > This tool is useful for evaluating the stability of
> > > cryptographic module algorithms and assisting with
> > > performance optimization.
> >=20
> > I have found that for such comparison, the stability is
> > dependent on whether we allow the frequency to
> > float or we pin the frequency.  So in the past when
> > I use tcrypt, sometimes I have
> > to pin the frequency of CPU for stable results.
> >=20
> > One suggestion I have is for for you to also dump the
> > frequency governor and P-state info so we know
> > for the runs being compared, whether they are running
> > with the same CPU frequency.
> >=20
> > Tim=20
> >=20
> Thank you for the feedback. This information is valuable for stability te=
sting
> and performance optimization.
>=20
> However, I am uncertain about how to dump P-state information, or I belie=
ve that
> the script is unable to do so. The reasons are as follows:
>=20
> 1. The primary purpose of this script is to compare tcrypt logs, and it i=
s
> executed after the completion of the tcrypt tests. Consequently, it canno=
t
> dump P-state information during tcrypt's runtime.
>=20
> 2. In virtualized environments, there is no available information in the
> `/sys/devices/system/cpu/cpufreq` directory pertaining to P-state details=
.
>=20
> Am I correct in my understanding?
> I am considering documenting your suggestion in the script's comments.
> What are your thoughts?
> >=20
I think that will be fine.=20

Thanks.

Tim