Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp5779708rdb; Wed, 13 Dec 2023 21:41:39 -0800 (PST) X-Google-Smtp-Source: AGHT+IHohpaJD8SrIQEqcFfweVD7J+QeUxwlqE7eMsZeZaq0neKOFMjQoc6DR2s7gLqGtt972rir X-Received: by 2002:a17:906:2d6:b0:a1f:8aa3:2bd4 with SMTP id 22-20020a17090602d600b00a1f8aa32bd4mr3935417ejk.133.1702532499510; Wed, 13 Dec 2023 21:41:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702532499; cv=none; d=google.com; s=arc-20160816; b=l7M9B7CqXYtIlIj1RgLZ8ve4/1DWcgvLe9zbnfFIwy2MclAi2zNrXfOVfP5s6sXJRw eOMHG+pTQ/SVkjgVl0WpB5cRTg7yqveEdBEoVBeWEZ5EDDeqrPAqUvoU3ysnuApD2N8Q 28meYc+5mx4itYZT1X+W4AaIaTOsXKWPbpA16JI3UNJHBdr/p/LZVJxifFJxpdz7pPE9 8Qb+4c+/rBcIdZax5rTU7kBBWBePQxPE4zRopju6m6VIISCLFROZ0YwU/RUJUQgTU4LS ypDf2WNIv1hPJaxn1ZfTEIg9JM1nhCN88wAHLvhQqZB4R14boYtgryxLKPgvYpMjmFpO tC+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=WnR2V1HDkmW5PBc0e7CWYokozIJgAwQp5DJQVrfapxQ=; fh=HgRxQgrYwRqzyNT/OrblVZKB1IgHE4gYCZ2F3dfjncU=; b=tBKyEN3W+yanesE1GxRcvS76o+0ST33rViHfVfklQpj049QDe+gb2Q+pzLchbQnm4g aQlFqRhp0EVNccVAQGuwIyXmPU+dBe/ruzfFdeQa7F+ncVa7MGdBTomrODOH+g2b+A5c yxxUMwvcI7j/DqJj/+gZ8dzUm+MSe4kr8GQFVwZkcefYZ5WzBosJKZ2u1sG2lDBv6497 Xl5cm7FmuISVH/xBPV57T4KXGxwea3tT/A0vSTQwNoQPr1KqRAr7cW1H1AZJSqIl+zr3 E3QM3KPdNZkOrBjK9NnomoNQCjZ6TtxIOl6WZTji9vYAHY0NHre+eYWRyzCShv4YAkJW Y3Cw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=OVgZWnyy; spf=pass (google.com: domain of linux-crypto+bounces-825-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-crypto+bounces-825-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id gh24-20020a170906e09800b00a1b68b5740asi6126225ejb.492.2023.12.13.21.41.39 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Dec 2023 21:41:39 -0800 (PST) Received-SPF: pass (google.com: domain of linux-crypto+bounces-825-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=OVgZWnyy; spf=pass (google.com: domain of linux-crypto+bounces-825-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-crypto+bounces-825-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 468C21F21AAE for ; Thu, 14 Dec 2023 05:41:39 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 711816AB6; Thu, 14 Dec 2023 05:41:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="OVgZWnyy" X-Original-To: linux-crypto@vger.kernel.org Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EE52FAC; Wed, 13 Dec 2023 21:41:29 -0800 (PST) Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 3BE2hRcI016504; Thu, 14 Dec 2023 05:41:17 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= message-id:date:mime-version:subject:to:cc:references:from :in-reply-to:content-type:content-transfer-encoding; s= qcppdkim1; bh=WnR2V1HDkmW5PBc0e7CWYokozIJgAwQp5DJQVrfapxQ=; b=OV gZWnyyHXm5GmwGpA/L4d5qgQiCm/lPMr5AtUjd8rfQcZkzO+zkHzAs5MSGqsdZyV P4sq4bFhui+rXkRD03Af8JYTq1Jwr5vrVumWfvyO9DrcNt8jmCkREAWU7PINs6N4 B1ish8aA4j3CvUFxS2m+MIWJBjlgrQ8Ltt3dEPc3X03fjRSt7bz3M2Q29Isl0FST Sn28bDDG+Waj6Ajdrt7X7WoPGvdsgCIyHHaQX6K2YM3y2qw+0OPzRr4JRzfmgVfn jmojX77HH1IBTsHSRguzrBZjRkEbjN6ndfPSMl4NFeRuleUEcgInwAkB4zArOP08 WcMV2bszjY5Op4BX1dzw== Received: from nalasppmta05.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3uyq2trh02-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 14 Dec 2023 05:41:17 +0000 (GMT) Received: from nalasex01b.na.qualcomm.com (nalasex01b.na.qualcomm.com [10.47.209.197]) by NALASPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 3BE5fGlL005831 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 14 Dec 2023 05:41:16 GMT Received: from [10.216.56.9] (10.80.80.8) by nalasex01b.na.qualcomm.com (10.47.209.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Wed, 13 Dec 2023 21:41:11 -0800 Message-ID: <6b79c66d-7591-443b-92e5-beeff6c93ae4@quicinc.com> Date: Thu, 14 Dec 2023 11:11:07 +0530 Precedence: bulk X-Mailing-List: linux-crypto@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V2 2/2] arm64: dts: qcom: sc7280: add QCrypto nodes To: Krzysztof Kozlowski CC: , , , , , , , , , , , , , , References: <20231212133247.1366698-1-quic_omprsing@quicinc.com> <20231212133247.1366698-3-quic_omprsing@quicinc.com> Content-Language: en-US From: Om Prakash Singh In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01b.na.qualcomm.com (10.47.209.197) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: Wi5nIYlPga3ktMlviCFTYu4wTZDV_8Xu X-Proofpoint-ORIG-GUID: Wi5nIYlPga3ktMlviCFTYu4wTZDV_8Xu X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-12-09_02,2023-12-07_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 mlxscore=0 phishscore=0 clxscore=1015 mlxlogscore=921 priorityscore=1501 lowpriorityscore=0 malwarescore=0 suspectscore=0 bulkscore=0 adultscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2311290000 definitions=main-2312140033 On 12/12/2023 8:32 PM, Krzysztof Kozlowski wrote: > On 12/12/2023 14:32, Om Prakash Singh wrote: >> Add the QCE and Crypto BAM DMA nodes. >> >> Signed-off-by: Om Prakash Singh >> --- >> >> Changes in V2: >> - Update DT node sequence as per register ascending order > > Hm, I don't see it... > >> - Fix DT node properties as per convention >> >> arch/arm64/boot/dts/qcom/sc7280.dtsi | 22 ++++++++++++++++++++++ >> 1 file changed, 22 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi >> index 66f1eb83cca7..7b705df21f4e 100644 >> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi >> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi >> @@ -2272,6 +2272,28 @@ ipa: ipa@1e40000 { >> status = "disabled"; >> }; >> >> + cryptobam: dma-controller@1dc4000 { > > It still looks like not correctly ordered by unit address against other > nodes in the file. > Hi Krzysztof, Probably I am missing something basic here. I am trying to put entries addresses that are sorted wrt their current adjacent. And it looks fine to me. 1c0e000 (current exist) 1dc4000 (newly added) 1dfa000 (newly added) 1e40000 (current exist) > > > > Best regards, > Krzysztof >