Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp6561166rdb; Fri, 15 Dec 2023 01:59:04 -0800 (PST) X-Google-Smtp-Source: AGHT+IEMZ6DUKfvj3ZTZ8BeYOlA4hlqeKgjXlrg6uEFhQzp4y2QG5pC9v+AI4YoaAciBfkZwusIq X-Received: by 2002:a17:903:1110:b0:1d3:16a6:d49e with SMTP id n16-20020a170903111000b001d316a6d49emr10529479plh.51.1702634344233; Fri, 15 Dec 2023 01:59:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702634344; cv=none; d=google.com; s=arc-20160816; b=Gms1MIe+rhPEngKYi0sq91VCHLvh9eKD5xll7mSO1V61kE1bAqMgDqipYVq01XvBSJ Rc8mdAaTaYN8z09iQVlckoCFNtDtSPW9KYKwf9iFM/5nNuvTgvsQ/TC+GekPyoopnqdv 5lpmw57/Hd+o4SNGqg2HtUfDvoWJPT/Do2PQHpvXn0aLcBMCqyRTErJLyk5XOxBtHg8B 9wChmDXEfFcbCIxGpVYawe0VedgDRxq6diF5UIIxdcghpGgmCO64VkqV+v+79L370xRg gD90cG8WgZA7F0LXBvKcx0zY5GrOeFJUM23shNGaG6sF5a95ypKTDtuLyS4Ca3TQohhP +BzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date; bh=fHOHPwRraLf7hZiFQTGMUTXlQhcw03QFcULD9yaWMT0=; fh=VfBoW0fCN8FxO5iwVJcGm9htq+xIYYU761wp+115zyU=; b=hbFBM/C6HoQkHG1mZLSCx1fUWRxeE1esUFtCOpPzFHiq9V9cgfyimF240+8hkBUquz tiEh5d7sSjQg+WtrWU1+2tSkIl1TnKoR/eL+X7qKBLTuA10iy/ntx9i3vqtYEmw50P3j Z/4ylPaECzJW0jqHwN/NGK4+eBqcHtQrIe7msM8b78+obvEsscSZhmDnoOyKP2/UsSm+ Wf2gNexB4NvMByIWbCraY9iymQ7VquqZgqfHa6JDvYFqwUtyQKW2uvhus749EjuWRs+j BR5mOrhXJM8ygMEsnJ73DcQizn2bxheAvvlzjMkTLxpFLqvMHUo3Alb7Rzj0XzLuXIlP pGow== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto+bounces-854-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-crypto+bounces-854-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id g5-20020a636b05000000b005c685a1b3b4si12637543pgc.347.2023.12.15.01.59.04 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Dec 2023 01:59:04 -0800 (PST) Received-SPF: pass (google.com: domain of linux-crypto+bounces-854-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto+bounces-854-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-crypto+bounces-854-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 48B0B283E6E for ; Fri, 15 Dec 2023 09:59:02 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6B3731A5BB; Fri, 15 Dec 2023 09:58:42 +0000 (UTC) X-Original-To: linux-crypto@vger.kernel.org Received: from abb.hmeau.com (abb.hmeau.com [144.6.53.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 523ED19BD2; Fri, 15 Dec 2023 09:58:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gondor.apana.org.au Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gondor.apana.org.au Received: from loth.rohan.me.apana.org.au ([192.168.167.2]) by formenos.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1rE4xb-00BCm1-El; Fri, 15 Dec 2023 17:58:24 +0800 Received: by loth.rohan.me.apana.org.au (sSMTP sendmail emulation); Fri, 15 Dec 2023 17:58:33 +0800 Date: Fri, 15 Dec 2023 17:58:33 +0800 From: Herbert Xu To: Bharat Bhushan Cc: bbrezillon@kernel.org, arno@natisbad.org, schalla@marvell.com, davem@davemloft.net, alobakin@pm.me, masahiroy@kernel.org, tj@kernel.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] crypto: octeontx2: Fix cptvf driver cleanup Message-ID: References: <20231211044558.41461-1-bbhushan2@marvell.com> Precedence: bulk X-Mailing-List: linux-crypto@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231211044558.41461-1-bbhushan2@marvell.com> On Mon, Dec 11, 2023 at 10:15:58AM +0530, Bharat Bhushan wrote: > This patch fixes following cleanup issues: > - Missing instruction queue free on cleanup. This > will lead to memory leak. > - lfs->lfs_num is set to zero before cleanup, which > will lead to improper cleanup. > - Missing otx2_cptlf_shutdown() from cptvf driver cleanup > > Signed-off-by: Bharat Bhushan > --- > drivers/crypto/marvell/octeontx2/otx2_cptlf.c | 6 ++++-- > drivers/crypto/marvell/octeontx2/otx2_cptvf_main.c | 10 ++++------ > 2 files changed, 8 insertions(+), 8 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt