Received-SPF: pass (google.com: domain of linux-crypto+bounces-914-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <ee935fd4-d8be-4a1d-9ea9-2f75e157c782@intel.com>
Date: Mon, 18 Dec 2023 14:47:56 -0700
User-Agent: Betterbird (Linux)
Subject: Re: [PATCH 1/2] crypto: iaa - Change desc->priv to 0
To: Tom Zanussi <tom.zanussi@linux.intel.com>, <herbert@gondor.apana.org.au>,
	<davem@davemloft.net>, <fenghua.yu@intel.com>
CC: <tony.luck@intel.com>, <jacob.jun.pan@intel.com>,
	<christophe.jaillet@wanadoo.fr>, <linux-kernel@vger.kernel.org>,
	<linux-crypto@vger.kernel.org>, <dmaengine@vger.kernel.org>
References: <20231218204715.220299-1-tom.zanussi@linux.intel.com>
 <20231218204715.220299-2-tom.zanussi@linux.intel.com>
Content-Language: en-US
From: Dave Jiang <dave.jiang@intel.com>
In-Reply-To: <20231218204715.220299-2-tom.zanussi@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ajdqUEUxYSt0KzgrM2xiY2ZwVlFUVmtYSVB2c0xoTTZSeGxPOVMyRFFZUUNm?=
 =?utf-8?B?emNuT0dlaVE2YURwT1UwN3lYbWp6cittazI3dUVaVjNyczFmSHdodXdvclBz?=
 =?utf-8?B?RHNUM3Bsd3JtY1BMUUx1WWRGcE1Ecnp0MzNXcWF3SHQzUWlPWkZWUTI3TG8v?=
 =?utf-8?B?Zmt6NWxVNFJUZ1ZXalFaS09UWHhCbTZQd3VCY3FqcktTZEhrSURFbTI3K1dX?=
 =?utf-8?B?ZUZiM2c0ZXZGNnVxWmgycHdIaTVLcGtMcGx4U0VqR1BCaGZLczhnWnZQTk5H?=
 =?utf-8?B?UkdDMmwwVWFJeVBkbDM4OHRmVytMQTl6N3BJdTUxUzc1eXhBMHljNHpwWEl4?=
 =?utf-8?B?WHlNeCtib2M0Q2NtbVFoM0JVSzdUQjJndk5aZGplTWphNXlEV1Y4N2tudnh6?=
 =?utf-8?B?Um1TcWlPK0xrMFR1VXFvMnptTGF3VEE5N1g3R3FXUlQrL05HakE2SUNDZmxN?=
 =?utf-8?B?R0JNU0tDd3pHVkVBdDNGV0hmZEZ2RmJSS2R0SEEzR2JwL3VzZ3FoVTQvR1o0?=
 =?utf-8?B?ZC9wUWV0RVZXMkNRWXFQWjZPRktBVFFEb1haRGtucnYzV2lucXdDc2JVeHpa?=
 =?utf-8?B?TTR6VDU3R3V0blhHK0QxeWtRd3VwZU5oQi9MTURSZi91cHJDZ21tTUoyRUQv?=
 =?utf-8?B?NXlrU1VDUThFdEg4SnpqQ0xEaGZrbmxIU2tjUXRsQ3RoV0VkamVNYWNLelBr?=
 =?utf-8?B?NEpPaFdIS2p6TXNOZjlyOHVVN01BZW1ScUx0aTA5Q1dtL2YzeS9TUVhmS0dj?=
 =?utf-8?B?QTUzVTFzMzF5eVB2bDg5TGlPSysreHBIZ3k3cjVwb240b0lsbDZtSi8wTWZF?=
 =?utf-8?B?c2FQdjNNR3RJelVYUGRvaDUvdWlkTWJoK1ZHa29xOGJuNkxtOHAwMXkrMk8z?=
 =?utf-8?B?alN5bTl6WmhWM3FmS01Qem9rQlpTekltb0xoK2RPRWg2ZDJCT256U0dhVDRr?=
 =?utf-8?B?SFB1UWdtYkpKWDdqWE1WZGI4RjFmY3ZxU3E5K294ZWdDYkdYRjRkTUxad0Vx?=
 =?utf-8?B?a0tmOG5KZ2ZJd3lmYlAxcHRyWW9iWkhqWklNZnZiTjFvVWN0N3daQUdFMDFZ?=
 =?utf-8?B?K0M5Z0s0K21XOEg0YnEvQ0dBUCtDT1R4YjRCWVVWQTZMUjNoSDFJLzgweU56?=
 =?utf-8?B?eHh3aC90blpPSnd6MmxKWUE1WDhranBmWDVnd3pPY1JjWVo4V2RHWkNaWHhs?=
 =?utf-8?B?QkordTlaSUtudFc1K0xITjBTWk5CV2RjVnoxL1RUcXlGUVNpTHBLWXJIUGha?=
 =?utf-8?B?Q0xocG5tNzZKOGk0S2ExeWJwL1lTeTU1RlhjVDBIQmthU2NuWkNzbnhtcngz?=
 =?utf-8?B?bCt6UnNIUE54OHhNcFdYdThBQjY3THR1dldwOTR3VStENlFUV29rRmJTSUJI?=
 =?utf-8?B?eEZhTlVoTEpMUGozbTh6YWFhRUVhelBqTS85YWg2VTFiSFprTUFWdFlXbHFx?=
 =?utf-8?B?a3RDYk42UVNsdU1vMHcySUQ5TGsrRWdlVm44aGZndUpxeEVoYUJGZms4bUZu?=
 =?utf-8?B?cFNNYkN5WXVOYXpVU211WFY0amFFQWpUNEtWZ1NGTTkxWEhFc0hkc0Y3VHYz?=
 =?utf-8?B?U1c1SDZSbXF6d2ZIS1VNUVZENUpsUGgwUTlVR0IwN2RjZjVUekZ6K0ZIY3ln?=
 =?utf-8?B?QXJ5NjFra0I0TUJoVlNFWE9TR29CK0RrSGxsK2U0OWkzeEVlUFpkbUhsZS8x?=
 =?utf-8?B?b2lvYnRnOWZHei93MGt4Vm1WNEViYUp6YzlIdWVjNmx0TVhhZ2Z0VU5NUWtZ?=
 =?utf-8?B?M04zS0xLaWVsT1J1eU9vU3FQUXYwWmZQOVJlKzRxR0tXSlFTRzdwaGlEeTVt?=
 =?utf-8?B?SnNCS3hJWmxxMDQxTXM0NVhDaG00OUlSd1lXWTJhOU9TTmorVk1HWE9JOGMx?=
 =?utf-8?B?Ty82YzdLS1VPN3cwcjJNVjZJWWFXNW5PQ3JnNUZwTXhuWm9BY0M3MWxlOTgx?=
 =?utf-8?B?V0J0WUlRSE1udmFoZnBNaEUxNWQ1VzdlZTFYUTdSUS9IOVBTRVlNWEVPZGZl?=
 =?utf-8?B?VkZQczc1eDZSOWVDa25xOFFrbThYMTIzdEtIRHFqTGRSRXlyOWtDd2JrUTds?=
 =?utf-8?B?M1FraVVIaThsWmpYS3psTXZsL25rMFMyYjJDczZFQkhzVFpKYUx0S0NjdEp1?=
 =?utf-8?Q?kGR43Vuh4d50yojuJB8iwfpLK?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ce91a70f-b6e0-41af-c66f-08dc001300ae
X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB5984.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Dec 2023 21:47:59.7820
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xI5s0hluh0X6fwPrOrMBZaRrHrpD9iXmwGmqRn9LCyRLHQlz8etHBy4gRJWibkBq4mq+YABYCmVV0eMM9Gw6Sw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB6172
X-OriginatorOrg: intel.com


On 12/18/23 13:47, Tom Zanussi wrote:
> In order for shared workqeues to work properly, desc->priv should be
> set to 0 rather than 1.  The need for this is described in commit
> f5ccf55e1028 (dmaengine/idxd: Re-enable kernel workqueue under DMA
> API), so we need to make IAA consistent with IOMMU settings, otherwise
> we get:
> 
>   [  141.948389] IOMMU: dmar15: Page request in Privilege Mode
>   [  141.948394] dmar15: Invalid page request: 2000026a100101 ffffb167
> 
> Dedicated workqueues ignore this field and are unaffected.
> 
> Signed-off-by: Tom Zanussi <tom.zanussi@linux.intel.com>

Reviewed-by: Dave Jiang <dave.jiang@intel.com>

> ---
>  drivers/crypto/intel/iaa/iaa_crypto_main.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/crypto/intel/iaa/iaa_crypto_main.c b/drivers/crypto/intel/iaa/iaa_crypto_main.c
> index eafa2dd7a5bb..5093361b0107 100644
> --- a/drivers/crypto/intel/iaa/iaa_crypto_main.c
> +++ b/drivers/crypto/intel/iaa/iaa_crypto_main.c
> @@ -484,7 +484,7 @@ static int decompress_header(struct iaa_device_compression_mode *device_mode,
>  
>  	desc->decompr_flags = mode->gen_decomp_table_flags;
>  
> -	desc->priv = 1;
> +	desc->priv = 0;
>  
>  	desc->completion_addr = idxd_desc->compl_dma;
>  
> @@ -1255,7 +1255,7 @@ static int iaa_compress(struct crypto_tfm *tfm,	struct acomp_req *req,
>  		IDXD_OP_FLAG_RD_SRC2_AECS | IDXD_OP_FLAG_CC;
>  	desc->opcode = IAX_OPCODE_COMPRESS;
>  	desc->compr_flags = IAA_COMP_FLAGS;
> -	desc->priv = 1;
> +	desc->priv = 0;
>  
>  	desc->src1_addr = (u64)src_addr;
>  	desc->src1_size = slen;
> @@ -1409,7 +1409,7 @@ static int iaa_compress_verify(struct crypto_tfm *tfm, struct acomp_req *req,
>  	desc->flags = IDXD_OP_FLAG_CRAV | IDXD_OP_FLAG_RCR | IDXD_OP_FLAG_CC;
>  	desc->opcode = IAX_OPCODE_DECOMPRESS;
>  	desc->decompr_flags = IAA_DECOMP_FLAGS | IAA_DECOMP_SUPPRESS_OUTPUT;
> -	desc->priv = 1;
> +	desc->priv = 0;
>  
>  	desc->src1_addr = (u64)dst_addr;
>  	desc->src1_size = *dlen;
> @@ -1495,7 +1495,7 @@ static int iaa_decompress(struct crypto_tfm *tfm, struct acomp_req *req,
>  	desc->opcode = IAX_OPCODE_DECOMPRESS;
>  	desc->max_dst_size = PAGE_SIZE;
>  	desc->decompr_flags = IAA_DECOMP_FLAGS;
> -	desc->priv = 1;
> +	desc->priv = 0;
>  
>  	desc->src1_addr = (u64)src_addr;
>  	desc->dst_addr = (u64)dst_addr;