Received-SPF: pass (google.com: domain of linux-crypto+bounces-916-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <a7250eea-5fde-404e-701a-152b6a609419@intel.com>
Date: Mon, 18 Dec 2023 13:55:22 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.11.0
Subject: Re: [PATCH 1/2] crypto: iaa - Change desc->priv to 0
Content-Language: en-US
To: Tom Zanussi <tom.zanussi@linux.intel.com>, <herbert@gondor.apana.org.au>,
	<davem@davemloft.net>
CC: <dave.jiang@intel.com>, <tony.luck@intel.com>, <jacob.jun.pan@intel.com>,
	<christophe.jaillet@wanadoo.fr>, <linux-kernel@vger.kernel.org>,
	<linux-crypto@vger.kernel.org>, <dmaengine@vger.kernel.org>
References: <20231218204715.220299-1-tom.zanussi@linux.intel.com>
 <20231218204715.220299-2-tom.zanussi@linux.intel.com>
From: Fenghua Yu <fenghua.yu@intel.com>
In-Reply-To: <20231218204715.220299-2-tom.zanussi@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dWpDRmJ2Tk0ySzF5ZGpOMFkxMlJwQVUySmJPMXNjZjI1MHZiR3MrT2ZoYVRY?=
 =?utf-8?B?amRhVjNadHMxRnRzSExyaHR5b29YMldOaVhZcSs5UUdWcDROMjE5VFRWZmVy?=
 =?utf-8?B?eVpVNnIrSmtSdlpkcWd6NzV1dE9GUDRkOHpPMXZib2szWEU0Vm9rWUVScGhz?=
 =?utf-8?B?ZkRQeVhObXNaZVB6bVduQWJPYzY0di8wQjdnYlRiVEZ0TlY4NkpiVVppaE54?=
 =?utf-8?B?dDZrUlR1UE9GeG50Skk3NVBRRktXMGU2SWZLcjZ6TG9wSXZXWGViNEFFS2FP?=
 =?utf-8?B?d0NmdG9zckxIemlZbXI3dDNocFE5TTBUQ1JabnhGRE51emJrMDloWVJiK0Jj?=
 =?utf-8?B?a0kxdFg2MUg2aEhkUGxXVUtwNHV3L1I2MlV2bWtHU2xtVUdxOFV0Q3JMTXVx?=
 =?utf-8?B?cjM0R1lDTnhtZWxXR2FrY0YwTk5ZZnpsTG1TdWtGRThEa2Qxd2g2U1JSQkFv?=
 =?utf-8?B?LzVwZThhS084NEN0UkRCNGVMNGg1bmZSa2FqTks5V0pIU3puMEwwUEY5Q0VV?=
 =?utf-8?B?cWhteW9rcTMrQkpMSmk4S1dPSUJRamlxSDdMMG85YUNPNEdJWWV0VW9ad1VE?=
 =?utf-8?B?Y1V1U0MwQnhQUlBVUWZHblpTVUo5Ly9Ic1QyVExjclFzRXR4NlpDTnZQWnQw?=
 =?utf-8?B?S3IwL3lIRVpVRjE3Z01TSUxseUl5eGJCaVArdDQ4UFkreTlHYnJmQ012c1JE?=
 =?utf-8?B?dWphUUdFUFNvVGlXNGNTVktFc3loa1p3c0VVekVrZEs5c3BzRU1RVnhueDVN?=
 =?utf-8?B?ckxEa1c0YTlzdWxna1JzaDhqczA3dDFab2lhTDVRWDFmRlNQZjBZTHpHWGZp?=
 =?utf-8?B?V0VlNm1lRHVVMHpPdmdRamRaSVhiRlpRRnd0a2FuNEY2ODFmNEplUW5XTExw?=
 =?utf-8?B?aXlCZWR0MGJ0cHdEUmF2YUFid3NCR0JpVEVxeUNhZ2JxQ0Y5MTE0b1c0YmJK?=
 =?utf-8?B?eGk0QW1Zc0NzdGIzREZIcWxIblJ0ZkJTOHZPU1hOdGdxRzFSSUR1c2lRWlBx?=
 =?utf-8?B?cHNyN0d3aVdyZFlaQVFPNWJFa21iWitMWVFkZlhIODRWNlZRZU5MUkFEMXhH?=
 =?utf-8?B?OW94RzFwanVhSmZiWGpYVU1RYm5NNDhqVXJxdVB5QlpicjUwTXpyby9ydlBM?=
 =?utf-8?B?ZFdiVHlDbGtqa1lhdmkrWW9YR1VDUHVmZVFHaEY1cVN2VkF4dEpFQjIrVnd3?=
 =?utf-8?B?blV3WGl3dnlablpOYnhFd2cwQld3TXdJd29IUm90QjE5d0lZRGZuL2s0Yjhm?=
 =?utf-8?B?YmQxYnlNVk4vSHdZZmIvSzN6WCtXbFY5bnVabUw2QmZDOU12eVR2NHNPdFZE?=
 =?utf-8?B?K042ZTJ1L3oxanZLR2NqWDM0N1JOY1UrUG9xZUNVcTJkVHNBYWI0WnZTOUUy?=
 =?utf-8?B?MjRmTHRRcGlUQWtaSUZ5dnJyajRyUkJ6NDBXcHpHbHZQeitUVFdta3I2UG13?=
 =?utf-8?B?U2dZTDJXdDUxRUxnVTIxRElOcWUvTVRHc1hLQ0xIZVlOcGgzQ2lsUFpXRldk?=
 =?utf-8?B?d2lubG4xWWNTSHpRRDJURUxzcDNmNDRFYjNMSVc4Qm1ya2tpUThhM1JmTVM1?=
 =?utf-8?B?Vmg3SlZWcS9IWS84d0E0YlAzYlBPZEhXcE8xUWtCSDZBR0pKNkc2RXVFbWtZ?=
 =?utf-8?B?TUtyM3NBR2tBQlNBUlJWa1VrRE5BYTlvcnJ2Mk15NE1pTXlxWFFOeis1cDMw?=
 =?utf-8?B?MTdiM3VPU0hTQW1lOWlYRkc4QUJVbVI5T0pkWHpDcHdlb1dURitpRnBRK3Bm?=
 =?utf-8?B?Yk0yTEp4L0w3RUFHalpXWENXYngzOUR2YXZNRWNuV1dhUU4wZnpmWEZYN2xk?=
 =?utf-8?B?Z0FLQnVLQ1I1WWtLcnF2dGpFQTRITzNOZ1k3RFNOQWo3N2xTR0VBWnBvdjVq?=
 =?utf-8?B?U0cyTzhYbVFDei90S2VNV01QdTFpZXRsUHd1VUhaZlNybVdXQ2l4L2ZRWGpz?=
 =?utf-8?B?bk9OT2hYOXJNSHFWTXZnck56ZmxEQ3FOV0g0SkJaMXVLaDRzMWEvUVl1TnUw?=
 =?utf-8?B?d3c5Z3FNUFJTNjlSRVhtMFhsL0dMY0NJeWQ0TEp0c3N2RDcySUkyN3MwM2My?=
 =?utf-8?B?SmMyU0ZMNEZNWmQ1OXZXeXEreWlYU2ZkQ3JoZU5MWDZCVU5JZzRxSWE0ZCtt?=
 =?utf-8?Q?tVPsj4NrS5B1VH2sR1hsB3zFu?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c60940eb-5140-4915-ac6f-08dc00140f0d
X-MS-Exchange-CrossTenant-AuthSource: IA1PR11MB6097.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Dec 2023 21:55:33.3473
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: G9xcL8UpjcyfoOnf2gO/osDND8K85dqIhp7shazNjDtJ//1T4rVKcp9lbHr6D3C2o0aa4f3GZcB40nHhiGc/9g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB7032
X-OriginatorOrg: intel.com


On 12/18/23 12:47, Tom Zanussi wrote:
> In order for shared workqeues to work properly, desc->priv should be
> set to 0 rather than 1.  The need for this is described in commit
> f5ccf55e1028 (dmaengine/idxd: Re-enable kernel workqueue under DMA
> API), so we need to make IAA consistent with IOMMU settings, otherwise
> we get:
> 
>    [  141.948389] IOMMU: dmar15: Page request in Privilege Mode
>    [  141.948394] dmar15: Invalid page request: 2000026a100101 ffffb167
> 
> Dedicated workqueues ignore this field and are unaffected.
> 
> Signed-off-by: Tom Zanussi <tom.zanussi@linux.intel.com>

Reviewed-by: Fenghua Yu <fenghua.yu@intel.com>

Thanks.

-Fenghua