Received-SPF: pass (google.com: domain of linux-crypto+bounces-1005-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: ovidiu.panait@windriver.com
To: linux-crypto@vger.kernel.org
Cc: herbert@gondor.apana.org.au, davem@davemloft.net, festevam@gmail.com
Subject: [PATCH v2 04/14] crypto: sahara - improve error handling in sahara_sha_process()
Date: Sun, 24 Dec 2023 10:21:34 +0200
Message-Id: <20231224082144.3894863-5-ovidiu.panait@windriver.com>
In-Reply-To: <20231224082144.3894863-1-ovidiu.panait@windriver.com>
References: <20231224082144.3894863-1-ovidiu.panait@windriver.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?FgGhfa6sCL6QCXskiU+Yw2BwQceDhHkchziLaIudr4+ggd1pbfjIDeenCz+j?=
 =?us-ascii?Q?dR1vn+aRm8bZdBkhUnYdA/PVZz2M+ENt4T+iUIm1Q5o+SEKy/MJW2SOeosBT?=
 =?us-ascii?Q?Yis3tiuyCOuTBFQCrWect+PCwqsyxUkvINOEgIXkWhbxAfJJOy3khmyCCd07?=
 =?us-ascii?Q?OZSBUNj/y4gjEqt5WHZcmnBuyKWPFjolEC8OumKk8pO0DP8J8KvaRNS2+zeW?=
 =?us-ascii?Q?D8QHZDsnB+rZjoYUBgkX9imWM/IdmNqgEd34EmP9840UjkdkqjXzrEReGmmE?=
 =?us-ascii?Q?/Z90U/O0c75Di/ur6/c6KJPG67NBj7nszLljGmpbJnCSJl4Q2qWUZ5FfEtFT?=
 =?us-ascii?Q?kMVhreXnZpWtfNCNHNFJpe8dSEIeilNlRaoKWLPr9AnsKWTsWnWYA2cv+FFF?=
 =?us-ascii?Q?nO5ldBM/1Evx+zwM8JXr+EsH3s/rGKtZVppUAbUpuWhUpKudymy94iWOjt67?=
 =?us-ascii?Q?VsWkR57jkNPaPNUrFbiBEGuduNAknUJjaSZdYbuionJuEr7wHEuTEip+x1ku?=
 =?us-ascii?Q?nNEb73+mWrQnP32bKv1PX0OYdGM1jK0WfungmRFFOktp8C+KbpjzuR3Lu7r3?=
 =?us-ascii?Q?iMtjN+n0zple8Nvq2qJCAocF4D6uaAYfbM1xFMRdRigRVo1t44uSTTusllNI?=
 =?us-ascii?Q?2axT2SC9z0gtDe2Xna/hpO0VeVWzQKM44SZOrZDObtnzCKvHKpj0ff6NNgtc?=
 =?us-ascii?Q?pdU//b9U4l6tWkli9urQLOvqtwdYtYB9eVQnNLzKoLQUJeT8zNRPFa5+ud/q?=
 =?us-ascii?Q?nXRIMwRti0rTliDN4u1ianuGu1+DdWj5q7qXggvtyvhbO7MD/pAPZCo5ib8I?=
 =?us-ascii?Q?OJ0bJjLP+2tM0Kmm5b3NyADbQ2vsLkTM3qH0InlumXxav9OXOpWObvEMeneX?=
 =?us-ascii?Q?77bzbu/GCcOn3CRkT3GfSpiRn8268ZnEwigY9nTDnHC9WbgdUWSyHZGt+184?=
 =?us-ascii?Q?HCTFQCXgGrDeaOHRMGoFzG82UAS3vvwbsQM5eVEqghGBJxgU1I0FhbTgtlI7?=
 =?us-ascii?Q?jiRcj6N7xkmuZygmvNKOerhk2LuPy8pEEvPm33lnimkxEVGndGiXIf/JIOuf?=
 =?us-ascii?Q?CKF8CIhM/OxtObpiqyiAabeOd0gi+q6Abp4BQl7x8RTqkenRdeMnImi8kIpi?=
 =?us-ascii?Q?zv+JP2zBu5IzxleVqr7lfpPKGrSGr1JZxbtKEkuLgeuxw0IHFelbm2tXlc+n?=
 =?us-ascii?Q?wbmcYFeGqZ8n9w4saC2GAhP3D46wddV7jynkx7IwsM3UuJM3OFMjEKSl7K38?=
 =?us-ascii?Q?8kxxZj2KkL3xt2kX+Q/TINLSqPGbNmHu6lTCEtirCpZkjiFfdXgff/wZFnEi?=
 =?us-ascii?Q?l1J5Vs6PDyuw8Yans+y7w3UQSUkj8os2pBhEQNaEG8CHhpDLbbvTMa9ueqB0?=
 =?us-ascii?Q?D6nvHnrHNKewCDdYAGyVlz7kKKK0S75c5n68E8LbDjQNgVcCTrLHIdJeyX0h?=
 =?us-ascii?Q?PtWDghQB+zv1E6zhc+jGmRaDsXg3j9W2dxJq3ZqPx8oFFmEp6TT5TjPxbLo9?=
 =?us-ascii?Q?My6clwlCI63bWpVeOf53mvm1HmPY+1iLcxEvYUUORaYdGceigXWHUI2rut1p?=
 =?us-ascii?Q?tIrLK74HkX6jstK5F/ijI7HxWbykK2oAAqW+MOSz1uK4H1ctVI6zNSU0BCML?=
 =?us-ascii?Q?9A=3D=3D?=
X-OriginatorOrg: windriver.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 766fd93a-c782-447d-ef53-08dc0459462a
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5327.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Dec 2023 08:21:05.8061
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ddb2873-a1ad-4a18-ae4e-4644631433be
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6GYGMuzEG8pRmrx1vjg65as3SfuAIq/CGSWkDHqLQINUGAt9aTcF6mOJVuJVt9WcdZmSNAI1UBv7a1es95qR3+YD4KpBm8u0yXuW1zyTyqw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7246
X-Proofpoint-GUID: SLQ79RyHF2ytDDclGJqJdc6js1hd7VXQ
X-Proofpoint-ORIG-GUID: SLQ79RyHF2ytDDclGJqJdc6js1hd7VXQ
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-11-16_25,2023-11-16_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=999
 priorityscore=1501 mlxscore=0 bulkscore=0 impostorscore=0 adultscore=0
 clxscore=1015 phishscore=0 spamscore=0 suspectscore=0 malwarescore=0
 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.19.0-2311290000 definitions=main-2312240066

From: Ovidiu Panait <ovidiu.panait@windriver.com>

sahara_sha_hw_data_descriptor_create() returns negative error codes on
failure, so make sure the errors are correctly handled / propagated.

Fixes: 5a2bb93f5992 ("crypto: sahara - add support for SHA1/256")
Signed-off-by: Ovidiu Panait <ovidiu.panait@windriver.com>
---
 drivers/crypto/sahara.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/drivers/crypto/sahara.c b/drivers/crypto/sahara.c
index a9abf6439c4b..d49659db6a48 100644
--- a/drivers/crypto/sahara.c
+++ b/drivers/crypto/sahara.c
@@ -985,7 +985,10 @@ static int sahara_sha_process(struct ahash_request *req)
 		return ret;
 
 	if (rctx->first) {
-		sahara_sha_hw_data_descriptor_create(dev, rctx, req, 0);
+		ret = sahara_sha_hw_data_descriptor_create(dev, rctx, req, 0);
+		if (ret)
+			return ret;
+
 		dev->hw_desc[0]->next = 0;
 		rctx->first = 0;
 	} else {
@@ -993,7 +996,10 @@ static int sahara_sha_process(struct ahash_request *req)
 
 		sahara_sha_hw_context_descriptor_create(dev, rctx, req, 0);
 		dev->hw_desc[0]->next = dev->hw_phys_desc[1];
-		sahara_sha_hw_data_descriptor_create(dev, rctx, req, 1);
+		ret = sahara_sha_hw_data_descriptor_create(dev, rctx, req, 1);
+		if (ret)
+			return ret;
+
 		dev->hw_desc[1]->next = 0;
 	}
 
-- 
2.34.1