Received-SPF: pass (google.com: domain of linux-crypto+bounces-1012-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: ovidiu.panait@windriver.com
To: linux-crypto@vger.kernel.org
Cc: herbert@gondor.apana.org.au, davem@davemloft.net, festevam@gmail.com
Subject: [PATCH v2 11/14] crypto: sahara - remove 'active' flag from sahara_aes_reqctx struct
Date: Sun, 24 Dec 2023 10:21:41 +0200
Message-Id: <20231224082144.3894863-12-ovidiu.panait@windriver.com>
In-Reply-To: <20231224082144.3894863-1-ovidiu.panait@windriver.com>
References: <20231224082144.3894863-1-ovidiu.panait@windriver.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?m0GzdnrZItpn4YH7QhOfsdXcsaroxWnv0WWN9dj5pdQ55EXSzc1LggIm7dzX?=
 =?us-ascii?Q?tSGZekMUMYoeH5pKax0RjDTp+BCgEEwltyVqDUw2N1KFSfLkR3CZUrb+JlGt?=
 =?us-ascii?Q?t+WGQnONpCPywJnyITxMFAHWWEh8NhmySUnX4UMkQjQU3mxbjbXqv5he6EkV?=
 =?us-ascii?Q?uuFang9iCMaqZNR4U27zcHu1QmkeuUGwNAdqTFgjq6n6Uv28mdWfLh+pFdVH?=
 =?us-ascii?Q?Zbdc/ImOK8djfV8bWMjkpg/O1LZBOezQayCXvh+1uAjSSYg5gIOLtmXi8zuH?=
 =?us-ascii?Q?hYOFXtHZMKHm+s5XyVmh/GWehlKReYL9v0x+IpxxBsklghnQX41oUuMvyFQR?=
 =?us-ascii?Q?mYRlflmyiSrXZTSpmmZFBKbS7nVopzeOv5JIAaekMXuFXcSvoQPgG9CT2fLw?=
 =?us-ascii?Q?5G/BLl1rLRv8aFEz6JaoYT3XZks6ZW8zXd11qlNwJLy7YSLZabLE88cLqaq1?=
 =?us-ascii?Q?M5rQWJf+vYX7ky2L2qt4yIxCqkJZpVsIziMHm2a6Z1cucdKA2ucv+Oe1gDdF?=
 =?us-ascii?Q?AOUWEwhLY34ZEoBhvK1UIFZaGlrrs4iGCG+Uv1G3b+8+J63+hz+B74f0SlMI?=
 =?us-ascii?Q?9pkOvXpiDfzQs/iuMmbzGCgofqk+EkeYfUT5aO+v4FxXqyAdH/vYuHQEz4+1?=
 =?us-ascii?Q?PaVdCOccNwYKtiGGwXryYU+JkWIrc0PIiDGwZ5dMLqvWwytGpP1HZDwDBHbo?=
 =?us-ascii?Q?E/+MR9BTyDpykPt8ZxJj1bHE1+0Qr+vtrTO+/FFwLFD65Nr4uMksJjT15/qw?=
 =?us-ascii?Q?Kk8buqk2AvTe0w9XoECnRZEp6UL+2gEXWztKD3zMte+DZc4bfs9mr4dCvr/4?=
 =?us-ascii?Q?nIPnwxf4NutqdEvUxxaeZonr1K4W6m29KKVyLpiqUtfPw9/Vr/MZs3nepTek?=
 =?us-ascii?Q?f8vMmGxBcCrzWlFGjLAedY0I2PEifVlu1fjQZjnr3fj08nAvewk4ZiGbJwB9?=
 =?us-ascii?Q?OWxt3/mq7VnLphv+mw+lAJ0goTvT8I3pdF7t8euolcGsGCBeNBYgITYDAShT?=
 =?us-ascii?Q?IhYdeej8WCb4nUlB0utt7xAp1mRXHtUxTfVuP5jxX/JDNeOlKXvBtHhg19Am?=
 =?us-ascii?Q?FF6QR8evNawX7zT2xJg7nnBW++pp9gbzZ0KG5waTqygoGFfbr56AQJbjvG/q?=
 =?us-ascii?Q?lqAnpEREpFnRsFLONh+E4tX9/pS7r2hD9sDu09lE0snEGK5ZiXMqu+OfTCVB?=
 =?us-ascii?Q?LaAtKOO9Zv3WNkSt9IaCtWBzIno1zLkYBWIrqeRQtJxdfZU0dHcsTz8qAH9U?=
 =?us-ascii?Q?1lmbnBif2hvyUv45+LlJbuNWEvb4DTlBDKgCBdPK3qcJuiAJ+pOUWunvMXbD?=
 =?us-ascii?Q?aAGOP8VQD1oOXJ7Eaq0/EzWzlY+LDUE7xa8tm9CIXzxSoJnVl2UGeolEoTM2?=
 =?us-ascii?Q?Zq8rMFhpgTdEnQyQr69yqLmCySKnRhNCRkA3JHvsl5aGovCbpnmy5GSIty+2?=
 =?us-ascii?Q?poztnwjccOg8baaCeeHPrTB+uYEc3FXslC3pVRi5KFH6qq+SatrhX+AxoTwR?=
 =?us-ascii?Q?aekdtP1092Wk/e+lWQVgx9/I65ZF/ocq06QUXbrVz2OKw7PP4caQ7U0c+uHr?=
 =?us-ascii?Q?wTgFYlp6Dtp0hBx3R0spRxMN10RUueqQ0mIQSNFaTKMUGzumT+ioB73n5qae?=
 =?us-ascii?Q?HQ=3D=3D?=
X-OriginatorOrg: windriver.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a69d7844-85c6-4b60-5f49-08dc04594c49
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5327.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Dec 2023 08:21:15.9689
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ddb2873-a1ad-4a18-ae4e-4644631433be
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +moH5z7lDNDhlzOVDRTUWkGu+hDBND2q4jdJCqcusSB3tLKcHSq2meWjebuODILHvm3lXtKQHtYIyJTappVC0eLc9Hme+BqeagKniyOa5D8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4693
X-Proofpoint-ORIG-GUID: gm4fdWSCEGwhsDImMgLJtp72vZ5hvVos
X-Proofpoint-GUID: gm4fdWSCEGwhsDImMgLJtp72vZ5hvVos
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-11-16_25,2023-11-16_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 spamscore=0
 bulkscore=0 adultscore=0 malwarescore=0 clxscore=1015 lowpriorityscore=0
 priorityscore=1501 impostorscore=0 suspectscore=0 mlxlogscore=999
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.19.0-2311290000 definitions=main-2312240066

From: Ovidiu Panait <ovidiu.panait@windriver.com>

The 'active' flag is only used to indirectly set the 'first' flag.
Drop the 'active' flag and set 'first' directly in sahara_sha_init().

Signed-off-by: Ovidiu Panait <ovidiu.panait@windriver.com>
---
 drivers/crypto/sahara.c | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/drivers/crypto/sahara.c b/drivers/crypto/sahara.c
index 253a3dafdff1..cd14514a43bb 100644
--- a/drivers/crypto/sahara.c
+++ b/drivers/crypto/sahara.c
@@ -168,7 +168,6 @@ struct sahara_aes_reqctx {
  * @total: total number of bytes for transfer
  * @last: is this the last block
  * @first: is this the first block
- * @active: inside a transfer
  */
 struct sahara_sha_reqctx {
 	u8			buf[SAHARA_MAX_SHA_BLOCK_SIZE];
@@ -184,7 +183,6 @@ struct sahara_sha_reqctx {
 	size_t			total;
 	unsigned int		last;
 	unsigned int		first;
-	unsigned int		active;
 };
 
 struct sahara_dev {
@@ -1053,11 +1051,6 @@ static int sahara_sha_enqueue(struct ahash_request *req, int last)
 
 	rctx->last = last;
 
-	if (!rctx->active) {
-		rctx->active = 1;
-		rctx->first = 1;
-	}
-
 	spin_lock_bh(&dev->queue_spinlock);
 	ret = crypto_enqueue_request(&dev->queue, &req->base);
 	spin_unlock_bh(&dev->queue_spinlock);
@@ -1088,7 +1081,7 @@ static int sahara_sha_init(struct ahash_request *req)
 	}
 
 	rctx->context_size = rctx->digest_size + 4;
-	rctx->active = 0;
+	rctx->first = 1;
 
 	return 0;
 }
-- 
2.34.1