Received-SPF: pass (google.com: domain of linux-crypto+bounces-1193-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <20240101114432.28139-1-zajec5@gmail.com>
In-Reply-To: <20240101114432.28139-1-zajec5@gmail.com>
From: Rob Herring <robh@kernel.org>
Date: Tue, 2 Jan 2024 11:31:08 -0700
Message-ID: <CAL_Jsq+hpOS-rdOYasJ1dzU6d_vVDWv2CseRhYmNHA2H_p=_pw@mail.gmail.com>
Subject: Re: [PATCH RFC] dt-bindings: crypto: inside-secure,safexcel: make
 eip/mem IRQs optional
To: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= <zajec5@gmail.com>
Cc: Antoine Tenart <atenart@kernel.org>, Sam Shih <sam.shih@mediatek.com>, 
	Matthias Brugger <matthias.bgg@gmail.com>, 
	AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>, linux-crypto@vger.kernel.org, 
	linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, 
	linux-arm-kernel@lists.infradead.org, =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= <rafal@milecki.pl>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Jan 1, 2024 at 4:45=E2=80=AFAM Rafa=C5=82 Mi=C5=82ecki <zajec5@gmai=
l.com> wrote:
>
> From: Rafa=C5=82 Mi=C5=82ecki <rafal@milecki.pl>
>
> Binding for this cryptographic engine defined 6 interrupts since its
> beginning. It seems however only 4 rings IRQs are really required for
> operating this hardware. Linux driver doesn't use "eip" or "mem" IRQs
> and it isn't clear if they are always available (MT7986 SoC binding
> doesn't specify them).
>
> This deals with:
> arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dtb: crypto@10320000=
: interrupts: [[0, 116, 4], [0, 117, 4], [0, 118, 4], [0, 119, 4]] is too s=
hort
>         from schema $id: http://devicetree.org/schemas/crypto/inside-secu=
re,safexcel.yaml#
> arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dtb: crypto@10320000=
: interrupt-names: ['ring0', 'ring1', 'ring2', 'ring3'] is too short
>         from schema $id: http://devicetree.org/schemas/crypto/inside-secu=
re,safexcel.yaml#

Which platform does the schema currently match? None, because the
Marvell ones get these:

     28  crypto@800000: interrupt-names:5: 'mem' was expected
     28  crypto@800000: interrupt-names:4: 'eip' was expected
     28  crypto@800000: interrupt-names:3: 'ring3' was expected
     28  crypto@800000: interrupt-names:2: 'ring2' was expected
     28  crypto@800000: interrupt-names:1: 'ring1' was expected
     28  crypto@800000: interrupt-names:0: 'ring0' was expected
     28  crypto@800000: 'dma-coherent' does not match any of the
regexes: 'pinctrl-[0-9]+'

(28 is the number of occurrences)

The existing list of names defines the order AND index. Since there
are 2 versions already in use, you have to define 2 lists.

>
> Cc: Antoine Tenart <atenart@kernel.org>
> Ref: ecc5287cfe53 ("arm64: dts: mt7986: add crypto related device nodes")

Not a documented tag. Don't make-up your own ones.

> Cc: Sam Shih <sam.shih@mediatek.com>
> Signed-off-by: Rafa=C5=82 Mi=C5=82ecki <rafal@milecki.pl>
> ---
>  .../devicetree/bindings/crypto/inside-secure,safexcel.yaml      | 2 ++
>  1 file changed, 2 insertions(+)